From 853d19209ca0322abfc145e35de90f28b3210b73 Mon Sep 17 00:00:00 2001 From: Rick V Date: Thu, 11 Apr 2019 10:17:58 -0500 Subject: [PATCH] Revert "unbreak windows target" select 64-bit target by default (since normal devs REEEEEEEE at the sight of 4 byte ptrs) pretty much every _other_ linux/unix has a c++17 windows compiler This reverts commit a844c610493aa92b4a34b9101a85791e2f03c622. --- CMakeLists.txt | 2 +- Makefile | 4 ++-- contrib/cross/mingw32.cmake | 4 ++-- llarp/CMakeLists.txt | 4 ++-- 4 files changed, 7 insertions(+), 7 deletions(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index f98fdce68..be03d9830 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -53,7 +53,7 @@ if(${CMAKE_SYSTEM_NAME} MATCHES "SunOS") endif() if(WIN32) - set(CMAKE_CXX_STANDARD 14) + set(CMAKE_CXX_STANDARD 17) ENABLE_LANGUAGE(RC) set(CMAKE_CXX_STANDARD_LIBRARIES "${CMAKE_CXX_STANDARD_LIBRARIES} -lshlwapi") else() diff --git a/Makefile b/Makefile index ed64326b5..e100bfc68 100644 --- a/Makefile +++ b/Makefile @@ -198,7 +198,7 @@ android: android-gradle windows-debug-configure: clean mkdir -p '$(BUILD_ROOT)' - $(CONFIG_CMD) -DCMAKE_TOOLCHAIN_FILE='$(REPO)/contrib/cross/mingw32.cmake' -DCMAKE_BUILD_TYPE=Debug -DCMAKE_ASM_FLAGS='$(ASFLAGS)' -DCMAKE_C_FLAGS='$(CFLAGS)' -DCMAKE_CXX_FLAGS='$(CXXFLAGS)' + $(CONFIG_CMD) -DCMAKE_TOOLCHAIN_FILE='$(REPO)/contrib/cross/mingw.cmake' -DCMAKE_BUILD_TYPE=Debug -DCMAKE_ASM_FLAGS='$(ASFLAGS)' -DCMAKE_C_FLAGS='$(CFLAGS)' -DCMAKE_CXX_FLAGS='$(CXXFLAGS)' windows-debug: windows-debug-configure $(MAKE) -C '$(BUILD_ROOT)' @@ -206,7 +206,7 @@ windows-debug: windows-debug-configure windows-release-configure: clean mkdir -p '$(BUILD_ROOT)' - $(CONFIG_CMD) -DCMAKE_TOOLCHAIN_FILE='$(REPO)/contrib/cross/mingw32.cmake' -DCMAKE_BUILD_TYPE=Release -DCMAKE_ASM_FLAGS='$(ASFLAGS)' -DCMAKE_C_FLAGS='$(CFLAGS)' -DCMAKE_CXX_FLAGS='$(CXXFLAGS)' + $(CONFIG_CMD) -DCMAKE_TOOLCHAIN_FILE='$(REPO)/contrib/cross/mingw.cmake' -DCMAKE_BUILD_TYPE=Release -DCMAKE_ASM_FLAGS='$(ASFLAGS)' -DCMAKE_C_FLAGS='$(CFLAGS)' -DCMAKE_CXX_FLAGS='$(CXXFLAGS)' windows-release: windows-release-configure $(MAKE) -C '$(BUILD_ROOT)' diff --git a/contrib/cross/mingw32.cmake b/contrib/cross/mingw32.cmake index e54713827..6a853511f 100644 --- a/contrib/cross/mingw32.cmake +++ b/contrib/cross/mingw32.cmake @@ -18,8 +18,8 @@ set(USING_CLANG ON) set(CMAKE_C_COMPILER ${TOOLCHAIN_PREFIX}-clang) set(CMAKE_CXX_COMPILER ${TOOLCHAIN_PREFIX}-clang++) else() -set(CMAKE_C_COMPILER ${TOOLCHAIN_PREFIX}-gcc-posix) -set(CMAKE_CXX_COMPILER ${TOOLCHAIN_PREFIX}-g++-posix) +set(CMAKE_C_COMPILER ${TOOLCHAIN_PREFIX}-gcc) +set(CMAKE_CXX_COMPILER ${TOOLCHAIN_PREFIX}-g++) endif() set(CMAKE_RC_COMPILER ${TOOLCHAIN_PREFIX}-windres) diff --git a/llarp/CMakeLists.txt b/llarp/CMakeLists.txt index c1482e379..567a074c8 100644 --- a/llarp/CMakeLists.txt +++ b/llarp/CMakeLists.txt @@ -48,10 +48,10 @@ add_library(${UTIL_LIB} STATIC ${LIB_UTIL_SRC}) target_include_directories(${UTIL_LIB} PUBLIC ${CMAKE_CURRENT_SOURCE_DIR} ${PROJECT_SOURCE_DIR}/include) target_link_libraries(${UTIL_LIB} PUBLIC absl::synchronization) target_link_libraries(${UTIL_LIB} PUBLIC nlohmann_json::nlohmann_json) -target_link_libraries(${UTIL_LIB} PUBLIC absl::optional absl::variant absl::strings absl::hash) + # cut back on fluff if (NOT WIN32) -target_link_libraries(${UTIL_LIB} PUBLIC cppbackport) + target_link_libraries(${UTIL_LIB} PUBLIC absl::optional absl::variant absl::strings absl::hash cppbackport) endif(NOT WIN32) if(${CMAKE_SYSTEM_NAME} MATCHES "Linux")