2
0
mirror of https://github.com/lnbook/lnbook synced 2024-11-18 21:28:03 +00:00
Commit Graph

834 Commits

Author SHA1 Message Date
Andreas M. Antonopoulos
dba494976b
Merge pull request #280 from 8go/patch-56
channel construction: pt1: minor improvements of English
2020-06-29 10:11:18 -04:00
Andreas M. Antonopoulos
eb669cc472
Merge pull request #279 from erubboli/patch-1
Fix `Glorias secret` hashing example
2020-06-29 10:10:32 -04:00
Andreas M. Antonopoulos
b3cb24267e README: Changed node_client chapter status and updated word count 2020-06-27 10:55:51 -04:00
Andreas M. Antonopoulos
dda03ffa54 Chapter ready for review: node_client.asciidoc
Finished chapter by demonstrating a whole Lightning network with diverse nodes using docker-compose. Added exercises for the reader. Ready for review!
2020-06-27 10:54:28 -04:00
Andreas M. Antonopoulos
61a0742f7b
Merge pull request #288 from nicolasburtey/develop
typo on Readme
2020-06-26 21:38:21 -04:00
nicolasburtey
296de82e7a
typo 2020-06-26 17:40:51 -07:00
Andreas M. Antonopoulos
5119c51aae Updated README wordcounts 2020-06-26 09:52:31 -04:00
Andreas M. Antonopoulos
f0912b961b Chapter node_client: Eclair container and building from source 2020-06-26 09:51:40 -04:00
Donovan
336b042ae4
typos 2020-06-26 11:40:29 +02:00
Donovan
b74904e4a3
another typo 2020-06-26 10:57:41 +02:00
Donovan
aae44606c1
another typo 2020-06-26 10:31:58 +02:00
Andreas M. Antonopoulos
2baac1fc0a Chapter node_client: installing LND from source 2020-06-25 11:36:01 -04:00
Donovan
83b5262ebf
ch03: fix typo 2020-06-25 16:27:17 +02:00
8go
2d38c09739
channel construction: pt1: minor improvements of English
- of course ==> of course,
- core for ==> core of something
- is there and exists ==> repetitive
- learnt: ==> US English learned, UK and South African English: learnt, since there are more US readers than UK readers I would go with US English
- learnt already --> word order: already learned
- quite a bit : too fluffy, too relative ==> removed
- This will repeat some ==> sentence structure can be improved, restructured
2020-06-24 13:43:26 +00:00
Enrico Rubboli
6f76f9620f
Fix Glorias secret hashing example 2020-06-23 19:43:34 +02:00
Andreas M. Antonopoulos
a343d41a70 Update README wordcounts and progress 2020-06-23 10:28:17 -04:00
Andreas M. Antonopoulos
548eb5ceb5 Docker basic commands, LND writeup, formatting 2020-06-23 10:27:06 -04:00
Andreas M. Antonopoulos
a07b6499e6 Chapter update: c-lightning container, docker network 2020-06-22 10:38:45 -04:00
HAOYUatHZ
5f02a8a6df
thrid -> third (#278) 2020-06-21 22:24:39 +02:00
HAOYUatHZ
14976b27b9
routing: fix typos and remove trailing spaces (#277)
* challange -> challenge

* deliverd - delivered

* more on deliverd - delivered

* mallicous -> malicious

* aquire -> acquire

* one more aquire -> acquire

* deposied -> deposited

* noone -> no one

* desireable -> desireable

* commited -> committed

* everone -> everyone

* btween -> between

* shoul -> should

* encrtypted -> encrypted

* didicated -> dedicated

* derrivation -> derivation
2020-06-21 22:23:51 +02:00
8go
5b33427dba
ch03: Scarcity, scarce resource differences between Bitcoin and Lightning (#257)
* Scarcity, scarce resource differences between Bitcoin and Lightning

- added additional difference between BTC and LN

* softened

- replaced "each one according to its scarcity" with "... influenced by..." to soften it.
- added "primarily" to "pay primarily for block space" to soften it
- added "by and large" to "...pay by and large for channel capacity" to soften it

* removed last 3 lines according to suggestion
2020-06-21 22:18:33 +02:00
Andreas M. Antonopoulos
f119fc8bec Merge remote-tracking branch 'origin/develop' into develop 2020-06-20 11:19:57 -04:00
Andreas M. Antonopoulos
ac89953e7e Nodes: docker interaction 2020-06-20 11:19:52 -04:00
Hugo Doyon
f719a2b968
Wording (#249)
throught for through

Co-authored-by: Rene Pickhardt <rene@rene-pickhardt.de>
2020-06-20 11:49:25 +02:00
8go
b0e32c0cbb
glossary: minor cleanup, consistent naming, etc (#256)
* minor cleanup, consistent naming, etc

- typo
- consistent naming:
  - uppercased all "lightning" to "Lightning"
  - all Lightning networks, to "Lightning Network"
- remove "oldid" URL REST parameter from wikipedia links
- added links where appropriate
- etc

* put the oldid argument in the 4 or 5 URLs back in
2020-06-20 11:43:14 +02:00
8go
917a356db0
ch02: added website check to avoid going to fake website (#263)
- added 1 sentence: She verifies that the webpage is secure (https not http) which is shown as a green lock by some browsers.
2020-06-20 11:39:17 +02:00
8go
f1bab59317
ch01: Acronym LN (mostly)removed (#261)
- I removed acronym from first sentence and put it into the second. I did not feel that it is a good start when the first sentence of the book already has an acronym.
- Removed LN acronym 4-5 times further down. It was not consistently used anyway. Sometimes yes, sometimes no. I also think it reads better spelled out. So, for a book I feel it is better to spell it out 4 times, than to abbreviate it 4 times.
2020-06-20 11:38:22 +02:00
8go
764313b4ca
ch03: Added monetary limit to commonality of BTC and Lightning (#260)
* Added monetary limit to commonality of BTC and Lightning

As an alternative a new paragraph could be added with title "Monetary Limit" but I thought that adding two sentences to the "Monetary Unit" section would be enough.

* ch03: adjusted to incorporate comment
2020-06-20 11:37:42 +02:00
Hugo Doyon
c1266e5e13
maliciously (#253)
* maliciously

maliciously instead of malicously

* Update 03_how_ln_works.asciidoc

fixed another typo

Co-authored-by: Rene Pickhardt <rene@rene-pickhardt.de>
2020-06-20 11:33:16 +02:00
8go
678c3dad32
ch03: Fee incentives as difference between Bitcoin and Lightning (#259)
* Fee incentives as difference between Bitcoin and Lightning

- basically explaining that the $1M tx will always remain on BTC, ...

* improved following reviewers suggestion
2020-06-20 11:32:58 +02:00
8go
73ab568bbf
global replacement of "LN Wallet" with "Lightning Wallet" (#265)
- see also Issue #175 
- 3 occurrences replaced
2020-06-20 11:26:23 +02:00
8go
b5dbc95326
replaced LN with Lightning in specific instance (#266)
- when I read this I thought twice that someone is trying to abbreviate "Lightning Node" with "LN". 
- only on 3rd reading I realized that as usual "LN" stands for "Lightning Network" and the word "node" follows 3 words later
- anyway, to avoid confusion it should be replaced
2020-06-20 11:25:52 +02:00
8go
c12ba731b9
ch03: replaced "LN" with "Lightning Network" exactly one (#267)
- Acronym "LN" shows up 3 time in chapter 3
- Twice explained (the definition): these I left in, because further chapters will/might make use of the acronym
- The third occurrence I replaced, as it adds just 1 work to the book, increases readability, is inconsistent with rest of this chapter
2020-06-20 11:25:14 +02:00
8go
cbbf9594ae
ch02: global replacement of "LN Node" with "Lightning Node" (#268)
- see also Issue #174 
- see also Issue #175 
- is is also "Bitcoin Node", not "Bitcoin Network Node"
- simpler is better, shorter is better
- 7 occurrences were replaced
2020-06-20 11:24:47 +02:00
8go
d1ae621bb4
ch02: global replacement of "LN Invoice" with "Lightning Invoice" (#270)
- similar to PR #268 and PR #269 
- issues #174 and #175 
- 1 occurrence only 
- "Lightning Invoice" was already used in text, this fixes also the inconsistency
2020-06-20 11:22:47 +02:00
8go
22fb60541d
ch01: removed "very" 3 times (#272)
- removed 3 times the word "very"
- see Issue #171 
- low, high, cheap, expensive: is all very relative
- set expectations right
- who knows where the fees will be in 10 years
2020-06-20 11:21:37 +02:00
Andreas M. Antonopoulos
6a90b945bc Chapter update: bitcoind docker container, building and running 2020-06-19 10:50:31 -04:00
Andreas M. Antonopoulos
f8e6a63190 typo 2020-06-19 10:38:36 -04:00
Andreas M. Antonopoulos
8ec2d630a0 Makefile to build and push docker images to docker hub 2020-06-19 10:19:34 -04:00
Andreas M. Antonopoulos
9ec58a1504 Moved setup-channels and added delay 2020-06-19 10:19:12 -04:00
Andreas M. Antonopoulos
fdd63a661c Moved docker-compose to docker directory 2020-06-19 10:18:37 -04:00
Andreas M. Antonopoulos
b090055f9b Removed devenv docker 2020-06-19 09:04:19 -04:00
Andreas M. Antonopoulos
744ad752c3 Fixes #273 2020-06-18 17:22:44 -04:00
Andreas M. Antonopoulos
f0bf7aeed3 Alice to Gloria channels, invoice and payment setup
It works!
2020-06-18 15:46:04 -04:00
Andreas M. Antonopoulos
500eb00bbe Fix max-fee-rate-mismatch for eclair 2020-06-18 15:45:32 -04:00
Andreas M. Antonopoulos
6f25921336 Docker (wait-for-bitcoind) and docker-compose fixes
Sequencing of containers now works.
2020-06-18 14:35:47 -04:00
8go
962897c072
ch02: global replacement of "LN Channel" with "Lightning Channel"
- see similar PR #268 
- about 4 occurrences
2020-06-18 10:40:19 +00:00
Rene Pichardt
e43d0bfa82 Merge branch 'develop' of https://github.com/lnbook/lnbook into develop 2020-06-17 19:54:02 +02:00
Rene Pichardt
d1f082d79b work in progress of channel construction 2020-06-17 19:53:57 +02:00
Andreas M. Antonopoulos
bcaa4eed78 Docker cleanup and docker-compose start 2020-06-17 13:43:37 -04:00