- when I read this I thought twice that someone is trying to abbreviate "Lightning Node" with "LN".
- only on 3rd reading I realized that as usual "LN" stands for "Lightning Network" and the word "node" follows 3 words later
- anyway, to avoid confusion it should be replaced
- see also Issue #174
- see also Issue #175
- is is also "Bitcoin Node", not "Bitcoin Network Node"
- simpler is better, shorter is better
- 7 occurrences were replaced
- similar to PR #268 and PR #269
- issues #174 and #175
- 1 occurrence only
- "Lightning Invoice" was already used in text, this fixes also the inconsistency
* change wallet categories into wallet quadrant
The original categorization was not perfect. It was not ideal. It was sort of misleading. It sort of implies that a "Full Node & Wallet" is not a "Non-Custodial Wallet" because they are 2 different categories. It also states that a "Non-Custodial Wallet" uses "3rd-party node" for LN Node which is not the true definition.Things were getting mixed up here and we are not communicating a clear message.
The term "Custodial Wallet" is independent of which LN Node is used.
We should rethink this table and categorization.
I wrote an Issue about it #176 .
The Quadrant seems to be more useful and certainly more accurate.
Then I explained the terms "Lightweight" and "Node" because these terms were suddenly used, out of nowhere with no explanation.
* various improvements
- Following suggestions from @Roasbeef
- worked in his commentaries, ideas
- also added a bit more details
* added BIPs to Neutrino
Co-authored-by: Rene Pickhardt <rene@rene-pickhardt.de>
* removed an extra 'the' in this sentence
* suggested rephrasing of an unclear sentence in bullet five under What is the Lightning Network?
* fixed typo in own edit
* bolded headers in Table 1 and 2 of Getting Started
* fixed typo (reasigning should be reassigning)
* fixed typo (later should be latter)
* fixed typo (node_announcment should be node_announcement)
* fixed typo, crucually should be crucially
* fixed typo (abroated should be aborted)
* fixed typo (subsecquent should be subsequent)
* fixed typo (discoveres should be discovers)
* removed extra 'the' in sentence
* fixed typo (send should be sent)
* fixed typo (nods should be nodes
)
* clarifiactions and additions
some modifications to improve, clarify
some additions to add more details where appropriate
... lightweight Bitcoin client (commonly referred to as Simplified Payment Verification (SPV)) to partially validate the correctness of their blockchain. --> partially? Probably you mean "indirectly" as you delegate to a third party. Also SPVs clients don't have a blockchain, so why "their blockchain"? --> to reduce this confusion --> lightweight Bitcoin client (commonly referred to as Simplified Payment Verification (SPV)) to interact with the blockchain
... lightning wallets ... --> ... Lightning wallets ...
centralized and added more details to definition of non-custodial wallet
* Update 02_getting_started.asciidoc
added the sentince back in
Co-authored-by: Rene Pickhardt <rene@rene-pickhardt.de>
Removed "what constitutes the Lightning network", as e would have to go into a discussion about payment channels and it is too early for that. We will add that in later chapters.
