2
0
mirror of https://github.com/lnbook/lnbook synced 2024-11-15 00:15:05 +00:00
Commit Graph

122 Commits

Author SHA1 Message Date
Andreas M. Antonopoulos
bcb155eb85
Merge pull request #569 from batmanscode/develop
Minor wording and punctuation
2021-01-22 10:04:52 -06:00
Andreas M. Antonopoulos
a13efbc3a6
Merge pull request #575 from jerzybrzoska/patch-2
Consistency in spelling out the numbers that are < 10 (ch. 3)
2021-01-11 13:14:33 -06:00
Andreas M. Antonopoulos
eb7aff823d
Merge branch 'develop' into patch-5 2021-01-11 13:12:43 -06:00
Andreas M. Antonopoulos
e8e46646a8
Merge pull request #581 from jerzybrzoska/patch-6
Minor modification that removes ambiguity (ch. 3)
2021-01-11 13:11:26 -06:00
jerzybrzoska
9cac112c96
Minor modification that removes ambiguity (ch. 3)
I removed "You have". Now it's all in one sentence -- less ambiguous and more concise I believe. The more verbose alternative would be: 
>You have *time* until ...
2021-01-06 10:39:10 +01:00
jerzybrzoska
41b06b0d7f
Consistent spelling of timelock (ch. 3)
Both "timelock" and "time lock" are correct but let us be consistent and stick to the one form.
2021-01-04 10:02:44 +01:00
jerzybrzoska
28f1552be8
Update 03_how_ln_works.asciidoc
You are right [Umar](@bolatovumar) , I have not found a single source on the web with _two-of-two_, _2-of-2_ seems to be the standard. I edited my pull request, so now the changes do not include 2-of-2 modification. I find the issue of '2-of-2' vs 'two-of-two' interesting and may soon create a question on [English Stack Exchange](https://english.stackexchange.com/) in order to get their opinion.
2020-12-30 09:41:27 +01:00
jerzybrzoska
68ebd75d5b
Consistency in spelling out the numbers that are < 10
It would be well to maintain consistency in spelling out the numbers (provided that they are not code/math/ BTC amounts) that are < 10. I left out "chapter 6" and the like unchanged. 
[A post about style][1] for the reference.
>In scientific and technical writing, the prevailing style is to write out numbers under ten. While there are exceptions to these rules, your predominant concern should be expressing numbers consistently.

[1]: https://www.grammarly.com/blog/when-to-spell-out-numbers/
2020-12-28 19:42:53 +01:00
Scott-Driscoll
b0e3d9f5cd
We will not review these advanced... in depth 2020-12-27 08:46:44 -05:00
Scott-Driscoll
f70c014507
We will not revise these concepts --> We will not review 2020-12-22 19:36:30 -05:00
batmanscode
05b29ed36b
Minor wording and punctuation
**Changes:**

* Added some missing full stops.
* 'meaning a pre-defined process based on cryptography, used by the channel partners to re-distribute' to 'meaning a pre-defined process based on cryptography is used by the channel partners to re-distribute'
* 'Payment channels basics' to 'Payment channel basics'
* 'Channels partners can agree to announce' to 'Channel partners can agree to announce'
* 'don’t need to trust your channel to retrieve the balance of your channel' to 'don’t need to trust your channel partner to retrieve the balance of your channel'
* 'present a Lightning invoice to Alice as a QR code, or send it via email, or any other message channel' or 'present a Lightning invoice to Alice as a QR code, send it via email, or any other message channel'
* 'who just sent her an uninvitedly email' to 'who just uninvitedly sent her an email'
* 'addresses as part of payment channel on the Lightning Network' to 'addresses as part of payment channels on the Lightning Network'
* 'We looked at how payments are routed. Finally, we compared Lightning and Bitcoin and analyzed their differences and commonalities' to 'We looked at how payments are routed and finally, we compared Lightning with Bitcoin and analyzed their differences and commonalities'
2020-12-14 03:27:38 +05:30
Andreas M. Antonopoulos
e7637ba2a1
Merge pull request #545 from bitcoincoretech/ch_03
Chapter: 03_how_ln_works
2020-12-08 09:11:50 -06:00
Andreas M. Antonopoulos
909c8190c9
Merge pull request #544 from justinmoon/multisig-typo
Fix typo
2020-12-08 09:10:30 -06:00
Vlad Stan
8437018394 ch_3: add missing verb 2020-11-24 16:31:59 +02:00
Justin Moon
ae9b49b892 Fix typo 2020-11-21 17:25:53 -06:00
Vlad Stan
48430f4ed2 small typo 2020-11-20 19:59:44 +02:00
Vlad Stan
7f4f648f62 fix first bullet point 2020-11-20 17:54:45 +02:00
Vlad Stan
5535b3651b use bulletpoints for "channel limitations"; be consistent with the below "useful properties" 2020-11-20 17:53:56 +02:00
Umar Bolatov
4f91a1ea98
Update spelling in Ch. 3
close #539
2020-11-17 18:35:21 -08:00
Andreas M. Antonopoulos
668d59640b Fixes #448 2020-10-28 08:50:12 -06:00
Andreas M. Antonopoulos
d1cc9eed23 Fixes #437 2020-10-28 08:30:56 -06:00
Andreas M. Antonopoulos
e253756ced Fixes #435 2020-10-14 09:19:51 -05:00
Andreas M. Antonopoulos
9522121745 Fixes #435 2020-10-14 09:18:36 -05:00
Andreas M. Antonopoulos
ea5758ae99 Fixes #432 2020-10-07 09:51:28 -05:00
Andreas M. Antonopoulos
4d9774e519 Fixes #431 2020-10-07 09:44:38 -05:00
Andreas M. Antonopoulos
cc88e22889 Fixes #430
Fixes #430
2020-10-07 09:41:28 -05:00
Andreas M. Antonopoulos
7fef49f61e
Merge pull request #508 from dangershony/patch-2
how ln works -typo
2020-09-29 09:16:57 -04:00
Andreas M. Antonopoulos
0a4f1ad4cb
Merge pull request #509 from tigeryant/develop
How ln works - typos
2020-09-29 09:16:48 -04:00
tigeryant
35c888f18d
Update how ln works - typo
Corrected two typos - 'put' to 'puts' and 'send' to 'sends'
2020-09-27 20:50:39 +01:00
tigeryant
9dcbefc063
Update 03_how_ln_works.asciidoc 2020-09-26 18:35:57 +01:00
Dan Gershony
35f03e67b5
how ln works -typo 2020-09-23 21:54:20 +01:00
Alex Prut
9ca2e94f3e Chapter: How LN Works - fix typos, punctuation 2020-09-22 20:57:21 +02:00
Dan Gershony
b1be808423
Update 03_how_ln_works.asciidoc 2020-09-22 16:30:13 +01:00
Dan Gershony
bf23aab48b
How LN works - typo 2020-09-22 16:17:57 +01:00
Dan Gershony
de3f8df8cb
Fix typo 2020-09-21 16:58:08 +01:00
René K
abe9b4835f
Merge branch 'develop' into patch-1 2020-09-15 21:54:01 +02:00
Andreas M. Antonopoulos
9525765885
Merge branch 'develop' into chapter_3_edits 2020-09-15 12:40:00 -04:00
René K
7a3830cc49
Update 03_how_ln_works.asciidoc
Some typos fixed.
2020-09-08 13:10:03 +02:00
Sergei Tikhomirov
04719c86de minor edits in Chapter 3 2020-09-03 23:05:06 +02:00
Imran
44314b62e1
Typo 2020-09-02 15:38:14 +02:00
Imran
25de2edda1
Update 03_how_ln_works.asciidoc 2020-08-30 16:43:28 +02:00
Imran
0a47707142
How LN Works - Closing a channel (Language edits)
Incorporated some edits from the defunct pull request below to make this section read a little more easily. Some particulars

* Instead of stating as good way, bad way, ugly way -> state as their technical name and put (the good way) bracketed after
* The first and third examples referred to "you" and the second referred to "Alice and Bob". All three now refer to "you"
* Each paragraph now describes the method with a one liner
* Some miscellaneous detail

https://github.com/lnbook/lnbook/pull/307
2020-08-30 16:41:10 +02:00
Emilio Norrmann
97a83e2405
Update 03_how_ln_works.asciidoc (#367)
I don't know who Mallory is.. perhaps he is talking about Bob
2020-08-26 15:53:07 +02:00
Cypher Perro
2cea66d0ab
Fixed typo: "yas" --> "as" (#357) 2020-08-19 15:12:23 +02:00
Adam Jonas
ac469ee938
spelling/ grammar for chap 3 (#356) 2020-08-19 15:11:56 +02:00
Francisco Calderon
99ded49570
Enumerate using asciidoc for better readability (#336) 2020-08-05 15:01:51 +02:00
Andreas M. Antonopoulos
846a14d62e Fixes to edit review 2020-07-30 10:00:01 -04:00
Andreas M. Antonopoulos
41ecb86f50 Fixes to edit review 2020-07-30 09:57:20 -04:00
Andreas M. Antonopoulos
3d01fcb634 Fixes to edit review 2020-07-30 09:55:06 -04:00
Andreas M. Antonopoulos
b2dccdffe0 Fixes to edit review 2020-07-30 09:53:02 -04:00