Archives
/
lnbook
mirror of https://github.com/lnbook/lnbook
2
0
Fork 0
Code Issues Projects Releases Wiki Activity
1,308 Commits
2 Branches
1 Tag
154 MiB
develop
routing-chapter-edits
firstedition_firstprint
Branches Tags
${ item.name }
Create tag ${ searchTerm }
Create branch ${ searchTerm }
from '0c578aa441'
${ noResults }
Commit Graph

98 Commits (0c578aa441ac949ada922d5bf1285e6364a73102)

Author SHA1 Message Date
Andreas M. Antonopoulos b450bbeed0
Merge pull request #614 from keblek/patch-5 
Fix formatting
 4 years ago
Andreas M. Antonopoulos 7cd230d381
Merge pull request #613 from keblek/patch-4 
changed git clone to HTTPS
 4 years ago
Andreas M. Antonopoulos 4f8a6508d1
Merge pull request #611 from keblek/patch-2 
Removed -y flag in apt command
 4 years ago
Andreas M. Antonopoulos 4723491456
Merge pull request #608 from HannahMR/wrap-text 
Wrap text
 4 years ago
keblek 924e253d66
Added start docker command 
Also removed the redundant information.
 4 years ago
keblek 1764b9163c
Fix formatting 4 years ago
keblek 8e2b0b8ac5
changed git clone to HTTPS 
By using SSH on a fresh OS install you have to establish the public key of GitHub and if you don't have it you have to a song and dance about it. With HTTPS it works every time. Unless of course this is a security measure, in which case ignore this post.
 4 years ago
keblek 7682acb7d9
Removed -y flag in apt command 
Someone could copy paste it and with the y flag it would automatically install. It’s Java on Ubuntu so it’s probably fine, but it’s a bad precedent to have commands that change so much in a users system without them explicitly approving. 

This is an opinion.
 4 years ago
Hannah 71c8bfee2d Adding [source,bash] to a few more places that may need it. 4 years ago
Hannah 8af6f5361f Adding [source,bash] where needed for the rest of the chapter. 4 years ago
Hannah 1d6122bdc5 Adding [source,bash] to wrap text. 4 years ago
jerzybrzoska bd68075856
node_client.asciidoc: "collaboratively developed" instead of "collaborative developed" (#597) 
[Collaborative](https://dictionary.cambridge.org/dictionary/english/collaborative) is not an adverb, [collaboratively](https://en.wiktionary.org/wiki/collaboratively) is. I also added 'are' for the sake of [parallelism](https://en.wikipedia.org/wiki/Parallelism_(grammar)), the said 'are' is optional, though.
 4 years ago
Janus Troelsen 7231f5f102 Update Eclair manual building instructions 
- Explain something that looks like a version number ("2.13").
- Explain how to skip tests, which are fragile on master and not run for the other clients.
 4 years ago
Andreas M. Antonopoulos b6d8ddda43
Merge pull request #559 from quantumcthulhu/patch-6 
node_client.asciidoc typo
 4 years ago
Andreas M. Antonopoulos 86bbaf4315
Merge pull request #558 from quantumcthulhu/patch-5 
node_client.asciidoc typo
 4 years ago
Andreas M. Antonopoulos 69a73d26c5
Merge pull request #557 from quantumcthulhu/patch-4 
node_client.asciidoc typo
 4 years ago
Andreas M. Antonopoulos b9a85b7878
Merge pull request #556 from quantumcthulhu/patch-3 
node_client.asciidoc typo
 4 years ago
Andreas M. Antonopoulos 7df01f2ce1
Merge pull request #551 from quantumcthulhu/patch-2 
node_client typo
 4 years ago
Andreas M. Antonopoulos ead01d52e3
Merge pull request #546 from quantumcthulhu/patch-1 
node_client mistype
 4 years ago
quantumcthulhu 73436baf5f
node_client.asciidoc typo 
Shell commands start with "$"
 4 years ago
quantumcthulhu 724f03116e
node_client.asciidoc typo 
Shell commands start with "$"
 4 years ago
quantumcthulhu 0b52840ab5
node_client.asciidoc typo 
Sentence said "Let's change to our home directory", so we must do "cd ~", not just "cd".
 4 years ago
quantumcthulhu f8e84831e5
node_client.asciidoc typo 4 years ago
quantumcthulhu 1d5df45ddd
node_client typo 4 years ago
quantumcthulhu 0bc24cc4a6
node_client mistype 4 years ago
Manuel 122b42613f
Typo in such as way 4 years ago
8go 763ea48fc7
Last part of node_client: English touch ups (#348) 
- 10 cents, hence 10 satoshis (different is : a 10 cent coin, a 20 dollar suit), but in an amount: use plural: one dollar and 32 cents. Here 10,000 satoshiS (s)
- "a bunch of", very colloquial, --> "several"
- Oxford comma in list of 3 or more
- "funny" --> "unusual"
- "could" --> "can", more encouraging
- "cheap long" and "expensive short" --> add comma, comma should be placed between two adjectives of equal rank
- "it's own" (incorrect) --> its (possessive)
- "explore and dig deeper" (one does not explore deeper) --> explore further and dig deeper
 4 years ago
TS 6dbb07f482 update the commands for the channel establishment and payment within the text 4 years ago
TS dab18f48fd adds parenthesis in the `docker-compose exec` , such that the command behind pipe is exectued within the container 4 years ago
Andreas M. Antonopoulos 89559bfb8f
Merge pull request #346 from 8go/patch-80 
Eclair: English touch ups, commas
 4 years ago
Andreas M. Antonopoulos a3bacdc724
Merge pull request #345 from 8go/patch-79 
Eclair: English touch ups
 4 years ago
Andreas M. Antonopoulos 915ebc195a
Merge pull request #343 from 8go/patch-78 
LND: more English fixes, 1 error
 4 years ago
Andreas M. Antonopoulos bc54811d12
Merge pull request #341 from 8go/patch-77 
LND: typos, touch ups, English, etc.
 4 years ago
8go 8c853ee92c
Complete Network, part 1: English touch ups 
- Oxford comma for consistency (see PR #340)
- sentence restructuring (one does not compose by routing a payment)
- no comma in list of 2
- only the top of the config is listed, we should say so. --> The top looks like ...
- in most cases, no comma before "because" or "since", exceptions apply
- it's (wrong) --> its (possessive)
 4 years ago
8go a77e4161c4
Eclair: English touch ups, commas 
- commas
- reorg of sentences
- "Check to..." sentence is copy-paste from above, changed it slightly to avoid repetition
- OK, Eclair is uppercase, but here we refer to a directory which is lowercase, so "eclair" (just because it is the lowercase name of the dir)
- etc
 4 years ago
8go 90836468d0
Eclair: English touch ups 
- commas
- "by this point" --> "at this point" or "by this time". Maybe best "by now"
- "... you have seen previously to build the Eclair container" is ambiguous. Rephrased
- "directly" .... word order
- it's: incorrect,  --> its
- "unlike the LND or c-lightning containers": did not read well, reordered sub-phrases
- eclair vs Eclair: ok, the logo is lower cased. But when you read their https://github.com/ACINQ/eclair page ALL occurrences of Eclair are UPPERCASED.
- Based on their own use of "Eclair" in English text I have upper-cased all "Eclair" occurrences 
- up to line 779 it was already upper-case, then suddenly it was lower-case
- rephrasing
- etc
 4 years ago
8go ac2ec76dd4
LND: more English fixes, 1 error 
- again commas
- sentence simplifications
- typo
- "at minimum" : that's wrong, "at a minimum", "at least" but I rephrased anyway to avoid it altogether because it does not read well in any case due to the following "or later"
- "distributed" repetitive, changed to "available"
- "It doesn't matter where the GOPATH points" ... this is misleading or could be misunderstood. I rephrased.
- ERROR: "git clone" should be "go get"
 4 years ago
8go 06b8a2f38e
more touch ups, English, commas (#340) 
- replaced ", as is often the case," with "common"
- "prerequisite" has no hyphen
- in most cases no comma in front of "which"
- replaced "that we can do" with "available"
- if there is a list of 3 choices, one can place (optional) a comma before the "and". This is called the Oxford comma. It is optional, but it should be used consistently, always in the book or never. Since above it was used, I set it below as well.
- replaced "aggressively" with "heavily", we are not aggressive :)
- etc.
 4 years ago
8go fd9635d345
minor touch up, English corrections (#338) 
- usually there is no comma in front of because, as, etc. (exceptions exist)
- other commas
- "Let's" sounds very colloquial. It shows up a lot. In a couple of locations I replaced it with "let us" to make it a bit more formal, but I did not want to replace all. Maybe colloquialisms create some closeness to the reader.
- "also" seemed out of place
- local area network  has no hyphen
- "not important, but has ...": either no comma   or   a subject (it) has to be added after "but"
- "like this" was also a bit repetitive, I replaced it once with "as follows"
 4 years ago
8go cee0dfe142
LND: typos, touch ups, English, etc. 
- no comma in front of "and" in a list of 2
- same for "or" in list of 2
- list of 3: yes, we want a comma there to be consistent (Oxford comma, see PR #340 
- many many --> many
 4 years ago
Andreas M. Antonopoulos 27bb45b5c3
Merge branch 'develop' into typos-and-small-fix 4 years ago
Andreas M. Antonopoulos d74ab8293c
Merge pull request #319 from vnprc/develop 
code, spelling and grammar fixes for node_client chapter
 4 years ago
Andreas M. Antonopoulos 23a1acf634
Merge pull request #303 from 8go/patch-74 
simplifications
 4 years ago
Andreas M. Antonopoulos dc77a9ea00
Merge pull request #302 from 8go/patch-73 
rephrase the pipe explanation
 4 years ago
Andreas M. Antonopoulos 32684a1462
Merge pull request #301 from 8go/patch-72 
commas, formats, it's vs its
 4 years ago
Andreas M. Antonopoulos 83f3c0b380
Merge pull request #300 from 8go/patch-71 
commas, formatting
 4 years ago
Andreas M. Antonopoulos 48307f2065
Merge pull request #299 from 8go/patch-70 
tiny English improvements 5, commas
 4 years ago
Andreas M. Antonopoulos ca8497fce9
Merge pull request #297 from 8go/patch-69 
English improvements 4
 4 years ago
Andreas M. Antonopoulos b464a16338
Merge pull request #296 from 8go/patch-68 
tiny English improvements 3
 4 years ago
Andreas M. Antonopoulos ef299263c3
Merge pull request #295 from 8go/patch-67 
updated TIP box
 4 years ago