From bc0dc337ef11dbe36520d9c6fa391d0cb03a35ce Mon Sep 17 00:00:00 2001 From: Suresh Sundriyal <247110+sureshsundriyal@users.noreply.github.com> Date: Fri, 18 Sep 2020 11:11:20 -0700 Subject: [PATCH 1/3] [cross-compiling] Disable document generation during cross-compilation Document generation requires exec'ing lnav which might not be possible while cross-compiling. --- configure.ac | 1 + src/Makefile.am | 2 ++ 2 files changed, 3 insertions(+) diff --git a/configure.ac b/configure.ac index d6875822..5253e970 100644 --- a/configure.ac +++ b/configure.ac @@ -277,6 +277,7 @@ AS_IF([test $? -eq 0], AM_CONDITIONAL(USE_INCLUDED_YAJL, test $HAVE_LOCAL_YAJL -eq 0) AM_CONDITIONAL(HAVE_LIBCURL, test x"$LIBCURL" != x"") +AM_CONDITIONAL([DISABLE_DOCUMENTATION], [ test x"$cross_compiling" != x"no" ]) AC_CONFIG_HEADERS([src/config.h]) AC_CONFIG_FILES([Makefile]) diff --git a/src/Makefile.am b/src/Makefile.am index 01b85ea7..12af779d 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -483,8 +483,10 @@ uncrusty: (cd $(srcdir) && uncrustify -c ../lnav.cfg --replace $(SOURCES) \ $(HEADERS)) +if !DISABLE_DOCUMENTATION all-local: lnav env DUMP_INTERNALS_DIR=$(srcdir)/internals ./lnav Makefile +endif install-exec-hook: bash $(srcdir)/alpha-release.sh From f35f8554585e4ea8ec2625751282fd3831eac3a1 Mon Sep 17 00:00:00 2001 From: Suresh Sundriyal <247110+sureshsundriyal@users.noreply.github.com> Date: Sat, 19 Sep 2020 14:39:03 -0700 Subject: [PATCH 2/3] [tests] Remove use of deprecated std::random_shuffle --- test/drive_line_buffer.cc | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/test/drive_line_buffer.cc b/test/drive_line_buffer.cc index 3e837ecf..d365b4c7 100644 --- a/test/drive_line_buffer.cc +++ b/test/drive_line_buffer.cc @@ -40,6 +40,7 @@ #include #include +#include #include #include #include @@ -212,7 +213,9 @@ int main(int argc, char *argv[]) do { size_t lpc; - random_shuffle(index.begin(), index.end()); + std::random_device rd; + std::mt19937 g(rd()); + std::shuffle(index.begin(), index.end(), g); for (lpc = 0; lpc < index.size(); lpc++) { const auto &index_tuple = index[lpc]; From a6920cc320d7fd47074d735895465149a894f533 Mon Sep 17 00:00:00 2001 From: Suresh Sundriyal <247110+sureshsundriyal@users.noreply.github.com> Date: Sat, 19 Sep 2020 16:22:30 -0700 Subject: [PATCH 3/3] [AUTHORS] Update the file. --- AUTHORS | 1 + 1 file changed, 1 insertion(+) diff --git a/AUTHORS b/AUTHORS index 529a9acc..a2baff0f 100644 --- a/AUTHORS +++ b/AUTHORS @@ -39,3 +39,4 @@ Nicolas Werner Matt Hayden Simos Xenitellis Finnegan Stack +Amos Bird