[vagrant]: fix shellcheck identified issues in scripts

release/vagrant-static/build-pkg.sh

@@ -6,7 +6,7 @@ fpm --verbose \
     -s zip \
     -t rpm \
     -n "lnav" \
-    -v $VERSION \
+    -v "$VERSION" \
     -p /vagrant/ \
     -a native \
     --url https://lnav.org \
@@ -20,7 +20,7 @@ fpm --verbose \
     -s zip \
     -t deb \
     -n "lnav" \
-    -v $VERSION \
+    -v "$VERSION" \
     -p /vagrant/ \
     -a native \
     --url https://lnav.org \

release/vagrant-static/build.sh

@@ -1,4 +1,4 @@
-#! /usr/bin/env bash
+#!/usr/bin/env bash
 
 OS=$(uname -s)
 if test x"${OS}" != x"FreeBSD"; then
@@ -26,7 +26,7 @@ cd ~/github/lnav
 git pull
 
 if test -n "$SRC_VERSION"; then
-    git checkout $SRC_VERSION
+    git checkout "$SRC_VERSION"
 fi
 
 saved_PATH=${PATH}

release/vagrant-static/musl-pkg.sh

@@ -1,4 +1,4 @@
-#! /bin/sh
+#!/bin/sh
 
 sudo apk update && sudo apk upgrade
 sudo apk add \

release/vagrant-static/pkg.sh

@@ -1,4 +1,4 @@
-#! /bin/sh
+#!/bin/sh
 
 OS=$(uname -s)
 if test x"${OS}" != x"FreeBSD"; then

release/vagrant-static/provision.sh

@@ -1,4 +1,4 @@
-#! /usr/bin/env bash
+#!/usr/bin/env bash
 
 OS=$(uname -s)
 if test x"${OS}" != x"FreeBSD"; then
@@ -50,7 +50,7 @@ xterm-256color\
 cd ~/extract
 
 for pkg in /vagrant/pkgs/*.tar.gz; do
-    tar xfz $pkg
+    tar xfz "$pkg"
 done
 
 (cd make-4.2.1 && ./configure --prefix=${FAKE_ROOT} && make && make install)