You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
langchain/libs/community/langchain_community
Peter Vandenabeele e830a4e731
community[patch]: Add remove_comments option (default True): do not extract html comments (#13259)
- **Description:** add `remove_comments` option (default: True): do not
extract html _comments_,
  - **Issue:** None,
  - **Dependencies:** None,
  - **Tag maintainer:** @nfcampos ,
  - **Twitter handle:** peter_v

I ran `make format`, `make lint` and `make test`.

Discussion: I my use case, I prefer to not have the comments in the
extracted text:
* e.g. from a Google tag that is added in the html as comment
* e.g. content that the authors have temporarily hidden to make it non
visible to the regular reader

Removing the comments makes the extracted text more alike the intended
text to be seen by the reader.


**Choice to make:** do we prefer to make the default for this
`remove_comments` option to be True or False?
I have changed it to True in a second commit, since that is how I would
prefer to use it by default. Have the
cleaned text (without technical Google tags etc.) and also closer to the
actually visible and intended content.
I am not sure what is best aligned with the conventions of langchain in
general ...


INITIAL VERSION (new version above):
~**Choice to make:** do we prefer to make the default for this
`ignore_comments` option to be True or False?
I have set it to False now to be backwards compatible. On the other
hand, I would use it mostly with True.
I am not sure what is best aligned with the conventions of langchain in
general ...~

---------

Co-authored-by: Bagatur <baskaryan@gmail.com>
6 months ago
..
adapters
agent_toolkits community[patch]: avoid executing `toolkit.get_context()` when not necessary (#19762) 6 months ago
callbacks community[patch] : [Fiddler] ensure dataset is not added if model is present (#19293) 6 months ago
chat_loaders community[patch]: speed up import times in the community package (#18928) 7 months ago
chat_message_histories community[patch]: history size support for DynamoDBChatMessageHistory (#16794) 6 months ago
chat_models community[minor]: Update ChatZhipuAI to support GLM-4 model (#16695) 6 months ago
cross_encoders langchain[minor], community[minor]: add CrossEncoderReranker with HuggingFaceCrossEncoder and SagemakerEndpointCrossEncoder (#13687) 6 months ago
docstore community[patch]: speed up import times in the community package (#18928) 7 months ago
document_compressors community[minor]: Add OpenVINO rerank model support (#19791) 6 months ago
document_loaders community[minor]: add support for llmsherpa (#19741) 6 months ago
document_transformers community[patch]: Add remove_comments option (default True): do not extract html comments (#13259) 6 months ago
embeddings community[minor]: Add OpenVINO rerank model support (#19791) 6 months ago
example_selectors
graphs community[minor]: Add the option to omit schema refresh in Neo4jGraph (#19654) 6 months ago
indexes
llms community[minor]: add Layerup Security integration (#19787) 6 months ago
output_parsers
retrievers community[minor]: Add Dria retriever (#17098) 6 months ago
storage community[patch]: flattening imports 3 (#18939) 7 months ago
tools community[minor]: add hugging face text-to-speech inference API (#18880) 6 months ago
utilities community[minor]: Add Dria retriever (#17098) 6 months ago
utils community[patch], mongodb[patch]: Stop spamming SIMD import warnings (#19531) 6 months ago
vectorstores community[patch]: Revert " Fix the bug that Chroma does not specify `e… (#19866) 6 months ago
__init__.py
cache.py core[patch]: fix beta, deprecated typing (#18877) 6 months ago
py.typed