You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Roshan Santhosh 7afecec280 core: update _rm_titles to account for title argument name bug (#19036) ... Issue : For functions which have an argument with the name 'title', the convert_pydantic_to_openai_function generates an incorrect output and omits the argument all together. This is because the _rm_titles function removes all instances of the the key 'title' from the output. Description : Updates the _rm_titles function to check the presence of the 'type' key as well before removing the 'title' key. As the title key that we wish to omit always has a type key along with it. Potential gap if there is a function defined which has both title and key as argument names, in which case this would fail. Maybe we could set a filter on the function argument names and reject those with keyword argument names. No dependencies. Passed all tests. - [x] **PR title**: "package: description" - Where "package" is whichever of langchain, community, core, experimental, etc. is being modified. Use "docs: ..." for purely docs changes, "templates: ..." for template changes, "infra: ..." for CI changes. - Example: "community: add foobar LLM" - [x] **PR message**: ***Delete this entire checklist*** and replace with - **Description:** a description of the change - **Issue:** the issue # it fixes, if applicable - **Dependencies:** any dependencies required for this change - **Twitter handle:** if your PR gets announced, and you'd like a mention, we'll gladly shout you out! - [x] **Add tests and docs**: If you're adding a new integration, please include 1. a test for the integration, preferably unit tests that do not rely on network access, 2. an example notebook showing its use. It lives in `docs/docs/integrations` directory. - [x] **Lint and test**: Run `make format`, `make lint` and `make test` from the root of the package(s) you've modified. See contribution guidelines for more: https://python.langchain.com/docs/contributing/ Additional guidelines: - Make sure optional dependencies are imported within a function. - Please do not add dependencies to pyproject.toml files (even optional ones) unless they are required for unit tests. - Most PRs should not touch more than one package. - Changes should be backwards compatible. - If you are adding something to community, do not re-import it in langchain. If no one reviews your PR within a few days, please @-mention one of baskaryan, efriis, eyurtsev, hwchase17. --------- Co-authored-by: Eugene Yurtsev <eyurtsev@gmail.com>		6 months ago
..
_api	docs: Fix bug that caused the word "Beta" to appear twice in doc-strings (#17704)	7 months ago
callbacks	core[patch], langchain[patch], community[patch]: Revert #15326 (#15546)	9 months ago
chat_history	Add async methods to BaseChatMessageHistory and BaseMemory (#16728)	8 months ago
data	Separate out langchain_core package (#13577)	10 months ago
document_loaders	community: If load() has been overridden, use it in default lazy_load() (#18690)	7 months ago
documents	core[minor]: move document compressor base (#17910)	7 months ago
embeddings	core[minor]: moved fake llms and embeddings to core (#19226)	6 months ago
example_selectors	BUG: more core fixes (#13665)	10 months ago
examples	core:adds tests for partial_variables (#15427)	9 months ago
fake	core[minor]: moved fake llms and embeddings to core (#19226)	6 months ago
language_models	core[minor]: moved fake llms and embeddings to core (#19226)	6 months ago
load	BUG: more core fixes (#13665)	10 months ago
messages	Accept message-like things in Chat models, LLMs and MessagesPlaceholder (#16418)	8 months ago
output_parsers	core: Fix Exception handling in XMLOutputParser (#19126)	6 months ago
outputs	BUG: more core fixes (#13665)	10 months ago
prompts	core[minor]: moved fake llms and embeddings to core (#19226)	6 months ago
runnables	[Enhancement] Add support for directly providing a run_id (#18990)	6 months ago
tracers	core[minor]: moved fake llms and embeddings to core (#19226)	6 months ago
utils	core: update _rm_titles to account for title argument name bug (#19036)	6 months ago
__init__.py	Separate out langchain_core package (#13577)	10 months ago
conftest.py	core[patch], langchain[patch]: fix required deps (#14373)	10 months ago
prompt_file.txt	Separate out langchain_core package (#13577)	10 months ago
test_globals.py	Separate out langchain_core package (#13577)	10 months ago
test_imports.py	infra: Fix test filesystem paths incompatible with windows (#14388)	9 months ago
test_messages.py	core[minor]: add name to basemessage (#17539)	7 months ago
test_outputs.py	REFACTOR: Refactor langchain_core (#13627)	10 months ago
test_sys_info.py	core(minor): Add a way to print out system information for debugging purposes. (#15718)	9 months ago
test_tools.py	core: upgrade mypy to recent mypy (#18753)	7 months ago