mirror of
https://github.com/hwchase17/langchain
synced 2024-11-10 01:10:59 +00:00
7afecec280
Issue : For functions which have an argument with the name 'title', the
convert_pydantic_to_openai_function generates an incorrect output and
omits the argument all together. This is because the _rm_titles function
removes all instances of the the key 'title' from the output.
Description : Updates the _rm_titles function to check the presence of
the 'type' key as well before removing the 'title' key. As the title key
that we wish to omit always has a type key along with it.
Potential gap if there is a function defined which has both title and
key as argument names, in which case this would fail. Maybe we could set
a filter on the function argument names and reject those with keyword
argument names.
No dependencies. Passed all tests.
- [x] **PR title**: "package: description"
- Where "package" is whichever of langchain, community, core,
experimental, etc. is being modified. Use "docs: ..." for purely docs
changes, "templates: ..." for template changes, "infra: ..." for CI
changes.
- Example: "community: add foobar LLM"
- [x] **PR message**: ***Delete this entire checklist*** and replace
with
- **Description:** a description of the change
- **Issue:** the issue # it fixes, if applicable
- **Dependencies:** any dependencies required for this change
- **Twitter handle:** if your PR gets announced, and you'd like a
mention, we'll gladly shout you out!
- [x] **Add tests and docs**: If you're adding a new integration, please
include
1. a test for the integration, preferably unit tests that do not rely on
network access,
2. an example notebook showing its use. It lives in
`docs/docs/integrations` directory.
- [x] **Lint and test**: Run `make format`, `make lint` and `make test`
from the root of the package(s) you've modified. See contribution
guidelines for more: https://python.langchain.com/docs/contributing/
Additional guidelines:
- Make sure optional dependencies are imported within a function.
- Please do not add dependencies to pyproject.toml files (even optional
ones) unless they are required for unit tests.
- Most PRs should not touch more than one package.
- Changes should be backwards compatible.
- If you are adding something to community, do not re-import it in
langchain.
If no one reviews your PR within a few days, please @-mention one of
baskaryan, efriis, eyurtsev, hwchase17.
---------
Co-authored-by: Eugene Yurtsev <eyurtsev@gmail.com>
|
||
|---|---|---|
| .. | ||
| _api | ||
| beta | ||
| callbacks | ||
| document_loaders | ||
| documents | ||
| embeddings | ||
| example_selectors | ||
| globals | ||
| language_models | ||
| load | ||
| messages | ||
| output_parsers | ||
| outputs | ||
| prompts | ||
| pydantic_v1 | ||
| runnables | ||
| tracers | ||
| utils | ||
| __init__.py | ||
| agents.py | ||
| caches.py | ||
| chat_history.py | ||
| chat_sessions.py | ||
| env.py | ||
| exceptions.py | ||
| memory.py | ||
| prompt_values.py | ||
| py.typed | ||
| retrievers.py | ||
| stores.py | ||
| sys_info.py | ||
| tools.py | ||
| vectorstores.py | ||