mirror of
https://github.com/hwchase17/langchain
synced 2024-11-18 09:25:54 +00:00
0a1b1806e9
Seeing a lot of issues in Discord in which the LLM is not using the correct LIMIT clause for different SQL dialects. ie, it's using `LIMIT` for mssql instead of `TOP`, or instead of `ROWNUM` for Oracle, etc. I think this could be due to us specifying the LIMIT statement in the example rows portion of `table_info`. So the LLM is seeing the `LIMIT` statement used in the prompt. Since we can't specify each dialect's method here, I think it's fine to just replace the `SELECT... LIMIT 3;` statement with `3 rows from table_name table:`, and wrap everything in a block comment directly following the `CREATE` statement. The Rajkumar et al paper wrapped the example rows and `SELECT` statement in a block comment as well anyway. Thoughts @fpingham?
126 lines
3.4 KiB
Python
126 lines
3.4 KiB
Python
# flake8: noqa=E501
|
|
"""Test SQL database wrapper."""
|
|
|
|
from sqlalchemy import Column, Integer, MetaData, String, Table, create_engine, insert
|
|
|
|
from langchain.sql_database import SQLDatabase
|
|
|
|
metadata_obj = MetaData()
|
|
|
|
user = Table(
|
|
"user",
|
|
metadata_obj,
|
|
Column("user_id", Integer, primary_key=True),
|
|
Column("user_name", String(16), nullable=False),
|
|
)
|
|
|
|
company = Table(
|
|
"company",
|
|
metadata_obj,
|
|
Column("company_id", Integer, primary_key=True),
|
|
Column("company_location", String, nullable=False),
|
|
)
|
|
|
|
|
|
def test_table_info() -> None:
|
|
"""Test that table info is constructed properly."""
|
|
engine = create_engine("sqlite:///:memory:")
|
|
metadata_obj.create_all(engine)
|
|
db = SQLDatabase(engine)
|
|
output = db.table_info
|
|
expected_output = """
|
|
CREATE TABLE user (
|
|
user_id INTEGER NOT NULL,
|
|
user_name VARCHAR(16) NOT NULL,
|
|
PRIMARY KEY (user_id)
|
|
)
|
|
/*
|
|
3 rows from user table:
|
|
user_id user_name
|
|
/*
|
|
|
|
|
|
CREATE TABLE company (
|
|
company_id INTEGER NOT NULL,
|
|
company_location VARCHAR NOT NULL,
|
|
PRIMARY KEY (company_id)
|
|
)
|
|
/*
|
|
3 rows from company table:
|
|
company_id company_location
|
|
*/
|
|
"""
|
|
|
|
assert sorted(" ".join(output.split())) == sorted(" ".join(expected_output.split()))
|
|
|
|
|
|
def test_table_info_w_sample_rows() -> None:
|
|
"""Test that table info is constructed properly."""
|
|
engine = create_engine("sqlite:///:memory:")
|
|
metadata_obj.create_all(engine)
|
|
values = [
|
|
{"user_id": 13, "user_name": "Harrison"},
|
|
{"user_id": 14, "user_name": "Chase"},
|
|
]
|
|
stmt = insert(user).values(values)
|
|
with engine.begin() as conn:
|
|
conn.execute(stmt)
|
|
|
|
db = SQLDatabase(engine, sample_rows_in_table_info=2)
|
|
|
|
output = db.table_info
|
|
|
|
expected_output = """
|
|
CREATE TABLE company (
|
|
company_id INTEGER NOT NULL,
|
|
company_location VARCHAR NOT NULL,
|
|
PRIMARY KEY (company_id)
|
|
)
|
|
/*
|
|
2 rows from company table:
|
|
company_id company_location
|
|
*/
|
|
|
|
CREATE TABLE user (
|
|
user_id INTEGER NOT NULL,
|
|
user_name VARCHAR(16) NOT NULL,
|
|
PRIMARY KEY (user_id)
|
|
)
|
|
/*
|
|
2 rows from user table:
|
|
user_id user_name
|
|
13 Harrison
|
|
14 Chase
|
|
*/
|
|
"""
|
|
|
|
assert sorted(output.split()) == sorted(expected_output.split())
|
|
|
|
|
|
def test_sql_database_run() -> None:
|
|
"""Test that commands can be run successfully and returned in correct format."""
|
|
engine = create_engine("sqlite:///:memory:")
|
|
metadata_obj.create_all(engine)
|
|
stmt = insert(user).values(user_id=13, user_name="Harrison")
|
|
with engine.begin() as conn:
|
|
conn.execute(stmt)
|
|
db = SQLDatabase(engine)
|
|
command = "select user_name from user where user_id = 13"
|
|
output = db.run(command)
|
|
expected_output = "[('Harrison',)]"
|
|
assert output == expected_output
|
|
|
|
|
|
def test_sql_database_run_update() -> None:
|
|
"""Test commands which return no rows return an empty string."""
|
|
engine = create_engine("sqlite:///:memory:")
|
|
metadata_obj.create_all(engine)
|
|
stmt = insert(user).values(user_id=13, user_name="Harrison")
|
|
with engine.begin() as conn:
|
|
conn.execute(stmt)
|
|
db = SQLDatabase(engine)
|
|
command = "update user set user_name='Updated' where user_id = 13"
|
|
output = db.run(command)
|
|
expected_output = ""
|
|
assert output == expected_output
|