mirror of
https://github.com/hwchase17/langchain
synced 2024-11-11 19:11:02 +00:00
3d54784e6d
Thank you for contributing to LangChain!
**Description:** Noticed an issue with when I was calling
`RecursiveJsonSplitter().split_json()` multiple times that I was getting
weird results. I found an issue where `chunks` list in the `_json_split`
method. If chunks is not provided when _json_split (which is the case
when split_json calls _json_split) then the same list is used for
subsequent calls to `_json_split`.
You can see this in the test case i also added to this commit.
Output should be:
```
[{'a': 1, 'b': 2}]
[{'c': 3, 'd': 4}]
```
Instead you get:
```
[{'a': 1, 'b': 2}]
[{'a': 1, 'b': 2, 'c': 3, 'd': 4}]
```
---------
Co-authored-by: Nuno Campos <nuno@langchain.dev>
Co-authored-by: isaac hershenson <ihershenson@hmc.edu>
Co-authored-by: Isaac Francisco <78627776+isahers1@users.noreply.github.com>
|
||
|---|---|---|
| .. | ||
| xsl | ||
| __init__.py | ||
| base.py | ||
| character.py | ||
| html.py | ||
| json.py | ||
| konlpy.py | ||
| latex.py | ||
| markdown.py | ||
| nltk.py | ||
| py.typed | ||
| python.py | ||
| sentence_transformers.py | ||
| spacy.py | ||