mirror of
https://github.com/hwchase17/langchain
synced 2024-10-29 17:07:25 +00:00
1366d070fc
# Add path validation to DirectoryLoader This PR introduces a minor adjustment to the DirectoryLoader by adding validation for the path argument. Previously, if the provided path didn't exist or wasn't a directory, DirectoryLoader would return an empty document list due to the behavior of the `glob` method. This could potentially cause confusion for users, as they might expect a file-loading error instead. So, I've added two validations to the load method of the DirectoryLoader: - Raise a FileNotFoundError if the provided path does not exist - Raise a ValueError if the provided path is not a directory Due to the relatively small scope of these changes, a new issue was not created. ## Before submitting <!-- If you're adding a new integration, please include: 1. a test for the integration - favor unit tests that does not rely on network access. 2. an example notebook showing its use See contribution guidelines for more information on how to write tests, lint etc: https://github.com/hwchase17/langchain/blob/master/.github/CONTRIBUTING.md --> ## Who can review? Community members can review the PR once tests pass. Tag maintainers/contributors who might be interested: @eyurtsev |
||
|---|---|---|
| .. | ||
| blob_loaders | ||
| loaders | ||
| parsers | ||
| sample_documents | ||
| test_docs | ||
| __init__.py | ||
| test_base.py | ||
| test_bibtex.py | ||
| test_bshtml.py | ||
| test_confluence.py | ||
| test_csv_loader.py | ||
| test_detect_encoding.py | ||
| test_directory.py | ||
| test_evernote_loader.py | ||
| test_generic_loader.py | ||
| test_json_loader.py | ||
| test_psychic.py | ||
| test_readthedoc.py | ||
| test_telegram.py | ||
| test_web_base.py | ||
| test_youtube.py | ||