8 Commits (ccd916babe8b24ff8a2ef5d9c2a8a53487388f2a)

Author	SHA1	Message	Date
Brigit Murtaugh	ccd916babe	Update dev container (#6189) ... Fixes https://github.com/hwchase17/langchain/issues/6172 As described in https://github.com/hwchase17/langchain/issues/6172, I'd love to help update the dev container in this project. **Summary of changes:** - Dev container now builds (the current container in this repo won't build for me) - Dockerfile updates - Update image to our [currently-maintained Python image](https://github.com/devcontainers/images/tree/main/src/python/.devcontainer) (`mcr.microsoft.com/devcontainers/python`) rather than the deprecated image from vscode-dev-containers - Move Dockerfile to root of repo - in order for `COPY` to work properly, it needs the files (in this case, `pyproject.toml` and `poetry.toml`) in the same directory - devcontainer.json updates - Removed `customizations` and `remoteUser` since they should be covered by the updated image in the Dockerfile - Update comments - Update docker-compose.yaml to properly point to updated Dockerfile - Add a .gitattributes to avoid line ending conversions, which can result in hundreds of pending changes ([info](https://code.visualstudio.com/docs/devcontainers/tips-and-tricks#_resolving-git-line-ending-issues-in-containers-resulting-in-many-modified-files)) - Add a README in the .devcontainer folder and info on the dev container in the contributing.md **Outstanding questions:** - Is it expected for `poetry install` to take some time? It takes about 30 minutes for this dev container to finish building in a Codespace, but a user should only have to experience this once. Through some online investigation, this doesn't seem unusual - Versions of poetry newer than 1.3.2 failed every time - based on some of the guidance in contributing.md and other online resources, it seemed changing poetry versions might be a good solution. 1.3.2 is from Jan 2023 --------- Co-authored-by: bamurtaugh <brmurtau@microsoft.com> Co-authored-by: Samruddhi Khandale <samruddhikhandale@github.com>	12 months ago
Eugene Yurtsev	a669abf16b	Update CONTRIBUTION guidelines and PR Template (#5140) ... # Update contribution guidelines and PR template This PR updates the contribution guidelines to include more information on how to handle optional dependencies. The PR template is updated to include a link to the contribution guidelines document.	1 year ago
Davis Chase	cd01de49cf	Update contribution guidelines (#4431) ... provide more guidance on pr's	1 year ago
Noah Gundotra	577ec92f16	Include testing instructions for getting setup in CONTRIBUTING.md (#3020) ... Running tests is good sanity check for new users to ensure their development environment is setup correctly.	1 year ago
sergerdn	90973c10b1	fix: tests with Dockerfile (#2382) ... Update the Dockerfile to use the `$POETRY_HOME` argument to set the Poetry home directory instead of adding Poetry to the PATH environment variable. Add instructions to the `CONTRIBUTING.md` file on how to run tests with Docker. Closes https://github.com/hwchase17/langchain/issues/2324	1 year ago
andrewmelis	7ed8d00bba	Remove extra word in CONTRIBUTING.md (#2370) ... "via by a developer" -> "by a developer" --- Thank you for all your hard work!	1 year ago
Matt Tucker	fa2e546b76	Add workaround for debugpy install issue to contrib docs. (#1835) ... When following the Quick Start instructions in the contributing docs, I was getting a "WheelFileValidationError" on installation of debugpy which was blocking the installation of a number of other deps. Google turned up this [GitHub issue](https://github.com/microsoft/debugpy/issues/1246) indicating a regression in Poetry 1.4.1 and workarounds. This PR updates the contrib docs noting the issue and the workarounds.	1 year ago
Harrison Chase	b053f831cd	Harrison/contributing (#1542) ... Co-authored-by: Saurav Maheshkar <sauravvmaheshkar@gmail.com>	1 year ago