8 Commits (master)

Author	SHA1	Message	Date
David Charles	8da35fba7f	langchain[minor]: add libs/partners to dev.Dockerfile (#21902) ... Resolves #21886 by adding "COPY libs/partners ../partners/" to libs/dev.Dockerfile Twitter: @kabakongo	1 week ago
Ivaylo Bratoev	7c5063ef60	infra: fix how Poetry is installed in the dev container (#20521) ... Currently, when a new dev container is created, poetry does not work in it with the error "No module named 'rapidfuzz'". Install Poetry outside the project venv so that poetry and project dependencies do not get mixed. Use pipx to install poetry securely in its own isolated environment. Issue: #12237 Twitter handle: https://twitter.com/ibratoev Co-authored-by: Bagatur <22008038+baskaryan@users.noreply.github.com>	1 month ago
Shotaro Sano	55c624a694	infra: Resolve the endless dependency resolution during the build of `dev.Dockerfile` by copying `poetry.lock` (#19465) ... ## Description This PR proposes a modification to the `libs/langchain/dev.Dockerfile` configuration to copy the `libs/langchain/poetry.lock` into the working directory. The change aims to address the issue where the Poetry install command, the last command in the `dev.Dockerfile`, takes excessively long hours, and to ensure the reproducibility of the poetry environment in the devcontainer. ## Problem The `dev.Dockerfile`, prepared for development environments such as `.devcontainer`, encounters an unending dependency resolution when attempting the Poetry installation. ### Steps to Reproduce Execute the following build command: ```bash docker build -f libs/langchain/dev.Dockerfile . ``` ### Current Behavior The Docker build process gets stuck at the following step, which, in my experience, did not conclude even after an entire night: ``` => [langchain-dev-dependencies 4/6] COPY libs/community/ ../community/ 0.9s => [langchain-dev-dependencies 5/6] COPY libs/text-splitters/ ../text-splitters/ 0.0s => [langchain-dev-dependencies 6/6] RUN poetry install --no-interaction --no-ansi --with dev,test,docs 12.3s => => # Updating dependencies => => # Resolving dependencies... ``` ### Expected Behavior The Docker build completes in a realistic timeframe. By applying this PR, the build finishes within a few minutes. ### Analysis The complexity of LangChain's dependencies has reached a point where Poetry is required to resolve dependencies akin to threading a needle. Consequently, poetry install fails to complete in a practical timeframe. ## Solution The solution for dependency resolution is already recorded in `libs/langchain/poetry.lock`, so we can use it. When copying `project.toml` and `poetry.toml`, the `poetry.lock` located in the same directory should also be copied. ```diff # Copy only the dependency files for installation -COPY libs/langchain/pyproject.toml libs/langchain/poetry.toml ./ +COPY libs/langchain/pyproject.toml libs/langchain/poetry.toml libs/langchain/poetry.lock ./ ``` ## Note I am not intimately familiar with the historical context of the `dev.Dockerfile` and thus do not know why `poetry.lock` has not been copied until now. It might have been an oversight, or perhaps dependency resolution used to complete quickly even without the `poetry.lock` file in the past. However, if there are deliberate reasons why copying `poetry.lock` is not advisable, please just close this PR.	2 months ago
Shotaro Sano	ca9c8c58ea	text-splitters, infra: fix `libs/langchain/dev.Dockerfile` so that the `text-splitter` directory is copied before poetry installation (#19214) ... ## Description This PR modifies the settings in `libs/langchain/dev.Dockerfile` to ensure that the `text-splitters` directory is copied before the poetry installation process begins. Without this modification, the `docker build` command fails for `dev.Dockerfile`, preventing the setup of some development environments, including `.devcontainer`. ## Bug Details ### Repro Run the following command: ```bash docker build -f libs/langchain/dev.Dockerfile . ``` ### Current Behavior The docker build command fails, raising the following error: ``` ... => [langchain-dev-dependencies 4/5] COPY libs/community/ ../community/ 0.4s => ERROR [langchain-dev-dependencies 5/5] RUN poetry install --no-interaction --no-ansi --with dev,test,docs 1.1s ------ > [langchain-dev-dependencies 5/5] RUN poetry install --no-interaction --no-ansi --with dev,test,docs: #13 0.970 #13 0.970 Directory ../text-splitters does not exist ------ executor failed running [/bin/sh -c poetry install --no-interaction --no-ansi --with dev,test,docs]: exit code: 1 ``` ### Expected Behavior The `docker build` command successfully completes without the poetry error. ### Analysis The error occurs because the `text-splitters` directory is not copied into the build environment, unlike the other packages under the `libs` directory. I suspect that the `COPY` setting was overlooked since `text-splitters` was separated in a recent PR. ## Fix Add the following lines to the `libs/langchain/dev.Dockerfile`: ```dockerfile # Copy the text-splitters library for installation COPY libs/text-splitters/ ../text-splitters/ ```	2 months ago
Christopher Queen	d5e1725ace	langchain: Fix for issue #14631 - .devcontainer doesnt build (#15251) ... - **Description:** Fix for issue #14631 - **Issue:** This fixes [Issue #14631](https://github.com/langchain-ai/langchain/issues/14631) - **Twitter handle:** [@consultchrisq ](https://twitter.com/consultchrisq?lang=en)	5 months ago
Byron Saltysiak	61347bd322	giving path to the copy command for *.toml files (#8294) ... Description: in the .devcontainer, docker-compose build is currently failing due to the src paths in the COPY command. This change adds the full path to the pyproject.toml and poetry.toml to allow the build to run. Issue: You can see the issue if you try to build the dev docker image with: ``` cd .devcontainer docker-compose build ``` Dependencies: none Twitter handle: byronsalty	10 months ago
Nolan	7686dabd36	Unbreak devcontainer (#8154) ... Codespaces and devcontainer was broken by the [repo restructure](https://github.com/langchain-ai/langchain/discussions/8043). - Description: Add libs/langchain to container so it can be built without error. - Issue: - - Dependencies: - - Tag maintainer: @hwchase17 @baskaryan - Twitter handle: @finnless The failed build log says: ``` #10 [langchain-dev-dependencies 2/2] RUN poetry install --no-interaction --no-ansi --with dev,test,docs #10 sha256:e850ee99fc966158bfd2d85e82b7c57244f47ecbb1462e75bd83b981a56a1929 2023-07-23 23:30:33.692Z: #10 0.827 #10 0.827 Directory libs/langchain does not exist 2023-07-23 23:30:33.738Z: #10 ERROR: executor failed running [/bin/sh -c poetry install --no-interaction --no-ansi --with dev,test,docs]: exit code: 1 ``` The new pyproject.toml imports from libs/langchain: 77bf75c236/pyproject.toml (L14-L16) But libs/langchain is never added to the dev.Dockerfile: 77bf75c236/libs/langchain/dev.Dockerfile (L37-L39)	10 months ago
Harrison Chase	f35db9f43e	(WIP) set up experimental (#7959)	10 months ago