Archives/langchain
2
0
Fork 1
mirror of https://github.com/hwchase17/langchain synced 2024-11-06 03:20:49 +00:00
Code Issues Packages Projects Releases Wiki Activity

Add missing token_max in reduce.py acombine_docs (#7241)

Browse Source 
Replace this comment with:
- Description: reduce.py reduce chain implementation's acombine_docs
call does not propagate token_max. Without this, the async call will end
up using 3000 tokens, the default, for the collapse chain.
  - Tag maintainer: @hwchase17 @agola11 @baskaryan 
  - Twitter handle: https://twitter.com/ShantanuNair

Related PR: https://github.com/hwchase17/langchain/pull/7201 and
https://github.com/hwchase17/langchain/pull/7204

---------

Co-authored-by: Harrison Chase <hw.chase.17@gmail.com>
This commit is contained in:
Shantanu Nair 2023-07-06 06:32:45 +05:30 committed by GitHub
parent 52b016920c
commit cabd358c3a
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
langchain/chains/combine_documents/reduce.py
View File

@ -193,7 +193,7 @@ class ReduceDocumentsChain(BaseCombineDocumentsChain):
element returned is a dictionary of other keys to return. element returned is a dictionary of other keys to return.
""" """
result_docs, extra_return_dict = self._collapse( result_docs, extra_return_dict = self._collapse(
docs, token_max, callbacks=callbacks, **kwargs docs, token_max=token_max, callbacks=callbacks, **kwargs
) )
return self.combine_documents_chain.combine_docs( return self.combine_documents_chain.combine_docs(
docs=result_docs, callbacks=callbacks, **kwargs docs=result_docs, callbacks=callbacks, **kwargs
@ -222,7 +222,7 @@ class ReduceDocumentsChain(BaseCombineDocumentsChain):
element returned is a dictionary of other keys to return. element returned is a dictionary of other keys to return.
""" """
result_docs, extra_return_dict = await self._acollapse( result_docs, extra_return_dict = await self._acollapse(
docs, callbacks=callbacks, **kwargs docs, token_max=token_max, callbacks=callbacks, **kwargs
) )
return await self.combine_documents_chain.acombine_docs( return await self.combine_documents_chain.acombine_docs(
docs=result_docs, callbacks=callbacks, **kwargs docs=result_docs, callbacks=callbacks, **kwargs