From a5fd8873b137153e17bf006c816f66fe6976189b Mon Sep 17 00:00:00 2001 From: James Yin Date: Mon, 10 Jul 2023 14:14:00 +0800 Subject: [PATCH] fix: type hint of get_chat_history in BaseConversationalRetrievalChain (#7461) The type hint of `get_chat_history` property in `BaseConversationalRetrievalChain` is incorrect. @baskaryan --- langchain/chains/conversational_retrieval/base.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/langchain/chains/conversational_retrieval/base.py b/langchain/chains/conversational_retrieval/base.py index c601d422d5..705c809195 100644 --- a/langchain/chains/conversational_retrieval/base.py +++ b/langchain/chains/conversational_retrieval/base.py @@ -72,7 +72,7 @@ class BaseConversationalRetrievalChain(Chain): """Return the retrieved source documents as part of the final result.""" return_generated_question: bool = False """Return the generated question as part of the final result.""" - get_chat_history: Optional[Callable[[CHAT_TURN_TYPE], str]] = None + get_chat_history: Optional[Callable[[List[CHAT_TURN_TYPE]], str]] = None """An optional function to get a string of the chat history. If None is provided, will use a default."""