mirror of https://github.com/hwchase17/langchain
Make BaseStringMessagePromptTemplate.from_template return type generic (#4523)
# Make BaseStringMessagePromptTemplate.from_template return type generic I use mypy to check type on my code that uses langchain. Currently after I load a prompt and convert it to a system prompt I have to explicitly cast it which is quite ugly (and not necessary): ``` prompt_template = load_prompt("prompt.yaml") system_prompt_template = cast( SystemMessagePromptTemplate, SystemMessagePromptTemplate.from_template(prompt_template.template), ) ``` With this PR, the code would simply be: ``` prompt_template = load_prompt("prompt.yaml") system_prompt_template = SystemMessagePromptTemplate.from_template(prompt_template.template) ``` Given how much langchain uses inheritance, I think this type hinting could be applied in a bunch more places, e.g. load_prompt also return a `FewShotPromptTemplate` or a `PromptTemplate` but without typing the type checkers aren't able to infer that. Let me know if you agree and I can take a look at implementing that as well. @hwchase17 - project lead DataLoaders - @eyurtsevpull/4499/head^2
parent
446b60d803
commit
97e7dc1502
Loading…
Reference in New Issue