From 8df6b68093ea533d67bf5eb1bd0783fe8621109d Mon Sep 17 00:00:00 2001 From: Harrison Chase Date: Thu, 2 Feb 2023 22:06:56 -0800 Subject: [PATCH] fix length based example selector (#862) --- langchain/prompts/example_selector/length_based.py | 2 +- tests/unit_tests/prompts/test_length_based_example_selector.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/langchain/prompts/example_selector/length_based.py b/langchain/prompts/example_selector/length_based.py index 086b72ce55..a6f6cd8d23 100644 --- a/langchain/prompts/example_selector/length_based.py +++ b/langchain/prompts/example_selector/length_based.py @@ -51,7 +51,7 @@ class LengthBasedExampleSelector(BaseExampleSelector, BaseModel): examples = [] while remaining_length > 0 and i < len(self.examples): new_length = remaining_length - self.example_text_lengths[i] - if i < 0: + if new_length < 0: break else: examples.append(self.examples[i]) diff --git a/tests/unit_tests/prompts/test_length_based_example_selector.py b/tests/unit_tests/prompts/test_length_based_example_selector.py index 45895871b8..38fd689c4e 100644 --- a/tests/unit_tests/prompts/test_length_based_example_selector.py +++ b/tests/unit_tests/prompts/test_length_based_example_selector.py @@ -17,7 +17,7 @@ def selector() -> LengthBasedExampleSelector: selector = LengthBasedExampleSelector( examples=EXAMPLES, example_prompt=prompts, - max_length=25, + max_length=30, ) return selector