Archives/langchain
2
0
Fork 1
mirror of https://github.com/hwchase17/langchain synced 2024-11-06 03:20:49 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix issue#1712: Update BaseQAWithSourcesChain to handle space & newline after SOURCES: (#2118)

Browse Source 
Fix the issue outlined in #1712 to ensure the `BaseQAWithSourcesChain`
can properly separate the sources from an agent response even when they
are delineated by a newline.

This will ensure the `BaseQAWithSourcesChain` can reliably handle both
of these agent outputs:

* `"This Agreement is governed by English law.\nSOURCES: 28-pl"` ->
`"This Agreement is governed by English law.\n`, `"28-pl"`
* `"This Agreement is governed by English law.\nSOURCES:\n28-pl"` ->
`"This Agreement is governed by English law.\n`, `"28-pl"`

I couldn't find any unit tests for this but please let me know if you'd
like me to add any test coverage.
This commit is contained in:
Walter Beller-Morales 2023-03-28 18:28:20 -04:00 committed by GitHub
parent c33e055f17
commit 859502b16c
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
langchain/chains/qa_with_sources/base.py
View File

@ -2,6 +2,7 @@
from __future__ import annotations from __future__ import annotations
import re
from abc import ABC, abstractmethod from abc import ABC, abstractmethod
from typing import Any, Dict, List, Optional from typing import Any, Dict, List, Optional
@ -116,8 +117,8 @@ class BaseQAWithSourcesChain(Chain, BaseModel, ABC):
def _call(self, inputs: Dict[str, Any]) -> Dict[str, Any]: def _call(self, inputs: Dict[str, Any]) -> Dict[str, Any]:
docs = self._get_docs(inputs) docs = self._get_docs(inputs)
answer, _ = self.combine_documents_chain.combine_docs(docs, **inputs) answer, _ = self.combine_documents_chain.combine_docs(docs, **inputs)
if "SOURCES: " in answer: if re.search(r"SOURCES:\s", answer):
answer, sources = answer.split("SOURCES: ") answer, sources = re.split(r"SOURCES:\s", answer)
else: else:
sources = "" sources = ""
result: Dict[str, Any] = { result: Dict[str, Any] = {