From 770f57196edea164f8638de960577306e70104d9 Mon Sep 17 00:00:00 2001
From: Nuno Campos <nuno@langchain.dev>
Date: Tue, 16 Jan 2024 09:22:52 -0800
Subject: [PATCH] Add unit test for overridden lc_namespace (#16093)

---
 .../tests/unit_tests/load/__snapshots__/test_dump.ambr     | 7 +++----
 libs/langchain/tests/unit_tests/load/test_dump.py          | 7 ++++++-
 2 files changed, 9 insertions(+), 5 deletions(-)

diff --git a/libs/langchain/tests/unit_tests/load/__snapshots__/test_dump.ambr b/libs/langchain/tests/unit_tests/load/__snapshots__/test_dump.ambr
index 2cf2fdf8cd..0540760d4c 100644
--- a/libs/langchain/tests/unit_tests/load/__snapshots__/test_dump.ambr
+++ b/libs/langchain/tests/unit_tests/load/__snapshots__/test_dump.ambr
@@ -30,10 +30,9 @@
     "lc": 1,
     "type": "constructor",
     "id": [
-      "tests",
-      "unit_tests",
-      "load",
-      "test_dump",
+      "my",
+      "special",
+      "namespace",
       "SpecialPerson"
     ],
     "kwargs": {
diff --git a/libs/langchain/tests/unit_tests/load/test_dump.py b/libs/langchain/tests/unit_tests/load/test_dump.py
index d428b04c71..0d0a354172 100644
--- a/libs/langchain/tests/unit_tests/load/test_dump.py
+++ b/libs/langchain/tests/unit_tests/load/test_dump.py
@@ -1,6 +1,6 @@
 """Test for Serializable base class"""
 
-from typing import Any, Dict
+from typing import Any, Dict, List
 
 import pytest
 from langchain_community.chat_models.openai import ChatOpenAI
@@ -37,6 +37,10 @@ class SpecialPerson(Person):
 
     another_visible: str = "bye"
 
+    @classmethod
+    def get_lc_namespace(cls) -> List[str]:
+        return ["my", "special", "namespace"]
+
     # Gets merged with parent class's secrets
     @property
     def lc_secrets(self) -> Dict[str, str]:
@@ -58,6 +62,7 @@ def test_person(snapshot: Any) -> None:
     sp = SpecialPerson(another_secret="Wooo", secret="Hmm")
     assert dumps(sp, pretty=True) == snapshot
     assert Person.lc_id() == ["tests", "unit_tests", "load", "test_dump", "Person"]
+    assert SpecialPerson.lc_id() == ["my", "special", "namespace", "SpecialPerson"]
 
 
 def test_typeerror() -> None: