Archives/langchain
2
0
Fork 1
mirror of https://github.com/hwchase17/langchain synced 2024-11-04 06:00:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix runnable branch callbacks (#11091)

Browse Source 
We aren't calling on_chain_end here unless we use the default option
This commit is contained in:
William FH 2023-09-27 03:38:56 -07:00 committed by GitHub
parent 5514ebe859
commit 75b3893daf
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 19 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

36
libs/langchain/langchain/schema/runnable/base.py
View File

@ -867,20 +867,21 @@ class RunnableBranch(Serializable, Runnable[Input, Output]):
) )
if expression_value: if expression_value:
return runnable.invoke( output = runnable.invoke(
input, input,
config=patch_config( config=patch_config(
config, config,
callbacks=run_manager.get_child(tag=f"branch:{idx + 1}"), callbacks=run_manager.get_child(tag=f"branch:{idx + 1}"),
), ),
) )
break
output = self.default.invoke( else:
input, output = self.default.invoke(
config=patch_config( input,
config, callbacks=run_manager.get_child(tag="branch:default") config=patch_config(
), config, callbacks=run_manager.get_child(tag="branch:default")
) ),
)
except Exception as e: except Exception as e:
run_manager.on_chain_error(e) run_manager.on_chain_error(e)
raise raise
@ -911,7 +912,7 @@ class RunnableBranch(Serializable, Runnable[Input, Output]):
) )
if expression_value: if expression_value:
return await runnable.ainvoke( output = await runnable.ainvoke(
input, input,
config=patch_config( config=patch_config(
config, config,
@ -919,14 +920,15 @@ class RunnableBranch(Serializable, Runnable[Input, Output]):
), ),
**kwargs, **kwargs,
) )
break
output = await self.default.ainvoke( else:
input, output = await self.default.ainvoke(
config=patch_config( input,
config, callbacks=run_manager.get_child(tag="branch:default") config=patch_config(
), config, callbacks=run_manager.get_child(tag="branch:default")
**kwargs, ),
) **kwargs,
)
except Exception as e: except Exception as e:
run_manager.on_chain_error(e) run_manager.on_chain_error(e)
raise raise