community[patch]: Fix the bug that Chroma does not specify `embedding_function` (#19277)

- **Issue:** close #18291
- @baskaryan, @eyurtsev PTAL
pull/18393/head
Guangdong Liu 3 months ago committed by GitHub
parent 85f57ab4cd
commit 7042934b5f
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194

@ -28,6 +28,7 @@ if TYPE_CHECKING:
import chromadb.config
from chromadb.api.types import ID, OneOrMany, Where, WhereDocument
logger = logging.getLogger()
DEFAULT_K = 4 # Number of Documents to return.
@ -80,6 +81,7 @@ class Chroma(VectorStore):
try:
import chromadb
import chromadb.config
from chromadb.utils import embedding_functions
except ImportError:
raise ImportError(
"Could not import chromadb python package. "
@ -122,10 +124,12 @@ class Chroma(VectorStore):
_client_settings.persist_directory or persist_directory
)
self._embedding_function = embedding_function
self._embedding_function = (
embedding_function or embedding_functions.DefaultEmbeddingFunction()
)
self._collection = self._client.get_or_create_collection(
name=collection_name,
embedding_function=None,
embedding_function=self._embedding_function,
metadata=collection_metadata,
)
self.override_relevance_score_fn = relevance_score_fn

Loading…
Cancel
Save