From 6cff2837bba858ae7270e57e08f1474fe4c4344b Mon Sep 17 00:00:00 2001 From: Harrison Chase Date: Mon, 7 Nov 2022 15:22:37 -0800 Subject: [PATCH] Harrison/fix lint (#80) --- .github/workflows/lint.yml | 2 +- langchain/chains/self_ask_with_search/base.py | 1 - langchain/chains/serpapi.py | 4 ++-- requirements.txt | 6 ------ test_requirements.txt | 6 ++++++ 5 files changed, 9 insertions(+), 10 deletions(-) diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml index 8cb56282dc..8d56deda34 100644 --- a/.github/workflows/lint.yml +++ b/.github/workflows/lint.yml @@ -17,7 +17,7 @@ jobs: - name: Install dependencies run: | python -m pip install --upgrade pip - pip install -r requirements.txt + pip install -r test_requirements.txt - name: Analysing the code with our lint run: | make lint diff --git a/langchain/chains/self_ask_with_search/base.py b/langchain/chains/self_ask_with_search/base.py index 804860ea35..26df99ee89 100644 --- a/langchain/chains/self_ask_with_search/base.py +++ b/langchain/chains/self_ask_with_search/base.py @@ -92,7 +92,6 @@ class SelfAskWithSearchChain(Chain, BaseModel): input_key: str = "question" #: :meta private: output_key: str = "answer" #: :meta private: - class Config: """Configuration for this pydantic object.""" diff --git a/langchain/chains/serpapi.py b/langchain/chains/serpapi.py index b8257df104..b8ea59198e 100644 --- a/langchain/chains/serpapi.py +++ b/langchain/chains/serpapi.py @@ -74,8 +74,8 @@ class SerpAPIChain(Chain, BaseModel): if serpapi_api_key is None or serpapi_api_key == "": raise ValueError( "Did not find SerpAPI API key, please add an environment variable" - " `SERPAPI_API_KEY` which contains it, or pass `serpapi_api_key` as a named" - " parameter to the constructor." + " `SERPAPI_API_KEY` which contains it, or pass `serpapi_api_key` " + "as a named parameter to the constructor." ) try: from serpapi import GoogleSearch diff --git a/requirements.txt b/requirements.txt index c60ee0cd91..cbb622111b 100644 --- a/requirements.txt +++ b/requirements.txt @@ -1,10 +1,4 @@ -r test_requirements.txt -# For linting -black -isort -mypy -flake8 -flake8-docstrings # For integrations cohere openai diff --git a/test_requirements.txt b/test_requirements.txt index 19f5045348..55e36b044d 100644 --- a/test_requirements.txt +++ b/test_requirements.txt @@ -2,3 +2,9 @@ # For testing pytest pytest-dotenv +# For linting +black +isort +mypy +flake8 +flake8-docstrings