mirror of
https://github.com/hwchase17/langchain
synced 2024-11-04 06:00:26 +00:00
Avoid type: ignore
suppression by adding mypy type hint. (#9881)
Mypy was not able to determine a good type for `type_to_loader_dict`, since the values in the dict are functions whose return types are related to each other in a complex way. One can see this by adding a line like `reveal_type(type_to_loader_dict)` and running mypy, which will get mypy to show what type it has inferred for that value. Adding an explicit type hint to help out mypy avoids the need for a mypy suppression and allows the code to type-check cleanly.
This commit is contained in:
parent
f327535eda
commit
47499c6db4
@ -2,7 +2,7 @@
|
||||
import json
|
||||
import logging
|
||||
from pathlib import Path
|
||||
from typing import Union
|
||||
from typing import Callable, Dict, Union
|
||||
|
||||
import yaml
|
||||
|
||||
@ -26,10 +26,7 @@ def load_prompt_from_config(config: dict) -> BasePromptTemplate:
|
||||
raise ValueError(f"Loading {config_type} prompt not supported")
|
||||
|
||||
prompt_loader = type_to_loader_dict[config_type]
|
||||
# Unclear why type error is being thrown here.
|
||||
# Incompatible return value type (got "Runnable[Dict[Any, Any], PromptValue]",
|
||||
# expected "BasePromptTemplate") [return-value]
|
||||
return prompt_loader(config) # type: ignore[return-value]
|
||||
return prompt_loader(config)
|
||||
|
||||
|
||||
def _load_template(var_name: str, config: dict) -> dict:
|
||||
@ -148,8 +145,7 @@ def _load_prompt_from_file(file: Union[str, Path]) -> BasePromptTemplate:
|
||||
return load_prompt_from_config(config)
|
||||
|
||||
|
||||
type_to_loader_dict = {
|
||||
type_to_loader_dict: Dict[str, Callable[[dict], BasePromptTemplate]] = {
|
||||
"prompt": _load_prompt,
|
||||
"few_shot": _load_few_shot_prompt,
|
||||
# "few_shot_with_templates": _load_few_shot_with_templates_prompt,
|
||||
}
|
||||
|
Loading…
Reference in New Issue
Block a user