From 39c1c942727fb77dd7550370fbc2eff8a4b93303 Mon Sep 17 00:00:00 2001 From: Philippe PRADOS Date: Mon, 18 Sep 2023 17:17:10 +0200 Subject: [PATCH] Fix typing in WebResearchRetriver (#10734) Hello @hwchase17 **Issue**: The class WebResearchRetriever accept only RecursiveCharacterTextSplitter, but never uses a specification of this class. I propose to change the type to TextSplitter. Then, the lint can accept all subtypes. --- libs/langchain/langchain/retrievers/web_research.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libs/langchain/langchain/retrievers/web_research.py b/libs/langchain/langchain/retrievers/web_research.py index e8e96a2abc..cf53243c66 100644 --- a/libs/langchain/langchain/retrievers/web_research.py +++ b/libs/langchain/langchain/retrievers/web_research.py @@ -16,7 +16,7 @@ from langchain.output_parsers.pydantic import PydanticOutputParser from langchain.prompts import BasePromptTemplate, PromptTemplate from langchain.pydantic_v1 import BaseModel, Field from langchain.schema import BaseRetriever, Document -from langchain.text_splitter import RecursiveCharacterTextSplitter +from langchain.text_splitter import RecursiveCharacterTextSplitter, TextSplitter from langchain.utilities import GoogleSearchAPIWrapper from langchain.vectorstores.base import VectorStore @@ -75,7 +75,7 @@ class WebResearchRetriever(BaseRetriever): llm_chain: LLMChain search: GoogleSearchAPIWrapper = Field(..., description="Google Search API Wrapper") num_search_results: int = Field(1, description="Number of pages per Google search") - text_splitter: RecursiveCharacterTextSplitter = Field( + text_splitter: TextSplitter = Field( RecursiveCharacterTextSplitter(chunk_size=1500, chunk_overlap=50), description="Text splitter for splitting web pages into chunks", )