From 3280a5b49b0cd997129d341d1ecc97515593f224 Mon Sep 17 00:00:00 2001 From: leila-messallem <59602030+leila-messallem@users.noreply.github.com> Date: Wed, 5 Jun 2024 17:56:53 +0200 Subject: [PATCH] community[patch]: improve test setup to accurately test filtering of labels in neo4j (#22531) **Description:** This PR addresses an issue with an existing test that was not effectively testing the intended functionality. The previous test setup did not adequately validate the filtering of the labels in neo4j, because the nodes and relationship in the test data did not have any properties set. Without properties these labels would not have been returned, regardless of the filtering. --------- Co-authored-by: Oskar Hane --- .../tests/integration_tests/graphs/test_neo4j.py | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/libs/community/tests/integration_tests/graphs/test_neo4j.py b/libs/community/tests/integration_tests/graphs/test_neo4j.py index 2765938905..a519b43070 100644 --- a/libs/community/tests/integration_tests/graphs/test_neo4j.py +++ b/libs/community/tests/integration_tests/graphs/test_neo4j.py @@ -266,12 +266,17 @@ def test_neo4j_filtering_labels() -> None: # Remove all constraints graph.query("CALL apoc.schema.assert({}, {})") graph.query( - "CREATE (:`_Bloom_Scene_`)-[:_Bloom_HAS_SCENE_]->(:`_Bloom_Perspective_`)" + """ + CREATE (:_Bloom_Scene_ {property_a: 'a'}) + -[:_Bloom_HAS_SCENE_ {property_b: 'b'}] + ->(:_Bloom_Perspective_) + """ ) graph.refresh_schema() - # Assert both are empty + # Assert all are empty assert graph.structured_schema["node_props"] == {} + assert graph.structured_schema["rel_props"] == {} assert graph.structured_schema["relationships"] == []