From 2ab0e1d526a8ec443caaa44e34c2a41398800d90 Mon Sep 17 00:00:00 2001 From: Leonid Ganeline Date: Fri, 19 May 2023 15:28:08 -0700 Subject: [PATCH] changed ValueError to ImportError (#5006) # changed ValueError to ImportError in except Several places with this bug. ValueError does not catch ImportError. --- langchain/docstore/wikipedia.py | 2 +- langchain/utilities/arxiv.py | 2 +- langchain/utilities/wikipedia.py | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/langchain/docstore/wikipedia.py b/langchain/docstore/wikipedia.py index 8882fb23b6..60fbed9a1c 100644 --- a/langchain/docstore/wikipedia.py +++ b/langchain/docstore/wikipedia.py @@ -15,7 +15,7 @@ class Wikipedia(Docstore): try: import wikipedia # noqa: F401 except ImportError: - raise ValueError( + raise ImportError( "Could not import wikipedia python package. " "Please install it with `pip install wikipedia`." ) diff --git a/langchain/utilities/arxiv.py b/langchain/utilities/arxiv.py index 82ba07814e..e9e96bc894 100644 --- a/langchain/utilities/arxiv.py +++ b/langchain/utilities/arxiv.py @@ -58,7 +58,7 @@ class ArxivAPIWrapper(BaseModel): ) values["arxiv_result"] = arxiv.Result except ImportError: - raise ValueError( + raise ImportError( "Could not import arxiv python package. " "Please install it with `pip install arxiv`." ) diff --git a/langchain/utilities/wikipedia.py b/langchain/utilities/wikipedia.py index 60f6ce6fce..6a33ccf8bf 100644 --- a/langchain/utilities/wikipedia.py +++ b/langchain/utilities/wikipedia.py @@ -41,7 +41,7 @@ class WikipediaAPIWrapper(BaseModel): wikipedia.set_lang(values["lang"]) values["wiki_client"] = wikipedia except ImportError: - raise ValueError( + raise ImportError( "Could not import wikipedia python package. " "Please install it with `pip install wikipedia`." )