mirror of
https://github.com/koreader/koreader
synced 2024-11-10 01:10:34 +00:00
fadee1f5dc
Basically: * Use `extend` for class definitions * Use `new` for object instantiations That includes some minor code cleanups along the way: * Updated `Widget`'s docs to make the semantics clearer. * Removed `should_restrict_JIT` (it's been dead code since https://github.com/koreader/android-luajit-launcher/pull/283) * Minor refactoring of LuaSettings/LuaData/LuaDefaults/DocSettings to behave (mostly, they are instantiated via `open` instead of `new`) like everything else and handle inheritance properly (i.e., DocSettings is now a proper LuaSettings subclass). * Default to `WidgetContainer` instead of `InputContainer` for stuff that doesn't actually setup key/gesture events. * Ditto for explicit `*Listener` only classes, make sure they're based on `EventListener` instead of something uselessly fancier. * Unless absolutely necessary, do not store references in class objects, ever; only values. Instead, always store references in instances, to avoid both sneaky inheritance issues, and sneaky GC pinning of stale references. * ReaderUI: Fix one such issue with its `active_widgets` array, with critical implications, as it essentially pinned *all* of ReaderUI's modules, including their reference to the `Document` instance (i.e., that was a big-ass leak). * Terminal: Make sure the shell is killed on plugin teardown. * InputText: Fix Home/End/Del physical keys to behave sensibly. * InputContainer/WidgetContainer: If necessary, compute self.dimen at paintTo time (previously, only InputContainers did, which might have had something to do with random widgets unconcerned about input using it as a baseclass instead of WidgetContainer...). * OverlapGroup: Compute self.dimen at *init* time, because for some reason it needs to do that, but do it directly in OverlapGroup instead of going through a weird WidgetContainer method that it was the sole user of. * ReaderCropping: Under no circumstances should a Document instance member (here, self.bbox) risk being `nil`ed! * Kobo: Minor code cleanups.
56 lines
2.3 KiB
Lua
56 lines
2.3 KiB
Lua
describe("WakeupMgr", function()
|
|
local RTC
|
|
local WakeupMgr
|
|
local epoch1, epoch2, epoch3
|
|
|
|
setup(function()
|
|
require("commonrequire")
|
|
package.unloadAll()
|
|
RTC = require("ffi/rtc")
|
|
WakeupMgr = require("device/wakeupmgr"):new{}
|
|
-- We could theoretically test this by running the tests as root locally.
|
|
stub(WakeupMgr, "setWakeupAlarm")
|
|
WakeupMgr.validateWakeupAlarmByProximity = spy.new(function() return true end)
|
|
|
|
epoch1 = RTC:secondsFromNowToEpoch(1234)
|
|
epoch2 = RTC:secondsFromNowToEpoch(123)
|
|
epoch3 = RTC:secondsFromNowToEpoch(9999)
|
|
end)
|
|
|
|
it("should add a task", function()
|
|
WakeupMgr:addTask(1234, function() end)
|
|
assert.is_equal(epoch1, WakeupMgr._task_queue[1].epoch)
|
|
assert.stub(WakeupMgr.setWakeupAlarm).was.called(1)
|
|
end)
|
|
it("should add a task in order", function()
|
|
WakeupMgr:addTask(9999, function() end)
|
|
assert.is_equal(epoch1, WakeupMgr._task_queue[1].epoch)
|
|
assert.stub(WakeupMgr.setWakeupAlarm).was.called(1)
|
|
|
|
WakeupMgr:addTask(123, function() end)
|
|
assert.is_equal(epoch2, WakeupMgr._task_queue[1].epoch)
|
|
assert.stub(WakeupMgr.setWakeupAlarm).was.called(2)
|
|
end)
|
|
it("should execute top task", function()
|
|
assert.is_true(WakeupMgr:wakeupAction())
|
|
end)
|
|
it("should have removed executed task from stack", function()
|
|
assert.is_equal(epoch1, WakeupMgr._task_queue[1].epoch)
|
|
assert.is_equal(epoch3, WakeupMgr._task_queue[2].epoch)
|
|
end)
|
|
it("should have scheduled next task after execution", function()
|
|
assert.stub(WakeupMgr.setWakeupAlarm).was.called(3) -- 2 from addTask (the second addTask doesn't replace the upcoming task), 1 from wakeupAction (via removeTask).
|
|
end)
|
|
it("should remove arbitrary task from stack", function()
|
|
WakeupMgr:removeTask(2)
|
|
assert.is_equal(epoch1, WakeupMgr._task_queue[1].epoch)
|
|
assert.is_equal(nil, WakeupMgr._task_queue[2])
|
|
end)
|
|
it("should execute last task", function()
|
|
assert.is_true(WakeupMgr:wakeupAction())
|
|
end)
|
|
it("should not have scheduled a wakeup without a task", function()
|
|
assert.stub(WakeupMgr.setWakeupAlarm).was.called(3) -- 2 from addTask, 1 from wakeupAction, 0 from removeTask (because it wasn't the upcoming task that was removed)
|
|
end)
|
|
end)
|