2
0
mirror of https://github.com/koreader/koreader synced 2024-11-16 06:12:56 +00:00
koreader/frontend/device
NiLuJe 08dd97384c
KOSync: Clarify settings, plus refactor & fixes to make "auto-sync" more reliable (#10605)
Fix: #10539, and for context #6489, #6733, #6534

Reorganize and reword most of the settings to make it clear what actually ties into auto sync, and what doesn't. (Specifically, what happens when a pull attempts to sync forward or backward has nothing to do with auto sync, it applies in all cases; while the periodic sync *does* require auto sync).

The main point of contention, though, is that auto sync will now *always* attempt to setup network connectivity (i.e., on resume/suspend/close). Periodic sync will *not* though (the intent being that, if you use periodic sync, you're relying on the activity check to actually keep wifi on at all times)).

Since this may lead to a large amount of nagging about wifi toggles on devices w/ NetworkManager support, it is now *disabled* by default on those devices. (And given that it wouldn't have worked because of the lack of connectivity, that doesn't really make any practical difference ;p).

Additionally, given the fact that there's no way to make this behavior viable if the "before wifi" action is left at its default of "prompt", this feature now *requires* that to be set to "turn_on" (on devices where it can, of course); attempting to toggle it on will warn about that if necessary.
This change is retroactive (OTM).

Includes an assortment of fixes and cleanups, including migrating to the new LuaSettings API, which is why there's no longer a smattering of superfluous flushes.
2023-07-03 01:23:14 +02:00
..
android PowerD: Unbreak frontlight toggle notifications outside of Kobo (#10597) 2023-06-25 11:25:33 +02:00
cervantes PM: Minor refactor to suspend/resume code flow (#10426) 2023-05-18 23:13:43 +02:00
dummy Clarify our OOP semantics across the codebase (#9586) 2022-10-06 02:14:48 +02:00
generic KOSync: Clarify settings, plus refactor & fixes to make "auto-sync" more reliable (#10605) 2023-07-03 01:23:14 +02:00
kindle kindle: show require error trace (#10569) 2023-06-11 21:46:46 +02:00
kobo PowerD: Unbreak frontlight toggle notifications outside of Kobo (#10597) 2023-06-25 11:25:33 +02:00
pocketbook PocketBook: add alternative definition for PB840 (#10582) 2023-06-15 13:54:15 +02:00
remarkable PM: Minor refactor to suspend/resume code flow (#10426) 2023-05-18 23:13:43 +02:00
sdl SDL: Fix initial position & size 2023-06-29 14:33:23 +02:00
sony-prstux PM: Minor refactor to suspend/resume code flow (#10426) 2023-05-18 23:13:43 +02:00
devicelistener.lua Kobo: Refactor frontlight toggle ramp behavior (#10305) 2023-04-30 23:28:30 +02:00
gesturedetector.lua KOSync: Clarify settings, plus refactor & fixes to make "auto-sync" more reliable (#10605) 2023-07-03 01:23:14 +02:00
input.lua Input: Be more through in resetState (#10612) 2023-07-02 22:54:14 +02:00
key.lua InputContainer: Fall cleanup ;). 2022-10-29 22:55:20 +02:00
sysfs_light.lua Kindle: toggle cover events 2023-05-03 10:26:35 -04:00
thirdparty.lua
wakeupmgr.lua WakeupMgr: Explicitly invalidate the current alarm in unsetWakeupAlarm (#10032) 2023-01-16 19:32:32 +01:00