mirror of
https://github.com/koreader/koreader
synced 2024-11-11 19:11:14 +00:00
668eee97fa
Update shellcheck and shfmt to the latest version. Fixes <https://github.com/koreader/koreader/issues/5152>. Btw, you can apply shellcheck suggestions with a command like: ``` shellcheck --include=SC2250 -f diff *.sh | git apply ```
28 lines
1.2 KiB
Bash
Executable File
28 lines
1.2 KiB
Bash
Executable File
#!/usr/bin/env bash
|
|
|
|
CI_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
|
|
# shellcheck source=/dev/null
|
|
source "${CI_DIR}/common.sh"
|
|
|
|
# shellcheck disable=2016
|
|
mapfile -t shellscript_locations < <({ git grep -lE '^#!(/usr)?/bin/(env )?(bash|sh)' && git submodule --quiet foreach '[ "$path" = "base" -o "$path" = "platform/android/luajit-launcher" ] || git grep -lE "^#!(/usr)?/bin/(env )?(bash|sh)" | sed "s|^|$path/|"' && git ls-files ./*.sh; } | sort | uniq)
|
|
|
|
SHELLSCRIPT_ERROR=0
|
|
|
|
for shellscript in "${shellscript_locations[@]}"; do
|
|
echo -e "${ANSI_GREEN}Running shellcheck on ${shellscript}"
|
|
shellcheck "${shellscript}" || SHELLSCRIPT_ERROR=1
|
|
echo -e "${ANSI_GREEN}Running shfmt on ${shellscript}"
|
|
if ! shfmt -i 4 -ci "${shellscript}" >/dev/null 2>&1; then
|
|
echo -e "${ANSI_RED}Warning: ${shellscript} contains the following problem:"
|
|
shfmt -i 4 -ci "${shellscript}" || SHELLSCRIPT_ERROR=1
|
|
continue
|
|
fi
|
|
if [ "$(cat "${shellscript}")" != "$(shfmt -i 4 -ci "${shellscript}")" ]; then
|
|
echo -e "${ANSI_RED}Warning: ${shellscript} does not abide by coding style, diff for expected style:"
|
|
shfmt -i 4 -ci "${shellscript}" | diff "${shellscript}" - || SHELLSCRIPT_ERROR=1
|
|
fi
|
|
done
|
|
|
|
exit "${SHELLSCRIPT_ERROR}"
|