mirror of
https://github.com/koreader/koreader
synced 2024-11-13 19:11:25 +00:00
fadee1f5dc
Basically: * Use `extend` for class definitions * Use `new` for object instantiations That includes some minor code cleanups along the way: * Updated `Widget`'s docs to make the semantics clearer. * Removed `should_restrict_JIT` (it's been dead code since https://github.com/koreader/android-luajit-launcher/pull/283) * Minor refactoring of LuaSettings/LuaData/LuaDefaults/DocSettings to behave (mostly, they are instantiated via `open` instead of `new`) like everything else and handle inheritance properly (i.e., DocSettings is now a proper LuaSettings subclass). * Default to `WidgetContainer` instead of `InputContainer` for stuff that doesn't actually setup key/gesture events. * Ditto for explicit `*Listener` only classes, make sure they're based on `EventListener` instead of something uselessly fancier. * Unless absolutely necessary, do not store references in class objects, ever; only values. Instead, always store references in instances, to avoid both sneaky inheritance issues, and sneaky GC pinning of stale references. * ReaderUI: Fix one such issue with its `active_widgets` array, with critical implications, as it essentially pinned *all* of ReaderUI's modules, including their reference to the `Document` instance (i.e., that was a big-ass leak). * Terminal: Make sure the shell is killed on plugin teardown. * InputText: Fix Home/End/Del physical keys to behave sensibly. * InputContainer/WidgetContainer: If necessary, compute self.dimen at paintTo time (previously, only InputContainers did, which might have had something to do with random widgets unconcerned about input using it as a baseclass instead of WidgetContainer...). * OverlapGroup: Compute self.dimen at *init* time, because for some reason it needs to do that, but do it directly in OverlapGroup instead of going through a weird WidgetContainer method that it was the sole user of. * ReaderCropping: Under no circumstances should a Document instance member (here, self.bbox) risk being `nil`ed! * Kobo: Minor code cleanups.
44 lines
1.1 KiB
Lua
44 lines
1.1 KiB
Lua
local EventListener = require("ui/widget/eventlistener")
|
|
|
|
local DHINTCOUNT = G_defaults:readSetting("DHINTCOUNT")
|
|
|
|
local ReaderHinting = EventListener:extend{
|
|
hinting_states = nil, -- array
|
|
}
|
|
|
|
function ReaderHinting:init()
|
|
self.hinting_states = {}
|
|
end
|
|
|
|
function ReaderHinting:onHintPage()
|
|
if not self.view.hinting then return true end
|
|
for i=1, DHINTCOUNT do
|
|
if self.view.state.page + i <= self.document.info.number_of_pages then
|
|
self.document:hintPage(
|
|
self.view.state.page + i,
|
|
self.zoom:getZoom(self.view.state.page + i),
|
|
self.view.state.rotation,
|
|
self.view.state.gamma,
|
|
self.view.render_mode)
|
|
end
|
|
end
|
|
return true
|
|
end
|
|
|
|
function ReaderHinting:onSetHinting(hinting)
|
|
self.view.hinting = hinting
|
|
end
|
|
|
|
function ReaderHinting:onDisableHinting()
|
|
table.insert(self.hinting_states, self.view.hinting)
|
|
self.view.hinting = false
|
|
return true
|
|
end
|
|
|
|
function ReaderHinting:onRestoreHinting()
|
|
self.view.hinting = table.remove(self.hinting_states)
|
|
return true
|
|
end
|
|
|
|
return ReaderHinting
|