mirror of
https://github.com/koreader/koreader
synced 2024-10-31 21:20:20 +00:00
bf6c0cdd6c
* LuaSettings/DocSettings: Updated readSetting API to allow proper initialization to default. Use it to initialize tables, e.g., fixing corner-cases in readerFooter that could prevent settings from being saved. (Fixes an issue reported on Gitter). * LuaSettings/DocSettings: Add simpler API than the the flip* ones to toggle boolean settings. * Update LuaSettings/DocSettigns usage throughout the codebase to use the dedicated boolean methods wher appropriate, and clean up some of the more mind-bending uses. * FileChooser: Implement an extended default exclusion list (fix #2360) * ScreenSaver: Refactor to avoid the pile of kludges this was threatening to become. Code should be easier to follow and use, and fallbacks now behave as expected (fix #4418).
146 lines
5.3 KiB
Lua
146 lines
5.3 KiB
Lua
describe("luadata module", function()
|
|
local Settings
|
|
setup(function()
|
|
require("commonrequire")
|
|
Settings = require("frontend/luadata"):open("this-is-not-a-valid-file")
|
|
end)
|
|
|
|
it("should handle undefined keys", function()
|
|
Settings:delSetting("abc")
|
|
|
|
assert.True(Settings:hasNot("abc"))
|
|
assert.True(Settings:nilOrTrue("abc"))
|
|
assert.False(Settings:isTrue("abc"))
|
|
Settings:saveSetting("abc", true)
|
|
assert.True(Settings:has("abc"))
|
|
assert.True(Settings:nilOrTrue("abc"))
|
|
assert.True(Settings:isTrue("abc"))
|
|
end)
|
|
|
|
it("should flip bool values", function()
|
|
Settings:delSetting("abc")
|
|
|
|
assert.True(Settings:hasNot("abc"))
|
|
Settings:flipNilOrTrue("abc")
|
|
assert.False(Settings:nilOrTrue("abc"))
|
|
assert.True(Settings:has("abc"))
|
|
assert.False(Settings:isTrue("abc"))
|
|
Settings:flipNilOrTrue("abc")
|
|
assert.True(Settings:nilOrTrue("abc"))
|
|
assert.True(Settings:hasNot("abc"))
|
|
assert.False(Settings:isTrue("abc"))
|
|
|
|
Settings:flipTrue("abc")
|
|
assert.True(Settings:has("abc"))
|
|
assert.True(Settings:isTrue("abc"))
|
|
assert.True(Settings:nilOrTrue("abc"))
|
|
Settings:flipTrue("abc")
|
|
assert.False(Settings:has("abc"))
|
|
assert.False(Settings:isTrue("abc"))
|
|
assert.True(Settings:nilOrTrue("abc"))
|
|
end)
|
|
|
|
it("should create child settings", function()
|
|
Settings:delSetting("key")
|
|
|
|
Settings:saveSetting("key", {
|
|
a = "b",
|
|
c = "True",
|
|
d = false,
|
|
})
|
|
|
|
local child = Settings:child("key")
|
|
|
|
assert.is_not_nil(child)
|
|
assert.True(child:has("a"))
|
|
assert.are.equal(child:readSetting("a"), "b")
|
|
assert.True(child:has("c"))
|
|
assert.False(child:isTrue("c")) -- It's a string, not a bool!
|
|
assert.True(child:has("d"))
|
|
assert.True(child:isFalse("d"))
|
|
assert.False(child:isTrue("e"))
|
|
child:flipTrue("e")
|
|
child:close()
|
|
|
|
child = Settings:child("key")
|
|
assert.True(child:isTrue("e"))
|
|
end)
|
|
|
|
describe("table wrapper", function()
|
|
Settings:delSetting("key")
|
|
|
|
it("should add item to table", function()
|
|
Settings:addTableItem("key", 1)
|
|
Settings:addTableItem("key", 2)
|
|
Settings:addTableItem("key", 3)
|
|
|
|
assert.are.equal(1, Settings:readSetting("key")[1])
|
|
assert.are.equal(2, Settings:readSetting("key")[2])
|
|
assert.are.equal(3, Settings:readSetting("key")[3])
|
|
end)
|
|
|
|
it("should remove item from table", function()
|
|
Settings:removeTableItem("key", 1)
|
|
|
|
assert.are.equal(2, Settings:readSetting("key")[1])
|
|
assert.are.equal(3, Settings:readSetting("key")[2])
|
|
end)
|
|
end)
|
|
|
|
describe("backup data file", function()
|
|
local file = "dummy-test-file"
|
|
local d = Settings:open(file)
|
|
it("should generate data file", function()
|
|
d:saveSetting("a", "a")
|
|
assert.Equals("file", lfs.attributes(d.file, "mode"))
|
|
end)
|
|
it("should generate backup data file on flush", function()
|
|
d:flush()
|
|
-- file and file.old.1 should be generated.
|
|
assert.Equals("file", lfs.attributes(d.file, "mode"))
|
|
assert.Equals("file", lfs.attributes(d.file .. ".old.1", "mode"))
|
|
d:close()
|
|
end)
|
|
it("should remove garbage data file", function()
|
|
-- write some garbage to sidecar-file.
|
|
local f_out = io.open(d.file, "w")
|
|
f_out:write("bla bla bla")
|
|
f_out:close()
|
|
|
|
d = Settings:open(file)
|
|
-- file should be removed.
|
|
assert.are.not_equal("file", lfs.attributes(d.file, "mode"))
|
|
assert.Equals("file", lfs.attributes(d.file .. ".old.2", "mode"))
|
|
assert.Equals("a", d:readSetting("a"))
|
|
d:saveSetting("a", "b")
|
|
d:close()
|
|
-- backup should be generated.
|
|
assert.Equals("file", lfs.attributes(d.file, "mode"))
|
|
assert.Equals("file", lfs.attributes(d.file .. ".old.1", "mode"))
|
|
-- The contents in file and file.old.1 are different.
|
|
-- a:b v.s. a:a
|
|
end)
|
|
it("should open backup data file after garbage removal", function()
|
|
d = Settings:open(file)
|
|
-- We should get the right result.
|
|
assert.Equals("b", d:readSetting("a"))
|
|
-- write some garbage to file.
|
|
local f_out = io.open(d.file, "w")
|
|
f_out:write("bla bla bla")
|
|
f_out:close()
|
|
|
|
-- do not flush the result, open docsettings again.
|
|
d = Settings:open(file)
|
|
-- data file should be removed.
|
|
assert.are.not_equal("file", lfs.attributes(d.file, "mode"))
|
|
assert.Equals("file", lfs.attributes(d.file .. ".old.2", "mode"))
|
|
-- The content should come from file.old.2.
|
|
assert.Equals("a", d:readSetting("a"))
|
|
d:close()
|
|
-- data file should be generated and last good backup should not change name.
|
|
assert.Equals("file", lfs.attributes(d.file, "mode"))
|
|
assert.Equals("file", lfs.attributes(d.file .. ".old.2", "mode"))
|
|
end)
|
|
end)
|
|
end)
|