mirror of
https://github.com/koreader/koreader
synced 2024-11-16 06:12:56 +00:00
fadee1f5dc
Basically: * Use `extend` for class definitions * Use `new` for object instantiations That includes some minor code cleanups along the way: * Updated `Widget`'s docs to make the semantics clearer. * Removed `should_restrict_JIT` (it's been dead code since https://github.com/koreader/android-luajit-launcher/pull/283) * Minor refactoring of LuaSettings/LuaData/LuaDefaults/DocSettings to behave (mostly, they are instantiated via `open` instead of `new`) like everything else and handle inheritance properly (i.e., DocSettings is now a proper LuaSettings subclass). * Default to `WidgetContainer` instead of `InputContainer` for stuff that doesn't actually setup key/gesture events. * Ditto for explicit `*Listener` only classes, make sure they're based on `EventListener` instead of something uselessly fancier. * Unless absolutely necessary, do not store references in class objects, ever; only values. Instead, always store references in instances, to avoid both sneaky inheritance issues, and sneaky GC pinning of stale references. * ReaderUI: Fix one such issue with its `active_widgets` array, with critical implications, as it essentially pinned *all* of ReaderUI's modules, including their reference to the `Document` instance (i.e., that was a big-ass leak). * Terminal: Make sure the shell is killed on plugin teardown. * InputText: Fix Home/End/Del physical keys to behave sensibly. * InputContainer/WidgetContainer: If necessary, compute self.dimen at paintTo time (previously, only InputContainers did, which might have had something to do with random widgets unconcerned about input using it as a baseclass instead of WidgetContainer...). * OverlapGroup: Compute self.dimen at *init* time, because for some reason it needs to do that, but do it directly in OverlapGroup instead of going through a weird WidgetContainer method that it was the sole user of. * ReaderCropping: Under no circumstances should a Document instance member (here, self.bbox) risk being `nil`ed! * Kobo: Minor code cleanups.
54 lines
1.4 KiB
Lua
54 lines
1.4 KiB
Lua
--[[--
|
|
This is a debug plugin to test Plugin functionality.
|
|
|
|
@module koplugin.HelloWorld
|
|
--]]--
|
|
|
|
-- This is a debug plugin, remove the following if block to enable it
|
|
if true then
|
|
return { disabled = true, }
|
|
end
|
|
|
|
local Dispatcher = require("dispatcher") -- luacheck:ignore
|
|
local InfoMessage = require("ui/widget/infomessage")
|
|
local UIManager = require("ui/uimanager")
|
|
local WidgetContainer = require("ui/widget/container/widgetcontainer")
|
|
local _ = require("gettext")
|
|
|
|
local Hello = WidgetContainer:extend{
|
|
name = "hello",
|
|
is_doc_only = false,
|
|
}
|
|
|
|
function Hello:onDispatcherRegisterActions()
|
|
Dispatcher:registerAction("helloworld_action", {category="none", event="HelloWorld", title=_("Hello World"), general=true,})
|
|
end
|
|
|
|
function Hello:init()
|
|
self:onDispatcherRegisterActions()
|
|
self.ui.menu:registerToMainMenu(self)
|
|
end
|
|
|
|
function Hello:addToMainMenu(menu_items)
|
|
menu_items.hello_world = {
|
|
text = _("Hello World"),
|
|
-- in which menu this should be appended
|
|
sorting_hint = "more_tools",
|
|
-- a callback when tapping
|
|
callback = function()
|
|
UIManager:show(InfoMessage:new{
|
|
text = _("Hello, plugin world"),
|
|
})
|
|
end,
|
|
}
|
|
end
|
|
|
|
function Hello:onHelloWorld()
|
|
local popup = InfoMessage:new{
|
|
text = _("Hello World"),
|
|
}
|
|
UIManager:show(popup)
|
|
end
|
|
|
|
return Hello
|