2
0
mirror of https://github.com/koreader/koreader synced 2024-11-10 01:10:34 +00:00
Commit Graph

775 Commits

Author SHA1 Message Date
Robert
2c3936ddb4 Refactoring readerfooter statistics - TB and TC (#3223) 2017-09-16 13:36:54 +02:00
poire-z
f5a6e32887 Fix wrong page when tap on link (#3217)
Closes #3216
2017-09-14 13:01:09 +02:00
Frans de Jonge
161cae6b3a [UX] Document settings language simplification (#3215)
As suggested by @comradekingu in https://github.com/koreader/koreader/pull/3165#issuecomment-326795203
2017-09-13 12:44:37 +02:00
Allan Nordhøy
3f24514a8d Set Rendering Style, and Comments (#3165) 2017-09-13 12:16:42 +02:00
poire-z
991b56664f Added Swipe to follow nearest link/to jump to latest bookmark (#3207) 2017-09-11 22:56:15 +02:00
Frans de Jonge
a39db783c0 [SDL] Add quit through regular window manager actions (#3206)
* [SDL] Add quit through regular window manager actions

Depends on https://github.com/koreader/koreader-base/pull/506

* proper exit and fix bug in restart function as a bonus
2017-09-11 21:37:00 +02:00
poire-z
a9c1ed24b8 Show vertical marker at target position when following a link (#3202) 2017-09-11 17:11:04 +02:00
poire-z
a720eaceb5 Hold on a word for more than 3 seconds to access highlight menu (#3199)
and avoid the dict lookup.
2017-09-10 20:35:27 +02:00
Frans de Jonge
164f0568b1 [fix] ReaderHighlight: remove highlight when closing popup dialog
See https://github.com/koreader/koreader/pull/3198#issuecomment-328339992
2017-09-10 14:39:10 +02:00
Frans de Jonge
7310937219 [fix] "Follow Link" popup issues (#3198)
* Add current location to location stack from follow link popup
  See https://github.com/koreader/koreader/pull/3190#issuecomment-328332771
* Word highlight not removed
* "Follow Link" not translated
* Typo in docs
2017-09-10 14:26:49 +02:00
Frans de Jonge
f439ca0e8d [UX] Add "Follow Link" in hold/highlight dialog (#3190)
* This way you can disable "tap to follow links" on single tap yet still follow links.
* Change menu as well as per @poire-z's suggestion.
2017-09-09 18:30:00 +02:00
poire-z
75b7c4b524 Added Font Hinting toggle (#3182) 2017-09-08 17:38:51 +02:00
Robert
2b3b310719 Fix: Lost last document position in scroll mode (#3183) 2017-09-06 20:12:26 +02:00
Robert
2a0e424a17 Prevent crash on exit in scroll mode (#3171) 2017-09-05 18:22:36 +02:00
Frans de Jonge
ba7fad2cdf [fix] Dict settings NaN in installed dicts submenu (#3173) 2017-09-05 07:56:05 +02:00
poire-z
d4fd0b9428 frontlight on kobo: a few fixes (#3163)
* frontlight on kobo: a few fixes

Rewritten to not update NickelConf on every change, and never
if KOBO_SYNC_BRIGHTNESS_WITH_NICKEL = false.
Reintroduce global settings frontlight_intensity and
is_frontlight_on to keep level and state across koreader
sessions.
Fix a few of the remaining issues on kobo light.
Ensure settings are saved when rebooting/powering off from
File browser.

* Ensure untoggle works when starting with light off
2017-09-04 21:05:05 +02:00
Frans de Jonge
177485f84f [UX] Add exit menu (#3167)
* fixes #2898 (prevents accidentally triggering reboot or poweroff)
  Add ConfirmBox before reboot/power off
* increases clarity by preventing second page
* add "sleep" menu entry
* Add exit menu hold callback
2017-09-03 15:40:50 +02:00
poire-z
774d2345e0 Added Embedded Fonts config toggle
Just under the existing "Embedded Styles". Support for this
was already there in crengine, and interfacing is similar to
what is done with Embedded Styles.
2017-09-02 20:49:48 +02:00
Robert
40ec848098 Remove % from frontlight level on devices other than Kobo (#3162) 2017-09-02 18:33:40 +02:00
poire-z
6efcfce479 Fix "Info on dictionaries ordering" string for translation (#3156) 2017-09-01 20:42:03 +02:00
poire-z
d5924f1d3d Use multiple sdcv -u params instead of renaming .ifo 2017-08-30 08:44:41 +02:00
poire-z
6d8d202f3b Dict settings menu: list dicts, and allow disabling them 2017-08-30 08:44:41 +02:00
Robert
0e2d20353a Statistics plugin v2 (SQLite) (#2893) 2017-08-29 17:34:49 +02:00
poire-z
17014f9281 Avoid settings double save when leaving Reader (#3131) 2017-08-25 18:55:44 +02:00
poire-z
7284ad4bf7 Use checkmarks with Set render style items (#3122) 2017-08-22 18:30:21 +02:00
poire-z
5d2bebcc0b Added Dictionary settings and Wikipedia settings menus (#3121)
Also removed OPDS `download_dir` from the candidates to Wikipedia
"Save as EPUB" dir.
2017-08-22 17:24:31 +02:00
poire-z
9c08236b70 Update 'lastfile' if autoremove_deleted_items_from_history
For people who set autoremove_deleted_items_from_history to true,
file is removed from history when Deleted or 'Purge .sdr'. This also
update lastfile to the new top in history if needed.
2017-08-21 16:02:01 +02:00
Frans de Jonge
c8ab9183aa [UX] ReaderUI: save/don't save document instead of yes/no
Brings it in line with UX guidelines.
2017-08-21 09:19:24 +02:00
poire-z
031df2ffee Added PicDocument:getCoverPageImage() and :getProps()
So an image file can have a cover in coverbrowser's display.
It also allows for an alternative viewer (ImageViewer widget)
when holding on file / View full size cover.
2017-08-20 19:59:15 +02:00
poire-z
3cf419defa Purge .sdr: also remove .old backup file
Otherwise, this .old backup is used when re-opening the document,
and we could never reset docsettings.
2017-08-19 16:49:52 +02:00
poire-z
3dd18d2a3b Fix "start with history" misalignment
due to a side effect with coverbrowser. CenterContainer is no
more needed as History is now full screen.
2017-08-18 10:37:46 +02:00
Frans de Jonge
6bdb96c0f8 [UX] FileManager: add ConfirmBox for purge .sdr
Notified of destructive action without confirmation in https://www.mobileread.com/forums/showthread.php?p=3566978#post3566978
2017-08-17 08:54:10 +02:00
Frans de Jonge
23cd585fae Support history as default view for filemanager (#3058)
Fixes #2774

* make history view borderless
* add new menu for what to start with

Should combine nicely with #2940
2017-08-14 13:15:12 +02:00
robert00s
6bded7aaf7 readerconfigmenu(fix): override pan gesture from scrolling 2017-08-14 11:24:40 +02:00
Robert
27c4e28e84 Fix: Cloud Storage not working on Kobo Aura ONE (#3077)
* Fix: Cloud storage opens in landscape mode when display is in portrait mode
Fix: If return is pressed when in root, koreader crashes
2017-08-13 12:57:19 +02:00
robert00s
dfba135f10 Fix: Advanced settings crashes 2017-08-09 20:54:29 +02:00
Robert
1bfad22af0 Fix: Footer hides text (#3056)
This patch should resolve issue #2257 (Footer hides text)
Sometimes, depending on an epub style, some text is hidden by the progress bar (the mini one at the bottom).
2017-08-08 19:06:11 +02:00
robert00s
64529b5391 Option to choose gesture to open menu 2017-08-08 18:45:14 +02:00
Robert
21c63a297e Gesture to show only config menu (#3051)
* Gesture to show only config menu

* Show config menu from bottom
2017-08-05 21:49:00 +02:00
robert00s
4b9fc6333f Fix: Unable to click on highlighted text in tap menu zone 2017-08-04 17:26:50 +02:00
Robert
2d89e16fab Fix: Can't long-press lookup word inside bookmark tap zone (#3048)
* Fix: Can't long-press lookup word inside bookmark tap zone
2017-08-03 20:06:30 +02:00
robert00s
6d5859d11d Read bookmarks without having to view ebook page 2017-07-31 20:36:06 +02:00
Robert
4d0f66a354 Fix: Unhighlight is not clickable in dictionary view and Deleting highlights in bookmarks does not take effect (#3034)
* Fix: Unhighlight is not clickable in dictionary view
* Fix: Deleting highlights in bookmarks does not take effect
2017-07-28 22:39:54 +02:00
robert00s
ba96506483 Fix event AddHightligh and add event DelHighlight 2017-07-27 20:25:26 +02:00
poire-z
dffa2f2563 Prevent creating empty sidecar directories 2017-07-14 16:46:38 +02:00
poire-z
17656778b1 Book information: refactored and additional features
- Factored out duplicate code from filemanager.lua and filemanagerhistory.lua
to new filemanagerbookinfo.lua (and other common code to filemanagerutil.lua).
- Uses sidecar files' new doc_props and doc_pages settings, or fallback to
old 'stats' settings, or to opening document.
- Shows filename, filetype and directory.
- Shows description (Hold to see whole truncated text), keywords, and
cover image (tap to extract image from document and display it if available).
- Book information now available from reader menu, to display info about
the currently opened book.
- Convert possibly HTML description to plain text via added
util.htmlToPlainTextIfHtml() (for simple HTML conversion).
2017-07-14 16:46:38 +02:00
poire-z
64f699ba36 Store book metadata and nb of pages in new settings
They may already be available (with other statistics stuff) under
the 'stats' key, but not if Statistics plugin is disabled. As this
plugin may be migrated to SQLite, readerui and readerfooter will now
set two new properties: doc_props (containing all and only the metadata
returned by document:getDocumentProps()) and doc_pages (updated
by readerfooter on any display or font change).

PDF document: returns additional PDF properties: Keywords
and Subject (as Description).
2017-07-14 16:46:38 +02:00
Robert
b446be74d5 Font zooming more than 1 (#2989) 2017-06-29 20:38:39 +02:00
Hzj_jie
d83de47204 Add onFrontlightStateChanged event (#2966)
So we do not need the hacky solution in KoboLight plugin anymore. PageFooter can receive and process the event itself.
2017-06-19 19:00:36 -07:00
Huang Xin
8938786472 [fix] stop propagation of tap events when triggering reader menu (#2934)
* [fix] stop propagation of tap events
when triggering reader menu
And also get rid of unnecessary screen refreshes on Kindle Voyage.
The "progress" window for dict lookup is also eliminated as most of the time dict lookup is an instant process, and the "progress" window is preserved for wikipedia lookup as it may take longer time to show the result window.

* [up] add an option to disable dictionary fuzzy search

* [fix] tidy up require

* [fix] fix read settings
2017-06-19 00:08:57 +08:00
Frans de Jonge
28524a5847 ReaderUI: return to filemanager instead of quitting if no document (#2956)
This affects #2335, at least for documents covered by `validDjvuFile()` (see 76cef07c07/frontend/document/djvudocument.lua (L15-L23)). However, that's only with regard to `touch invalid.djvu` and should not affect whatever happened in the OP.
2017-06-17 11:44:29 +08:00
Hzj_jie
53eb4dee50 AutoFrontlight plugin (#2941)
* Add AutoFrontlight plugin

* Add configuration to control autofrontlight feature
2017-06-14 19:32:16 +02:00
chrox
fef18ec73a [fix] revert removing tap gestures to show menus
as the tap gesture on the upper part (mostly) of the screen is
a conventional design to show menus in almost all ereaders as well as
some mobile phone apps. While users not farmilar with the Android world
have no experience with swipe down to show menus that's why we need a
quick start guide for this feature. And experienced Koreader users
probably will turn pages by mistake each time they want to popup the menus.

The solution here is adding back the tap gestures as they were and keep
the new swipe to show menu feature as a supplementary function when
link's tap area blocks menu's tap area.
2017-06-01 20:04:14 +02:00
Frans de Jonge
6815959f06 ReaderView: add long-press to set default
Fixes #2915
2017-05-24 01:46:24 -07:00
robert00s
c749c42b4b Fix #2667 2017-05-21 00:35:45 -07:00
Hzj_jie
30378eb2a8 Add restart koreader function and ensure FlushSettings event can be delivered to all widgets (#2772) 2017-05-16 02:11:11 -07:00
Frans de Jonge
3492b8b117 (minor, lang) improve text clarity for downloadmgr dialogs (#2897)
It's not necessarily clear that you need to long-press, see https://www.mobileread.com/forums/showpost.php?p=3520376&postcount=7
2017-05-15 21:48:18 -07:00
poire-z
9e346f5559 Allow wikipedia lookup from filemanager
Also allow taking screenshot when on dictionary window.
2017-05-12 19:10:26 +02:00
Qingping Hou
bde2139b27 wifi(fix): quote ssid and password for wpa_passphrase 2017-05-09 09:43:47 +02:00
Qingping Hou
23c2955500 chore: style cleanup for infomessage 2017-05-08 09:38:48 +02:00
Robert
394be8a651 Remove run twice onPageUpdate() when document is opening (#2855)
* Remove run twice onPageUpdate() when document is opening
2017-05-06 19:54:31 +02:00
poire-z
3b813c761f Fix crash on Swipe to follow links with DJVU documents 2017-05-02 00:18:55 -07:00
Frans de Jonge
773e24fc79 (chore) some require sorting. 2017-04-29 11:41:24 -07:00
poire-z
2dc604bb74 Allow for setting a default or fallback hyph dictionary
It makes no sense to have both, so setting a default removes
the fallback, and setting a fallback removes the default.
Also save hyph_alg to document setting only if it has been
manually chosen, so that later changes to default or fallback
can be used.
2017-04-29 14:48:42 +02:00
Frans de Jonge
e1aa57f27e Font: unify font styling 2017-04-29 03:01:38 -07:00
Frans de Jonge
4616339ef8 KeyValuePage: improve looks
Fixes #2578.

* key bolded
* values normally left-aligned at 50%
* allows misalignment for the sake of fitting everything on one line
2017-04-29 03:01:38 -07:00
Frans de Jonge
ed7937f65d ReaderDictionary: add info message about installing dictionaries
Fixes #2816.
2017-04-27 01:29:24 -07:00
Qingping Hou
55ec64a859 readermenu(fix): override pan gesture from scrolling 2017-04-24 15:19:38 +02:00
Qingping Hou
72ae80870c quickstart fix (#2804)
* translation text fix

* quickstart(fix): go back to home dir after document close

* quickstart(fix): purge old quick start files

* spec: fix quickstart tests
2017-04-24 08:27:29 +02:00
Qingping Hou
f2671a3e20 plugin(fix): catch crash in addToMainMenu 2017-04-22 00:22:37 -07:00
Qingping Hou
fd862f5e28 plugin(fix): catch plugin crash at init time 2017-04-22 00:22:37 -07:00
Robert
16192d2354 Pinch gesture for changing font size (#2768)
* Pinch gesture for changing font size
2017-04-22 00:18:10 -07:00
Frans de Jonge
89099e2c94 Swipe for menu and quickstart guide (#2761)
* Swipe for menu and quickstart guide

Because swiping for the menu is a big change from what we're used to, this commit includes a new quickstart guide.

Fixes #2608.

* add some dev docs
* add FileConverter spec
* add QuickStart spec
* add Version module
* add Version spec
2017-04-15 14:45:56 +02:00
Qingping Hou
1922b2526b fix: normalize require path to reuse import result 2017-04-14 21:28:38 +02:00
Robert
9a247e86ae Screensaver on Kindle without Special Offers (#2757) 2017-04-13 19:55:31 +02:00
robert00s
7872bd3bc1 Fix: Frontlight level in Status bar in Kobos without light 2017-04-13 19:53:46 +02:00
Frans de Jonge
9b2128ecb8 FileConverter added with local Markdown to HTML conversion (#2737)
* FileConverter added with local Markdown to HTML conversion
2017-04-12 20:42:28 +02:00
Qingping Hou
f51285e89b revert code that enables screensaver on kindle by default 2017-04-11 11:47:33 +02:00
Qingping Hou
15fd7fc0ff bring back support for disabling progressbar in footer (#2753)
* footer(optimize): remove dead code

* footer(fix): disable auto refresh time option when current time is not checked

* fix: support disable progress bar again
2017-04-11 11:44:58 +02:00
poire-z
5bc19fa084 clean ReaderDictionary:cleanSelection
crengine now does a much better job at finding word boundaries, so
less cleanup is needed
2017-04-11 00:01:49 -07:00
Frans de Jonge
338fcd76ae Lang: two tiny strings
* ReaderHighlight: underscore to underline. Although underscore means to
emphasize by underlining, the emphasis lies on the, ahem, emphasis. Besides
which, it's mostly AmE and less well understood worldwide (although in this
particular context it should probably cause no trouble).

* Statistics plugin: menu item text to "reading statistics" to make it clear
which statistics we're talking about. Fixes #2744.
2017-04-09 15:03:21 -07:00
Robert
59873ae293 Screensaver option on Kindle devices (#2734)
* Screensaver on Kindle devices
2017-04-08 23:21:03 +02:00
Frans de Jonge
e8721887ba InputContainer: add cancel_text and ok_text
Makes it easier to comply with UX style.

* Change "OK" to "Search dictionary" in Dictionary lookup to comply with UX style
* Change "OK" to "Search all text" in Fulltext search to comply with UX style

Tacked on but highly related:

* change "OK" to "Search Wikipedia" in Wikipedia lookup to comply with UX style
* change "OK" to "Set default" in ConfigDialog to comply with UX style

Chore:

* fixed up order of requires
2017-04-08 03:27:18 -07:00
Frans de Jonge
92b9139294 ReaderFooter (lang): "Show toc markers" to "Show chapter markers"
I think it sounds more natural as chapter than as table of content, which is an implementation detail (i.e., the chapter markers are shown based on what's in the TOC).

Also removed redundant "this" from "Remaining pages in this chapter"
2017-04-08 01:39:25 -07:00
Frans de Jonge
0256601e85 UX and language fixes
* lang: changed `...` in CloudStorage to real ellipses
* chore: reordered requires in CloudStorage per coding style
* UX: switched "Close" and "Stay alive" in KeepAlive per UX style
* lang: improved message in CloudStorage
* chore: reordered requires in OTAManager per coding style
* lang: removed "your" from "Your KOReader is up to date" in OTAManager
2017-04-06 21:56:56 -07:00
robert00s
ba74921c4b Fix showing footer on Kindle with Special Offers screensaver 2017-04-05 10:26:09 +02:00
Frans de Jonge
1c25d0fd1b Language: improve confirmboxes
Generic "OK" buttons should be avoided. Thanks to @lightonflux for pointing this out https://github.com/koreader/koreader/issues/2555#issuecomment-291039945
2017-04-04 07:56:09 -07:00
Frans de Jonge
b076ca1c29 ReaderFooter: fix quick browsing by tapping footer in flipping mode
Fixes #2649.
2017-04-03 10:10:23 -07:00
Robert
3f0ce5de34 Remove invalid UTF8 chars from FTP (cloud storage) and sort order of requires (#2711) 2017-04-02 15:06:59 -07:00
Frans de Jonge
e5a3ecd3e5 CreDocument: disable fancy formatting by default
It does significantly more harm than good. It can be reenabled with a `txt_preformatted` setting if desired. Fixes #1607.
2017-04-01 16:23:56 -07:00
Hzj_jie
ea2de9638b LuaSettings:wrap() / LuaSettings:child() function to create an LuaSettings to represent a sub table of an existing one (#2685) 2017-03-28 15:10:36 -07:00
Frans de Jonge
bdbda9b405 ReaderMenu: fix MenuSorter-related typo (#2689)
Fixes #2688
2017-03-28 13:18:42 -07:00
Frans de Jonge
791d540a5a FileSearcher: filter .sdr directories
Fixes #2665
2017-03-26 20:52:29 -07:00
Frans de Jonge
8b7e18a7d7 MenuSorter: resolve review comments
* simplify user config loop
* simplify unit test for Travis memory use
* remove unused util variable
2017-03-26 11:12:44 +02:00
Frans de Jonge
ddf590eb6d MenuSorter: split out menu order configuration 2017-03-26 11:12:44 +02:00
Frans de Jonge
a970a1f034 MenuSorter: fix outside testability (for potential unit tests) 2017-03-26 11:12:44 +02:00
Frans de Jonge
8f31a81601 MenuSorter: some documentation
MenuSorter: forgot to add plugin style change

MenuSorter: worked out the final quirks

* Menu always compressed into tables without missing indexes for ipairs compatibility
* Orphans attached
* Separators no longer count as items
2017-03-26 11:12:44 +02:00
Frans de Jonge
b7b5950e98 MenuSorter: review comments and various bug fixes
* fixed wrongful retention of submenus variable and added return to MenuSorter:findById
* fixed readerfooter_spec.lua error
* fixed review comments
2017-03-26 11:12:44 +02:00
Frans de Jonge
aa0bf60ccb MenuSorter: pass config prefix for proper user override 2017-03-26 11:12:44 +02:00
Frans de Jonge
5b20106db7 MenuSorter: initial implementation
* Menus are now sanely configurable
* Custom separator placement for clearer menus
2017-03-26 11:12:44 +02:00