koreader

Commit Graph

Author	SHA1	Message	Date
NiLuJe	b523c2e8b9	InputContainer: Fall cleanup ;). Get rid of the doc & seqtext fields, as they are not actually used (nor are they particularly useful, the event handler's name should be pretty self-explanatory). Also, tweak the key_events documentation to highlight the quirks of the API, especially as far as array nesting is involved... Random drive-by cleanup of the declarations of key_events & ges_events to re-use the existing instance object (now that we know they're sane ;p) for tables with a single member (less GC pressure).	2 years ago
weijiuqiao	6bd7dfdf41	Vocabulary builder: add "Open..." to Dispatcher (#9634 ) So it can be called from a gesture. Also accommodate reset all in reversed order.	2 years ago
weijiuqiao	edf7cc9a61	Vocabulary builder: support extracting context from pdfs (#9622 ) Move getSelectedWordContext(), now document specific, from ReaderHighlight into each document module.	2 years ago
weijiuqiao	7fc803ffee	Vocabulary builder: supports review in reverse order (#9605 )	2 years ago
zwim	4969811c08	Optimization: Use constant folding for divisions not a power of two (#9609 )	2 years ago
NiLuJe	fadee1f5dc	Clarify our OOP semantics across the codebase (#9586 ) Basically: * Use `extend` for class definitions * Use `new` for object instantiations That includes some minor code cleanups along the way: * Updated `Widget`'s docs to make the semantics clearer. * Removed `should_restrict_JIT` (it's been dead code since https://github.com/koreader/android-luajit-launcher/pull/283) * Minor refactoring of LuaSettings/LuaData/LuaDefaults/DocSettings to behave (mostly, they are instantiated via `open` instead of `new`) like everything else and handle inheritance properly (i.e., DocSettings is now a proper LuaSettings subclass). * Default to `WidgetContainer` instead of `InputContainer` for stuff that doesn't actually setup key/gesture events. * Ditto for explicit `Listener` only classes, make sure they're based on `EventListener` instead of something uselessly fancier. Unless absolutely necessary, do not store references in class objects, ever; only values. Instead, always store references in instances, to avoid both sneaky inheritance issues, and sneaky GC pinning of stale references. * ReaderUI: Fix one such issue with its `active_widgets` array, with critical implications, as it essentially pinned all of ReaderUI's modules, including their reference to the `Document` instance (i.e., that was a big-ass leak). * Terminal: Make sure the shell is killed on plugin teardown. * InputText: Fix Home/End/Del physical keys to behave sensibly. * InputContainer/WidgetContainer: If necessary, compute self.dimen at paintTo time (previously, only InputContainers did, which might have had something to do with random widgets unconcerned about input using it as a baseclass instead of WidgetContainer...). * OverlapGroup: Compute self.dimen at init time, because for some reason it needs to do that, but do it directly in OverlapGroup instead of going through a weird WidgetContainer method that it was the sole user of. * ReaderCropping: Under no circumstances should a Document instance member (here, self.bbox) risk being `nil`ed! * Kobo: Minor code cleanups.	2 years ago
weijiuqiao	24edbe162f	Vocabulary builder: support manually adding words to vocabulary builder	2 years ago
weijiuqiao	5d9f036331	Vocabulary builder: add Undo study status (#9528 ) Adds button to undo last study operation (got it/forgot) in more (...).	2 years ago
weijiuqiao	30915546f0	vocabbuilder.koplugin: always show more button, add book filtering (#9393 ) Always show more button instead of delete regardless of review count per #9383. Adds book filtering per #9256 (from menu or by swiping up).	2 years ago
weijiuqiao	9980827145	Vocabulary builder: fix translatable string and minor UI issue (#9233 )	2 years ago
weijiuqiao	cafbf36bb2	Vocabulary builder: store word context, other tweaks and fixes (#9195 ) Add a copy button and save word context (off by default), shown via the three-dot menu of word entries. Also some db refactoring and minor UI improvements: - a dedicated book title table in order to shrink db size by storing references to title names instead of repeated actual strings, - alignment of different forms of the "more" button and possible clipped words in translations. - fix plugin name so it can be disabled	2 years ago
weijiuqiao	18db85ea0d	[plugin] Vocabulary builder bugfix and quick word deletion (#9168 ) This PR fixes the bug #9162 caused by unsafe db operation and adds an edit mode for quick deletion of words requested at #9132 (comment)	2 years ago
weijiuqiao	e1b137339c	[feat, plugin] Vocabulary builder (#9132 ) Made the old dictionary lookup history into a flashcard-ish vocabulary builder.	2 years ago

13 Commits (b523c2e8b9354825c1b0d09a89946dff9c2d105d)