9 Commits (b523c2e8b9354825c1b0d09a89946dff9c2d105d)

Author	SHA1	Message	Date
NiLuJe	b523c2e8b9	InputContainer: Fall cleanup ;). ... Get rid of the doc & seqtext fields, as they are not actually used (nor are they particularly useful, the event handler's name should be pretty self-explanatory). Also, tweak the key_events documentation to highlight the quirks of the API, especially as far as array nesting is involved... Random drive-by cleanup of the declarations of key_events & ges_events to re-use the existing instance object (now that we know they're sane ;p) for tables with a single member (less GC pressure).	2 years ago
NiLuJe	d2ac2ca6e7	Cleanup: Remove unused onAnyKeyPressed handlers ... And simplify the few we do catch by using aliases instead of duplicated functions;).	2 years ago
NiLuJe	fadee1f5dc	Clarify our OOP semantics across the codebase (#9586) ... Basically: * Use `extend` for class definitions * Use `new` for object instantiations That includes some minor code cleanups along the way: * Updated `Widget`'s docs to make the semantics clearer. * Removed `should_restrict_JIT` (it's been dead code since https://github.com/koreader/android-luajit-launcher/pull/283) * Minor refactoring of LuaSettings/LuaData/LuaDefaults/DocSettings to behave (mostly, they are instantiated via `open` instead of `new`) like everything else and handle inheritance properly (i.e., DocSettings is now a proper LuaSettings subclass). * Default to `WidgetContainer` instead of `InputContainer` for stuff that doesn't actually setup key/gesture events. * Ditto for explicit `*Listener` only classes, make sure they're based on `EventListener` instead of something uselessly fancier. * Unless absolutely necessary, do not store references in class objects, ever; only values. Instead, always store references in instances, to avoid both sneaky inheritance issues, and sneaky GC pinning of stale references. * ReaderUI: Fix one such issue with its `active_widgets` array, with critical implications, as it essentially pinned *all* of ReaderUI's modules, including their reference to the `Document` instance (i.e., that was a big-ass leak). * Terminal: Make sure the shell is killed on plugin teardown. * InputText: Fix Home/End/Del physical keys to behave sensibly. * InputContainer/WidgetContainer: If necessary, compute self.dimen at paintTo time (previously, only InputContainers did, which might have had something to do with random widgets unconcerned about input using it as a baseclass instead of WidgetContainer...). * OverlapGroup: Compute self.dimen at *init* time, because for some reason it needs to do that, but do it directly in OverlapGroup instead of going through a weird WidgetContainer method that it was the sole user of. * ReaderCropping: Under no circumstances should a Document instance member (here, self.bbox) risk being `nil`ed! * Kobo: Minor code cleanups.	2 years ago
Frans de Jonge	039947886f	Revert "Hyphenation: add custom hyphenation rules (#7746)" (#7785) ... This reverts commit f25da5d0d5.	3 years ago
zwim	f25da5d0d5	Hyphenation: add custom hyphenation rules (#7746) ... The hyphenation of a word can be changed from its default by long pressing for 3 seconds and selecting 'Hyphenate'. These overrides are stored in a per-language file, i.e: koreader/settings/user-German.hyph.	3 years ago
NiLuJe	ad3bc29b1e	Events: Never stop propagating CloseWidget (#7744) ... That seems like a rather terrible idea to beign with, and that that may actually have fatal consequences. Re #7738 Co-authored-by: Frans de Jonge <fransdejonge@gmail.com>	3 years ago
poire-z	f05e62c1fb	TextWidget: small refactoring, better handle max_width (#5503) ... Lots of code was doing some renderText calls to get the size of some text string, and truncate it to some width if needed, with or without an added ellipsis, before instantiating a TextWidget with that tweaked text string. This PR fixes/adds some properties and methods to TextWidget so all that can be done by it. It makes the calling code simpler, as they don't need to use RenderText directly. (Additionally, when we go at using Harfbuzz for text rendering, we'll just have to update or replace textwidget.lua without the need to update any higher level code.) Also: - RenderText: removed the space added by truncateTextByWidth after the ellipsis, as it doesn't feel needed, and break right alignment of the ellipsis with other texts. - KeyValuePage: fix some subtle size and alignment issues. - NumberPickerWidget: fix font size (provided font size was not used)	5 years ago
poire-z	a82d7832b9	Dict lookups: have them always interruptible ... They should be now interruptible when fuzzy search is disabled and on Android.	5 years ago
poire-z	0ef948f60d	Trapper: adds dismissableRunInSubprocess() + new TrapWidget ... New TrapWidget: invisible full screen widget for catching UI events. Can optionally display a text message at bottom left of screen (ie: "Loading..."), used by default by Trapper:dismissable functions when no widget provided. Added Trapper:dismissableRunInSubprocess() to run a lua function in a sub-process, allowing it to be dismissed, and returns its return value(s).	6 years ago