8 Commits (b523c2e8b9354825c1b0d09a89946dff9c2d105d)

Author	SHA1	Message	Date
NiLuJe	b523c2e8b9	InputContainer: Fall cleanup ;). ... Get rid of the doc & seqtext fields, as they are not actually used (nor are they particularly useful, the event handler's name should be pretty self-explanatory). Also, tweak the key_events documentation to highlight the quirks of the API, especially as far as array nesting is involved... Random drive-by cleanup of the declarations of key_events & ges_events to re-use the existing instance object (now that we know they're sane ;p) for tables with a single member (less GC pressure).	2 years ago
NiLuJe	d2ac2ca6e7	Cleanup: Remove unused onAnyKeyPressed handlers ... And simplify the few we do catch by using aliases instead of duplicated functions;).	2 years ago
NiLuJe	fadee1f5dc	Clarify our OOP semantics across the codebase (#9586) ... Basically: * Use `extend` for class definitions * Use `new` for object instantiations That includes some minor code cleanups along the way: * Updated `Widget`'s docs to make the semantics clearer. * Removed `should_restrict_JIT` (it's been dead code since https://github.com/koreader/android-luajit-launcher/pull/283) * Minor refactoring of LuaSettings/LuaData/LuaDefaults/DocSettings to behave (mostly, they are instantiated via `open` instead of `new`) like everything else and handle inheritance properly (i.e., DocSettings is now a proper LuaSettings subclass). * Default to `WidgetContainer` instead of `InputContainer` for stuff that doesn't actually setup key/gesture events. * Ditto for explicit `*Listener` only classes, make sure they're based on `EventListener` instead of something uselessly fancier. * Unless absolutely necessary, do not store references in class objects, ever; only values. Instead, always store references in instances, to avoid both sneaky inheritance issues, and sneaky GC pinning of stale references. * ReaderUI: Fix one such issue with its `active_widgets` array, with critical implications, as it essentially pinned *all* of ReaderUI's modules, including their reference to the `Document` instance (i.e., that was a big-ass leak). * Terminal: Make sure the shell is killed on plugin teardown. * InputText: Fix Home/End/Del physical keys to behave sensibly. * InputContainer/WidgetContainer: If necessary, compute self.dimen at paintTo time (previously, only InputContainers did, which might have had something to do with random widgets unconcerned about input using it as a baseclass instead of WidgetContainer...). * OverlapGroup: Compute self.dimen at *init* time, because for some reason it needs to do that, but do it directly in OverlapGroup instead of going through a weird WidgetContainer method that it was the sole user of. * ReaderCropping: Under no circumstances should a Document instance member (here, self.bbox) risk being `nil`ed! * Kobo: Minor code cleanups.	2 years ago
Philip Chan	4f849c23ab	Non-touch: highlight support (#8877) ... readerhighlight: non-touch support focusmanager: fix same type container share same selected field radiobuttonwidget: non touch support sortwidget: non touch support openwithdialog: fix layout contains textinput, checkboxes added to layout twice	2 years ago
poire-z	16e3b2f0ac	Allow Backspace to work as back button	2 years ago
hius07	ca6d82e668	More widgets: insert TitleBar (#8683) ... SpinWidget, DoubleSpinWidget, DateTimeWidget, RadioButtonWidget got new TitleBar.	2 years ago
hius07	22a012e729	[chore] RadioButtonWidget: remove unused "Use default" string (#8354)	3 years ago
hius07	d652eec2cd	ReaderHighlight: allow updating a highlight drawing style (#8323) ... Also modify highlight dialog's "Edit" button to be "Add note" or "Edit note" whether a note has already beed added. Adds a new RadioButtonWidget.	3 years ago