7 Commits (b523c2e8b9354825c1b0d09a89946dff9c2d105d)

Author	SHA1	Message	Date
NiLuJe	b523c2e8b9	InputContainer: Fall cleanup ;). ... Get rid of the doc & seqtext fields, as they are not actually used (nor are they particularly useful, the event handler's name should be pretty self-explanatory). Also, tweak the key_events documentation to highlight the quirks of the API, especially as far as array nesting is involved... Random drive-by cleanup of the declarations of key_events & ges_events to re-use the existing instance object (now that we know they're sane ;p) for tables with a single member (less GC pressure).	2 years ago
NiLuJe	d2ac2ca6e7	Cleanup: Remove unused onAnyKeyPressed handlers ... And simplify the few we do catch by using aliases instead of duplicated functions;).	2 years ago
NiLuJe	fadee1f5dc	Clarify our OOP semantics across the codebase (#9586) ... Basically: * Use `extend` for class definitions * Use `new` for object instantiations That includes some minor code cleanups along the way: * Updated `Widget`'s docs to make the semantics clearer. * Removed `should_restrict_JIT` (it's been dead code since https://github.com/koreader/android-luajit-launcher/pull/283) * Minor refactoring of LuaSettings/LuaData/LuaDefaults/DocSettings to behave (mostly, they are instantiated via `open` instead of `new`) like everything else and handle inheritance properly (i.e., DocSettings is now a proper LuaSettings subclass). * Default to `WidgetContainer` instead of `InputContainer` for stuff that doesn't actually setup key/gesture events. * Ditto for explicit `*Listener` only classes, make sure they're based on `EventListener` instead of something uselessly fancier. * Unless absolutely necessary, do not store references in class objects, ever; only values. Instead, always store references in instances, to avoid both sneaky inheritance issues, and sneaky GC pinning of stale references. * ReaderUI: Fix one such issue with its `active_widgets` array, with critical implications, as it essentially pinned *all* of ReaderUI's modules, including their reference to the `Document` instance (i.e., that was a big-ass leak). * Terminal: Make sure the shell is killed on plugin teardown. * InputText: Fix Home/End/Del physical keys to behave sensibly. * InputContainer/WidgetContainer: If necessary, compute self.dimen at paintTo time (previously, only InputContainers did, which might have had something to do with random widgets unconcerned about input using it as a baseclass instead of WidgetContainer...). * OverlapGroup: Compute self.dimen at *init* time, because for some reason it needs to do that, but do it directly in OverlapGroup instead of going through a weird WidgetContainer method that it was the sole user of. * ReaderCropping: Under no circumstances should a Document instance member (here, self.bbox) risk being `nil`ed! * Kobo: Minor code cleanups.	2 years ago
Frans de Jonge	039947886f	Revert "Hyphenation: add custom hyphenation rules (#7746)" (#7785) ... This reverts commit f25da5d0d5.	3 years ago
zwim	f25da5d0d5	Hyphenation: add custom hyphenation rules (#7746) ... The hyphenation of a word can be changed from its default by long pressing for 3 seconds and selecting 'Hyphenate'. These overrides are stored in a per-language file, i.e: koreader/settings/user-German.hyph.	3 years ago
NiLuJe	ad3bc29b1e	Events: Never stop propagating CloseWidget (#7744) ... That seems like a rather terrible idea to beign with, and that that may actually have fatal consequences. Re #7738 Co-authored-by: Frans de Jonge <fransdejonge@gmail.com>	3 years ago
jperon	43ba8a1173	Qrcode support (#6844) ... 2 new widgets: - QRWidget, that's like an ImageWidget, but with a text property that will be converted to a QR code ; - QRMessage, that's like an InfoMessage, but shows the message as QR code. Moreover, it adds the ability to export QR codes to the text editor. 1 new plugin: - Generate QR codes from clipboard Changes to text editor plugin: - Add the ability to export QR codes.	4 years ago