8 Commits (b523c2e8b9354825c1b0d09a89946dff9c2d105d)

Author	SHA1	Message	Date
NiLuJe	b523c2e8b9	InputContainer: Fall cleanup ;). ... Get rid of the doc & seqtext fields, as they are not actually used (nor are they particularly useful, the event handler's name should be pretty self-explanatory). Also, tweak the key_events documentation to highlight the quirks of the API, especially as far as array nesting is involved... Random drive-by cleanup of the declarations of key_events & ges_events to re-use the existing instance object (now that we know they're sane ;p) for tables with a single member (less GC pressure).	2 years ago
NiLuJe	fadee1f5dc	Clarify our OOP semantics across the codebase (#9586) ... Basically: * Use `extend` for class definitions * Use `new` for object instantiations That includes some minor code cleanups along the way: * Updated `Widget`'s docs to make the semantics clearer. * Removed `should_restrict_JIT` (it's been dead code since https://github.com/koreader/android-luajit-launcher/pull/283) * Minor refactoring of LuaSettings/LuaData/LuaDefaults/DocSettings to behave (mostly, they are instantiated via `open` instead of `new`) like everything else and handle inheritance properly (i.e., DocSettings is now a proper LuaSettings subclass). * Default to `WidgetContainer` instead of `InputContainer` for stuff that doesn't actually setup key/gesture events. * Ditto for explicit `*Listener` only classes, make sure they're based on `EventListener` instead of something uselessly fancier. * Unless absolutely necessary, do not store references in class objects, ever; only values. Instead, always store references in instances, to avoid both sneaky inheritance issues, and sneaky GC pinning of stale references. * ReaderUI: Fix one such issue with its `active_widgets` array, with critical implications, as it essentially pinned *all* of ReaderUI's modules, including their reference to the `Document` instance (i.e., that was a big-ass leak). * Terminal: Make sure the shell is killed on plugin teardown. * InputText: Fix Home/End/Del physical keys to behave sensibly. * InputContainer/WidgetContainer: If necessary, compute self.dimen at paintTo time (previously, only InputContainers did, which might have had something to do with random widgets unconcerned about input using it as a baseclass instead of WidgetContainer...). * OverlapGroup: Compute self.dimen at *init* time, because for some reason it needs to do that, but do it directly in OverlapGroup instead of going through a weird WidgetContainer method that it was the sole user of. * ReaderCropping: Under no circumstances should a Document instance member (here, self.bbox) risk being `nil`ed! * Kobo: Minor code cleanups.	2 years ago
NiLuJe	fe10d0bce5	Revamp flash_ui handling, once more, with feeling ;) (#7262) ... * Simplify flash_ui handling (by handling the unhighlight pre-callback, c.f., #7262 for more details). * UIManager: Handle translucent window-level widgets (and those wrapped in a translucent MovableContainer) properly in setDirty directly, making sure what's *underneath* them gets repainted to avoid alpha layering glitches. (This was previously handled via localized hacks). * Update UIManager's documentation, and format it properly for ldoc parsing, making the HTML docs more useful. * ReaderView: Reinitialize the various page areas when opening a new document, to prevent poisoning from the previous document. * Event: Handle nils in an event's arguments. * CheckButton/RadioButton: Switch to simple inversion to handle highlighting * CheckButton: Make the highlight span the inner frame's width, instead of just the text's width, if possible. * AlphaContainer: Fix & simplify, given the UIManager alpha handling. * MovableContainer: When translucent, cache the canvas bb used for composition. * Avoid spurious refreshes in a few widgets using various dummy *TextWidgets in order to first compute a text height. * KeyValuePage: Avoid floats in size computations.	3 years ago
poire-z	cac7db1a1c	InfoMessage: allows being drawn only after a delay ... - InfoMessage: add an option show_delay. - MovableContainer: avoid possible crash when not yet painted. - ReaderDictionary: use show_delay=0.5 instead of scheduleIn(0.5n...) (a5b133da) as we need the InfoWidget to be known to UIManager to catch tap and allow interrupting lookups properly. - ReaderDictionary: rework handling of no_refresh_on_close (6162c287) with proper regions comparisons	3 years ago
poire-z	24424e505e	Update UI layout code to use new SVG icons ... - Add IconWidget, use it for icons instead of ImageWidget. Specify icons by name only, look for them (with either .svg or .png suffixes) in multiple directories (including koreader/settings/icons/ to allow customizing them). Don't crash when icon name not found, shown a black background warning icon instead. - Don't trust the icons' native sizes: replace scale_for_dpi=true with width/height=DGENERIC_ICON_SIZE, so all icons get the same (tunable) size - except in a few specific use cases. - Top and bottom menu bars: normalize, and have icons properly centered in them, extend vertical line separators up to the edges. - TOC: adjust expand/collapse icons size to items size	3 years ago
poire-z	03bbba249a	MovableContainer: avoid refresh glitches on close (#5094) ... The contained widget may not have integer position/dimen (which should probably be fixed in those that don't ensure that), and our maths could eventually make them even more shifted by fractional parts. In the end, when closing the widget, the refresh code may miss painting/cleaning 1px and leave a border of the widget on the screen.	5 years ago
poire-z	e7f705bf10	Fix some issues with movable dict window (#3722) ... Some Hold and move (hold on title and move away from it) would not work. Pan (=swipe with hold at end) while selecting text would move the window (it now does nothing: proper text selection still needs Hold on word at start). Also increase hold duration from 2s to 3s (for switching lookup between dict/wikipedia) to be consistent with the 3s duration in readerhighlight.	6 years ago
poire-z	43a6cf4b2e	Add MovableContainer: allow moving some widgets (#3636)	6 years ago