Commit Graph

1684 Commits (b476989d3bfe18c19588e74ebe9037d5339d3d0d)

Author SHA1 Message Date
Frans de Jonge 73a6f71a0b Prevent spaces from being eaten by Transifex
Fixes #1276
10 years ago
Frans de Jonge 7a87b66fa1 OPDS catalog: auto-fill http:// if no protocol given and revert #1106
This fixes #1259.
10 years ago
Huang Xin 1b07698952 Merge pull request #1296 from hwhw/imagewidget_alpha
Imagewidget alpha
10 years ago
Hans-Werner Hilse b2e38ca80d honor alpha when painting the dog-ear bookmark icon
allows for different icons making use of that. For our current icon,
it actually doesn't.

Fixes #402
10 years ago
Hans-Werner Hilse 0c80537003 allow image widgets to do alpha-blitting
when the image (e.g. a PNG) does contain an alpha channel, that can
be honored by ImageWidget. It doesn't do so by default for compatibility
(arguably, we should change that in the future), it has to be enabled
by setting the "alpha" property to "true" (boolean, not string).
10 years ago
Hans-Werner Hilse a82bafc63c fix handling of invalid UTF8 sequences
external data (and in bad cases our own) can contain invalid byte
sequences in UTF8 strings. A prominent example are file names.
There was a 1-off bug in calculating the allowed length for multibyte
chars, and the iterator was a bit too greedy when stumbling upon
invalid sequences, returning a single "invalid" char for a sequence
up to the point where it became invalid in calculation. Now, we present
one invalid char for the first byte of that sequence and then check
for a valid char starting with the next byte.
10 years ago
Hans-Werner Hilse f828f6e7e4 show dictionary title in info popup when setting default dictionary 10 years ago
Hans-Werner Hilse 1156bcd057 show a popup upon making a dictionary the default dictionary 10 years ago
Huang Xin a72bc33022 Merge pull request #1293 from Frenzie/language
Reworked several strings
10 years ago
Frans de Jonge 693fa0837e Reworked several strings
This is the remaining gruntwork of #1276. I believe that only leaves networkmgr.lua and filemanagersearch.lua, which will require a little more thought.
10 years ago
Huang Xin e835c1e502 Merge pull request #1280 from hwhw/master
fix a case when "ip r" command fails
10 years ago
Frans de Jonge 66f04af8fb Various applications of util.template
This is the first bunch for #1276. I'd like to resolve #1281 before doing more.
10 years ago
Hans-Werner Hilse 48610006d5 fix a case when "ip r" command fails
our network manager script isn't the beauty of the code base.
However, this fixes a case where it would crash the reader when an
external command fails.

fixes #1279.
10 years ago
Frans de Jonge cf93605d04 Change "Screen Mode" to "Orientation"
Screen mode isn't user-oriented. Orientation is.

"Page" in "Page Margin" is redundant
10 years ago
Hans-Werner Hilse 173de615db Revert "smaller viewport for Kobo H2O (bezel overlaps bottom)"
This reverts commit fc36d6db37.
10 years ago
Hans-Werner Hilse fc36d6db37 smaller viewport for Kobo H2O (bezel overlaps bottom) 10 years ago
Hans-Werner Hilse dacb59f6b2 move debug function handover, set viewport for Kobo Mini
in order to have debugging facilities in framebuffer:init(), we hand
over the debug function as soon as we can.

Also, set a viewport for Kobo Mini. Hopefully, it fits most people -
I can only test on my unit.
10 years ago
Hans-Werner Hilse 4a497cfcfb fix initialization order on Kobos
notably, this will set up input offsets for viewport stuff after the
input rotation has been set up.
10 years ago
chrox ca60ceacd0 make radius field respects popout flag 10 years ago
chrox fe885be563 refactoring readerbookmark to show both bookmarks and highlights
in the bookmark menu
and use binary search of the sorted bookmarks table whenever is
possible.
10 years ago
chrox ac6a34ee3d fix crash on special offered Kindle 10 years ago
Hans-Werner Hilse 895b98d5be add debugging output for device initialisation 10 years ago
Hans-Werner Hilse 677871cbf7 allow emulator to specify a viewport
This allows for Viewport debugging. It is configured via an environment
variable, EMULATE_READER_VIEWPORT. It works with Lua table syntax, e.g.:
EMULATE_READER_VIEWPORT="{x=10,w=550,y=5,h=790}"
10 years ago
Hans-Werner Hilse bf7ea7af6d add device names as comments
we use mostly code names internally, but it is probably a good idea
to annotate the actual device names.
10 years ago
Frans de Jonge 141095b0c8 Alterations to the menu
References #1219 and #1258.
10 years ago
Hans-Werner Hilse 48ea442e28 close file descriptor of dictionary lookup pipe 10 years ago
Hans-Werner Hilse c6d342f305 fix usage of old refresh API
standby/screensaver/USB was affected.
10 years ago
chrox e1af7f2ed3 prompt users to long press directory to set inbox
This should fix #1233.
10 years ago
chrox 1accddb8cd fix #1236 by opening the parent directory of last used document 10 years ago
chrox 0a06041cd9 fix calculation of widget height of filechooser
the height of filechooser is provided when creating filechooser
widget since there may be no title as in filemanger which needs
a special title widget to contain filemanger menu.
10 years ago
chrox 67693367b9 init width and height of filechooser widget during init
so that everytime a filechooser is inited right dimension
size is used.
10 years ago
chrox 548e830fdc fix crash when highlighting text in EPUB documents
Since the new Screen:getSize modthod returns a regular table
instead of a Geom which is set to the dimen field of readerview,
there is no copy method in the dimen field. And we don't need to
copy dimen any more since the result won't be modified. Even the
screen page area somehow needs to be modified, the caller of this
function should make a copy of that variable by itself.
10 years ago
Hans-Werner Hilse 7da6dd28a5 handle Android app events in frontend/device code
Events have been passed to the frontend/device (or /input) code before.
Some of them have been handled in the FFI/input code, however. That
seems to be highly critical with regard to timing, though, so we just
let it enqueue the event for our code to process later. That way, a
mutex that locks the input event queue can be freed faster.
10 years ago
Hans-Werner Hilse 2775ade5d6 fix device:init() bug on Android platform 10 years ago
Hans-Werner Hilse 39d061fd3a pass device object to input FFI module
this is needed (for now) on Android, since the FFI module triggers
screen updates.
10 years ago
Hans-Werner Hilse 57a27f8f24 provide debug function to framebuffer ffi implementation 10 years ago
Hans-Werner Hilse 21ded080dd fix refactor bug: invalidate update_regions_func 10 years ago
Hans-Werner Hilse 8696ca1fa1 fix old (pre-refactor) refresh call syntax 10 years ago
Hans-Werner Hilse 22697adf20 switch from scaleByDPI() to scaleBySize() 10 years ago
Hans-Werner Hilse 63af71188a refactor refresh
Lots of the device-related distinction wandered into
base/ffi/framebuffer_<driver>. This eases the refresh logic in
UI manager, which basically only decides what kind of refresh
to trigger. The device specific configuration in the framebuffer
driver decides how to realize that whish.

screen.lua is gone, in its place is now the framebuffer driver.
The device abstraction decides what framebuffer driver to load.
10 years ago
HW 7b91935df0 Merge pull request #1230 from chrox/fix_1170
fix #1169 and #1170
10 years ago
chrox d11dba0558 fix #1169 and #1170 10 years ago
chrox 3574865dcb fix #1166 by auto alignment of option name 10 years ago
Hans-Werner Hilse f9f97163e8 wait for background thread before free()ing koptcontext
This should prevent freeing resources that are actually in use in
a background thread.
10 years ago
HW 9b5ff4ca41 Merge pull request #1224 from chrox/cover_60
add unit tests for readerdictionary and readerhighlight
10 years ago
Huang Xin 823147f8df Merge pull request #1225 from Frenzie/language
Refactored menu
10 years ago
Huang Xin b6f37debeb Merge pull request #1226 from Frenzie/filesearcher
Filesearcher: added notification for no results
10 years ago
Frans de Jonge 7c01a3f2a9 Fixed spaces stripped out by Transifex in readerui.lua by using util.template 10 years ago
Frans de Jonge da00b4b8a9 Refactored menu
While looking into #1219 I accidentally ended up refactoring some stuff.

Tested in emulator and on H2O, but be wary because I might have overlooked something.
10 years ago
chrox 566586619a add unit tests for readerdictionary and readerhighlight 10 years ago
Frans de Jonge 92f0092ad4 Filesearcher: added notification for no results 10 years ago
chrox dbf8faa9b1 remove hardcoded footer height of reader menu 10 years ago
chrox f52872b081 default autoscale for IconButton 10 years ago
chrox 8384eba810 consider also the screen size when scaling by DPI 10 years ago
chrox e66801039b refactoring: reuse IconButton for config menu bar 10 years ago
Frans de Jonge ab442c2434 gettext: unescape \n
Fixes the problem that any msgid with \n in it wouldn't show up translated.
10 years ago
Hans-Werner Hilse ab44d1f7e3 fix item number distinction (plural forms) 10 years ago
Frans de Jonge 8b9bbf918c Fix typo in #1176 10 years ago
Frans de Jonge d701d9b198 First util.template encapsulated strings 10 years ago
HW c9d6c02d04 Merge pull request #1203 from chrox/fix_1202
find the finest toc ticks by sorting out the largest one
10 years ago
NiLuJe e9573ebe58 Try to avoid more update_regions_func mismatches
scheduling tricks
10 years ago
NiLuJe f6753085ef Detect another KT2 model 10 years ago
NiLuJe 9bd089812b Tweaks and fixes for refresh logic
Don't increase counter for regional updates
Also some workarounds for Kobos

Try to avoid update_regions_func poisoning

Reset it at the end of repaint() even if nothing was found dirty

Ensure regional updates are always PARTIAL, in
case we get a region attached to an automatically triggered refresh, not
marked force_partial [which, hey, shouldn't happen, but apparently does
sometimes ^^]
10 years ago
chrox a65dcb4c0d find the finest toc ticks by sorting out the largest one 10 years ago
chrox 897358e09a add missing translation of 'Screensaver' options 10 years ago
chrox ee3c5525f9 add an option to show an arrow to indicate page overlap 10 years ago
HW c651816f4b Merge pull request #1195 from chrox/fix_1121
fix #1121
10 years ago
chrox 3e7ca5706e fix #1121 10 years ago
chrox b80dd1f966 add fulltext search for PDF documents 10 years ago
Hans-Werner Hilse 5af4ccb0c4 add support for GIF and PNG to picdocument provider
needs update to latest base
10 years ago
Hans-Werner Hilse bcf0a9923c (really?) fix refresh viewport calculations
This adds more documentation about the viewport offset calculations
for refreshing rotated viewports.

The old behaviour also was (still) buggy, even after the latest round
of fixes. Now, the offsets when rotated are hopefully calculated correct.
10 years ago
Huang Xin e54d2fec30 Merge pull request #1186 from Frenzie/filesearcher
Initial file search implementation
10 years ago
Hans-Werner Hilse 3d03713cb1 implement case-insensitive sort, make default and configurable
This will convert any file name to lowercase before doing the comparison.
Note that this will only work for ASCII character range, a full Unicode
aware solution will be much more complicated. And in the end, file names
are byte arrays, not character strings ;-)

fixes #1183.
10 years ago
Hans-Werner Hilse e031599c0a fix strcoll() workaround
The strcoll() workaround we had in place for Kobo devices was (or has
become) ineffective. We had set self.strcoll to nil on Kobo devices -
but this was the instance variable. Setting it to nil effectively makes
the instance variable vanish, so when trying to access it later, it
was not there and got looked up via the metatable - which had the original
reference. Setting it to nil had no effect whatsoever.

We simplify that approach and set the replacement function where before we
had set this to nil.

This is a partial fix for issue #1183 (and explains a comment in issue #686
which says that the old fix did not work).

However, to really fix #1183 - if we want to do so - we would need a collate
function that normalizes uppercase/lowercase before compare.
10 years ago
Hans-Werner Hilse 7e0b49edd1 fix dump() recursion detection
only detect recursions for table values.
10 years ago
Frans de Jonge 7a4b737ecd Changed "delete" in history to "remove this item from history" for clarity 10 years ago
Frans de Jonge 518c46033e Change "Search Books" to "Search books" for consistency with other search dialogs 10 years ago
Frans de Jonge 19029d1aab Comment out wasteful DEBUG statements 10 years ago
Frans de Jonge 06239fb9ec Initial file search implementation
See #1165.
10 years ago
Andrey Golovizin f785b29f34 Fix the viewport on Kobo Aura (phoenix). 10 years ago
Andrey Golovizin 50d9041c1d Use checked_func instead of remembering the checked item. 10 years ago
Andrey Golovizin a3e51b339d Show current font face in menu. 10 years ago
Andrey Golovizin c5122abb21 Show current hyphenation dictionary in menu. 10 years ago
Hans-Werner Hilse e8d576f99f fix bug in viewport offset calculation for refreshes
The calculation did not correctly calculate the offset in rotated
modes when the rotation was 90 or 270 degrees. Under these circumstances,
getWidth() and getHeight() did return rotated values for the framebuffer,
while Device.viewport did return not rotated values.
10 years ago
Andrey Golovizin 99eecde875 Use setStringProperty method to set hyphenation dictionary. 10 years ago
Huang Xin 7dbe940b71 Merge pull request #1174 from Frenzie/master
Various language-related fixes.
10 years ago
Frans de Jonge 90d3c23030 Enter *a* word to look up. 10 years ago
Frans de Jonge fcb59bfd30 Improved SetDefaults dialog message. 10 years ago
Frans de Jonge 26baa5e007 Added timeout to successful delete message. 10 years ago
Frans de Jonge 324d67a7a8 Various language-related fixes. 10 years ago
Hans-Werner Hilse 5b48c165b3 factor out dump() function, handle reference loops 10 years ago
Tigran Aivazian e5e50ed0f9 Fix 1169 by registering .txt.zip/.html.zip/.htm.zip formats 10 years ago
Hans-Werner Hilse 45cf927ee8 Fix double-check of task list
Since commit 12a76fee33, we had a potential
bug on the event mechanism:

It introduced (besides the checkTasks method itself) a second run of the
checkTasks() method. In the second run, however, scheduled events were
not taken into consideration in how long to wait for input events
afterwards.

So when the after the first run of checkTasks() there were new scheduled
tasks added to the task queue, they were not properly scheduled and
and depended on an already existing scheduled event or an input event
to trigger.

This might have led to unexpected order of execution (though the order
is not guaranteed by the task scheduling anyway!) or to events triggering
not at all until the next input event.
10 years ago
Hans-Werner Hilse c22dbbe3ae factor out repaint to its own method
it's gotten complex enough to isolate it
10 years ago
Frans de Jonge 81cb358775 Change rm invocation from rm -r to rm -rf
Fixes #941.
10 years ago
Frans de Jonge 5faff6331f "File to remove" DEBUG message was empty
You can't get the full file path of a file that no longer exists, obviously.
10 years ago
Frans de Jonge 886a9d8f8f File manager improvements: added delete confirmation dialog and success/failure message
This makes deleting files from within KOReader less scary and also provides the initial framework for handling different exit codes for #941.
10 years ago
Qingping Hou b0b02182ff Merge pull request #1160 from chrox/fix_1154
fix #1154
10 years ago
Qingping Hou 38cf53b426 Merge pull request #1159 from chrox/fix_1155
dismiss 'Opening file' dialog once reader view is ready
10 years ago
Qingping Hou 2cb23c9df6 Merge pull request #1153 from chrox/fix_1149
fix #1149 by adding 'Network setting' in filemanager
10 years ago