Commit Graph

61 Commits (a2dcfe9aec58f734e1285d1b6ac5a13271275b91)

Author SHA1 Message Date
Frans de Jonge a2dcfe9aec
[doc] Tag @todo, @fixme and @warning (#5244)
This commit standardizes the various todos around the code a bit in a manner recognized by LDoc.

Besides drawing more attention by being displayed in the developer docs, they're also extractable with LDoc on the command line:

```sh
ldoc --tags todo,fixme *.lua
```

However, whether that particular usage offers any advantage over other search tools is questionable at best.

* and some random beautification
5 years ago
Edoardo Putti 0906b69c06 [fix] Handle OPDS catalog responses accordingly (#5241)
- handle moved permanently HTTP 301
- handle authentication required HTTP 401
- handle authentication errors HTTP 403
- handle catalog not found HTTP 404
5 years ago
Frans de Jonge fca51757af
[fix] OPDS crash with fewer than 4 servers (#5092)
Regression introduced in <https://github.com/koreader/koreader/pull/4249>.

Fixes <https://github.com/koreader/koreader/issues/5091>.
5 years ago
Frans de Jonge 8815cbe07a
[fix, chore] Abstract filename logic in util.getSafeFilename() (#5026)
Fixes https://github.com/koreader/koreader/issues/5025

The OPDS browser was doing some fancier stuff in a way that should be abstracted away in util (because it applies anywhere files will be saved):

eace8d25c1/frontend/ui/widget/opdsbrowser.lua (L482-L491)
5 years ago
Frans de Jonge 22db71c075
[fix] OPDS last-modified check (#4874)
Fixes #4873. Unfortunately this will introduce a slight delay but I don't see any other quick & reasonable solution.
5 years ago
Sergey Avseyev 744316ea6f opds: add two more public servers (#4515) 5 years ago
Sergey Avseyev 3337e45381 opds: fix parsing OPDS from textos.info (#4514) 5 years ago
endofline 295cc55e03 [fix] ODPS: socket.http redirect, where the target is a different host (#4420)
Split https/http code-path (as socket.http can adjust the Authorization/Host headers automatically)
Warn the user when the protocol differs from http/https
5 years ago
Yann Muller 3fa2dad0b7 Fix for Internet Archive URL. 6 years ago
Yann Muller 030a02dfc4 Escape &, < and > when removing CDATA. 6 years ago
Yann Muller 9c251185eb Filter out CDATA. 6 years ago
Yann Muller 64d00b2969 [UX] Display the author in OPDS catalogs. (#4278) 6 years ago
Robert 6cf0a6473f OPDS - change url for Internet Archive (#4249) 6 years ago
Robert 9fda983001 Add OPDS authentication (#4248) 6 years ago
Robert a706fde2d7 Cleanup downloadmgr titles (#4222) 6 years ago
Robert 55dab14c71 Change title and button text in OPDS (#4155) 6 years ago
onde2rock e502bf04d3 [feat, UX] Support the virtualKeyboard on non touch-device (#3796)
* [VirtualKeyboard] Add support for keynaviguation

Also rename the variable "layout" to "keyboard_layout" because conflict
with the layout from the focusmanager

* Make the goto dialog compatible with key naviguation

My solution is to change the order of the widget. The last one will the
virtualkeybard so it catch all the keybinding, and below it, make the
dialog "is_always_active = true" so it can receive touch event.

* Correctly show the virtual keyboard on dpad devices

* change the order to call the virtualKeyboard so it end up on top

* Handle the multi input dialog

* Support reopening the virtualKeyboard by the Press key

* add check focusmanager

* Fix https://github.com/koreader/koreader/issues/3797

* MultiInputDialog : Now work on non touch-device

* Set the virtualkeyboard to be a modal widget

* Fix the layout in multiinputwidget

* Fix for the various combination of
hasKeys,hasDpad,isTouchDevice

* [Focusmanager] Better handling of malformed layout
6 years ago
Robert d201c04df7 OPDS - add confirm when file exist in local destination (#3605) 6 years ago
Frans de Jonge 3492b8b117 (minor, lang) improve text clarity for downloadmgr dialogs (#2897)
It's not necessarily clear that you need to long-press, see https://www.mobileread.com/forums/showpost.php?p=3520376&postcount=7
7 years ago
Qingping Hou 1922b2526b fix: normalize require path to reuse import result 7 years ago
Robert a3c4254809 Added util.fixUtf8 (#2704)
* Remove invalid UTF-8 chars from OPDS
* add unit tests
7 years ago
Qingping Hou ee0e337433 opds(fix): avoid infinite loop on paging 7 years ago
Robert 4f40250b88 Prompt users to turn on Wifi in Cloud Storage and OPDS Browser (#2650)
* prompt users to turn on Wifi in Cloud Storage and OPDS Browser
7 years ago
Robert dccbf4cf96 Fix crash when downloading books with unknown characters in title (#2628) 7 years ago
Adrian Sampaleanu fc5e8f1242 OPDS catalog: improve download dialog (#2445)
* Add action clarification to format download dialog

The format download dialog now has a title reflecting where a format will be downloaded with a prefix making it clear that choosing a format will download it.
7 years ago
Hzj_jie f91ad679d9 swithItemTable -> switchItemTable 7 years ago
Nick Savage 85585a0973 Fixed bug where only calibre OPDS catalogs would prompt to enable Wifi.
Tested on Kindle PW3. The error message my device threw was different from what was coded in OPDSBrowser.lua in getCatalog(). Perhaps we should test other devices and see if there are other error messages thrown as well.
7 years ago
Nick Savage ebb290f0ba OPDSCatalog: Normalize default and user-added catalogs
This patch makes the OPDS Browser treat the default catalogs (Project Gutenberg, Feedbooks, etc.) the same as a user-added catalog. This makes them removable and editable if the user so chooses.
7 years ago
Robert 7bfbc9f06a Sanitize filename for vfat, fix #2433 (#2464) 7 years ago
Qingping Hou f95ad00b9e feat: add logger module & rewrite kobo suspend script in lua 7 years ago
Qingping Hou 581039aed5 opds(fix): unescape name and value 8 years ago
Robert 171d40d287 feat: Would you like to read the downloaded book for OPDS (#2370) 8 years ago
robert00s 2cfce6f369 OPDS - fix opds catalog for Wolne Lektury 8 years ago
Qingping Hou 20eb36a03d feat: add network management UI for kobo 8 years ago
Frans de Jonge 5638819f25 Removed a bunch of "successfully", replaced an ellipsis, and some deviant spellings of KOReader. 8 years ago
Allan Nordhøy bc16ed5035 Spelling of calibre and KOReader. Ellipsis. 8 years ago
Qingping Hou 8f4fae7a09 minore: more static check fixes 8 years ago
Qingping Hou 4759def09c chore: fix static-check errors 9 years ago
Qingping Hou 46aed752c7 Merge pull request #1680 from erosennin/opds-title
OPDS: fix parsing entry titles on ManyBooks (and possible other sites)
9 years ago
Andrey Golovizin 63e0605080 OPDS: fix entry titles on ManyBooks 9 years ago
Andrey Golovizin dbac03e5f4 OPDS: include author's name into the file name 9 years ago
chrox b0df6d53e9 add Basic Authentication for OPDS catalog
use coroutine to support ad-hoc callback in login button so that when
the username/password is incorrect it will retry automatically
currently tested with COPS on apache

This should fix #1001.
9 years ago
chrox 5ec384efb5 fix #1593 cannot download from COPS OPDS server
and get rid of the ugly baseurl workaround for "Internet Archive",
actually the url building of all these catalogs is perfectly
handled with `url.absolute(base, relative)`.
9 years ago
Frans de Jonge 47d7a48555 OPDS: refactored unit test and fixed a minor bug with undefined image_rel 10 years ago
Frans de Jonge c25254a7ec OPDS: embryonic unit test for OPDS browser
This initial seed specifically tests against what recently broke in Gutenberg and FeedBooks.
10 years ago
Andrey Golovizin 296f63b22a OPDS: ignore links with unknown rel values, treat empty rel as rel="subsection". 10 years ago
Frans de Jonge 7a87b66fa1 OPDS catalog: auto-fill http:// if no protocol given and revert #1106
This fixes #1259.
10 years ago
Frans de Jonge 693fa0837e Reworked several strings
This is the remaining gruntwork of #1276. I believe that only leaves networkmgr.lua and filemanagersearch.lua, which will require a little more thought.
10 years ago
Andrey Golovizin 8bce54a6a0 Ignore OPDS links with unknown rel values. 10 years ago
Andrey Golovizin 5888773c95 Try to fetch next page if loading a new catalog resulted in a single page 10 years ago