2
0
mirror of https://github.com/koreader/koreader synced 2024-10-31 21:20:20 +00:00
Commit Graph

7186 Commits

Author SHA1 Message Date
Frans de Jonge
8815cbe07a
[fix, chore] Abstract filename logic in util.getSafeFilename() (#5026)
Fixes https://github.com/koreader/koreader/issues/5025

The OPDS browser was doing some fancier stuff in a way that should be abstracted away in util (because it applies anywhere files will be saved):

eace8d25c1/frontend/ui/widget/opdsbrowser.lua (L482-L491)
2019-05-14 19:10:41 +02:00
Frans de Jonge
de75f6bfa3
[fix] Don't try to save highlight into non-PDF document (#5027)
* [fix] Don't try to save highlight into non-PDF document

Fixes <https://github.com/koreader/koreader/issues/5024>.

Highlighting will still work with the .sdr metadata.

* temp fix
2019-05-14 17:57:59 +02:00
Frans de Jonge
5d7dbb4466
[UX] Update Greek keyboard with swipes & popup (#5028)
Closes #5023. Thanks to @noembryo.
2019-05-14 16:30:21 +02:00
poire-z
eace8d25c1 cre: fix possible crash when switching books too fast
Noticable with "End of document action > Open next file",
and holding PgDn in a directory full of single page html
files.
2019-05-09 22:14:13 +02:00
poire-z
eaeb3ec97f bump crengine: cache and text fixes, use utf8proc
Bump crengine:
- Ensure text decoration (underline) is continued over word gaps
- Invalidate TOC page numbers on rendering change
- Ensure reproducible cache files when same rendering settings
- LVBlockWriteStream: workaround to exclude fatal error
- Use utf8proc for string uppercase/lowercase/capitalize

Bump base:
Thirdparty: adds utf8proc 2.3.0 (libutf8proc.so.2)
For use by crengine, for now mostly for more complete and
accurate text-transform: uppercase/lowercase/capitalize.

Also revert test tweak (in 27ddd6f) to workaround an issue with
cre cache that should be solved by this crengine bump.
2019-05-09 22:14:13 +02:00
Sergey Avseyev
f6e561923c newsdownloader: rebuild URL on redirect to bare path (#5012)
The server might redirect to only path, in this case the scheme and host
should be taken from original URL
2019-05-08 12:41:04 +02:00
Frans de Jonge
2968f558eb
[fix, UX] Ignore first hold release when keyboard opened with hold (#5011)
Fixes #4902.
2019-05-08 10:13:44 +02:00
Frans de Jonge
1b24582a08
bump base for slight Makefile change (#5007)
Cf. #4830
2019-05-08 08:49:02 +02:00
Tom Hall
0636ab7c79 NewsDownloader: Skip re-downloading files which already exist (#5008)
Fixes #5005

Results from re-running "Download news" should be as before, except when the
article content has changed between runs, but the title has not and an updated
date has not been given in the feed. User can force it to re-download an
article by manually deleting the file then running "Download news".
2019-05-08 08:05:47 +02:00
Vani Ramakrishnan
08fa5e2f17 Info message typo fix (#5003)
"succesfully" => "successfully"
2019-05-06 09:31:11 +02:00
NiLuJe
4ba7f984bf Sync powerd.fl brightness with powerd when toggling the FL (#4999)
Possibly helps with some more edge cases related to interaction with
autowarmth & the KA1...

re: #4925
2019-05-05 22:08:53 +02:00
poire-z
7c53fcd922 CRe margins: hide bottom menu on change (#5000)
So we can immediately see how's the bottom margin.
2019-05-05 10:15:13 +02:00
BloodRagg
3009f5ae54 Kobo only mounts in /mnt/, set filter in case user uses some custom mount points (#4981)
Normally only mmcblk* stuff (internal/external) will get mounted to /mnt/onboard or /mnt/sdcard, but it can sometimes be useful, see: https://github.com/koreader/koreader/pull/4981#issuecomment-487670972
2019-05-03 20:38:00 +02:00
NiLuJe
f3decdc26c [fix] Restore PAGE_MARGIN string (#4993)
It's used by KOptConfig

Fix #4992
Regression since #4945
2019-05-02 19:06:57 +02:00
NiLuJe
aec7594af5
Blacklist the C BB on devices where it cannot be used (#4989)
Either at all, or because it would impose reduced functionality.

Meaning:
* On 4bpp fb, because those are completely unsupported by the C BB
* On 24bpp fb, because it has limited support for that target format (no alpha blending).
* On 8bpp Linux eInk fb with an inverted palette (that's basically only the K4 ;)).
* On Linux eInk devices w/ no HW inversion support, as that would render NightMode inoperable.

That last point means that it's currently *always* blacklisted on PocketBook, because I don't have a PB device, so I don't know how safe HW inversion would be, meaning none of them are marked as being HW invert capable.

(I was a tiny bit hasty with https://github.com/koreader/koreader-base/pull/912 ;).)
2019-05-02 04:27:48 +02:00
poire-z
bf07c44009
CRe margins: add toggle to sync top and bottom margins (#4990)
Also fix DogEar size update on margin change.
Also re-order cre bottom tabs to be like with kopt.
2019-05-01 22:18:50 +02:00
Frans de Jonge
4515a36059
[Android] Bump luajit-launcher for SurfaceView hack (#4991)
See https://github.com/koreader/android-luajit-launcher/pull/143

References https://github.com/koreader/koreader/issues/3517#issuecomment-485347562
2019-05-01 21:02:50 +02:00
NiLuJe
4c14ef737e
Bump base (#4988)
Mainly for the switch to the C BB by default on Kobo/Kindle/PB

But also includes:

CI tweaks: https://github.com/koreader/koreader-base/pull/907
           https://github.com/koreader/koreader-base/pull/911
DjVu tweaks: https://github.com/koreader/koreader-base/pull/909
SDL2 tweaks: https://github.com/koreader/koreader-base/pull/910
2019-05-01 02:53:02 +02:00
NiLuJe
888d3591b2
Give more control over CRe margins (#4945)
Without having to resort to weird custom defaults.

* Split the current margins setting in three:
  * Horizontal margins (because you generally want those two to be balanced).
  * Top margin & Bottom margin (because you may want to tweak those separately to deal with quirky status bar/final line shenanigans).

* Also, add a "Reclaim bar height from bottom margin" toggle to the status bar menu, to optionally make sure the status bar won't eat into the bottom margin.

* Includes a free fix to diacritics popup refresh handling in the keyboard ;).
2019-05-01 02:09:01 +02:00
Tom Hall
9b41adb2f1 NewsDownloader: Fix UI when downloading multiple feeds (#4987)
Wrap the whole of loadConfigAndProcessFeeds with Trapper:wrap so that feeds are downloaded sequentially, otherwise they become interleaved and the UI progress updates get confusing. Use Trapper:info in place of manually constructed InfoMessages.
2019-05-01 00:37:03 +02:00
Tom Hall
8e23d2a937 NewsDownloader: Process articles sequentially
Lift the Trapper:wrap call out of the individual article processing code,
so that articles are processed one by one, in order to:
* Avoid concurrent progress updates fighting over the UI dialog
* Avoid trying to download many images at the same time
2019-04-30 21:03:48 +02:00
Tom Hall
cad4d25d24 NewsDownloader: Add flag 'include_images' to feed config
Allow the user to specify whether to download images for each individual
feed specified in feed_config.lua. Default to false to stay closest to
existing behaviour.
2019-04-30 21:03:48 +02:00
Tom Hall
1588d4c64a NewsDownloader: Download images and output EPUBs
Initial commit of new NewsDownloader which downloads images as well as text
and packs it all into an epub.

Based on Wikipedia "Download as EPUB" code.
2019-04-30 21:03:48 +02:00
Frans de Jonge
96179670f8
[fix] Close calibre search when opening document (#4978)
Fixes https://github.com/koreader/koreader/issues/4225.
2019-04-28 20:10:41 +02:00
Frans de Jonge
5690998124
kodev: pass correct --lpath for base test (#4973) 2019-04-27 12:24:42 +02:00
Frans de Jonge
3f670baaa2
[UX] Keyboard popup: add X (#4977) 2019-04-27 09:04:48 +02:00
Frans de Jonge
65d72d0244
[CI] CircleCI: save test results (#4974)
It should be a path to a directory, not a file.

https://circleci.com/docs/2.0/configuration-reference/#store_test_results

> Path (absolute, or relative to your working_directory) to directory containing subdirectories of JUnit XML or Cucumber JSON test metadata files

Perhaps the file needs to be named results.xml. We'll see.
2019-04-26 13:57:09 +02:00
Frans de Jonge
27ddd6f313
[spec] Better insulation (#4972)
Some combination of Travis and/or older Busted necessitated insufficient insulation.

Follow-up to https://github.com/koreader/koreader/pull/4970

Space condensing carried over; reset at the start of readertoc.
2019-04-25 23:33:47 +02:00
Frans de Jonge
4dc116ed6a
[fix, spec] re-enable ReaderView tests (#4970)
It's not clear to me where the value is set as expected when running all tests linearly because it doesn't seem to be ReaderFooter.
2019-04-25 17:44:03 +02:00
Frans de Jonge
e869041632
[chore] kodev: make kodev test consistent with build & run (#4969) 2019-04-25 17:40:42 +02:00
Qingping Hou
080c079d01 chore: add test for screen color toggle 2019-04-24 21:09:23 +02:00
Qingping Hou
11a38b33f1 kodev: stop test command if build failed 2019-04-24 21:09:23 +02:00
Frans de Jonge
c0ba6ae48e
[CI] Bump busted to v2.0.rc13-0 (#4966)
Includes https://github.com/koreader/koreader-base/pull/906

Cf. https://github.com/koreader/koreader-base/issues/905
2019-04-23 09:29:39 +02:00
Frans de Jonge
2c6cc258a2
bump luajit-launcher to fix Android build (for real) (#4965)
* Fix LuaJIT build after the recent buildsystem tweaks https://github.com/koreader/android-luajit-launcher/pull/142
2019-04-22 21:49:04 +02:00
Frans de Jonge
8023af0b54
bump base (#4964)
* Don't disable exp2 & log2 in LuaJIT https://github.com/koreader/koreader-base/pull/902
* fix incorrect merge with master from https://github.com/koreader/koreader-base/pull/843 https://github.com/koreader/koreader-base/pull/901
2019-04-22 21:48:43 +02:00
Frans de Jonge
3568c86584
bump base for SDL_FULLSCREEN fix & simplified DPI handling (#4963)
* [fix] ffi/SDL2: crash with `SDL_FULLSCREEN` https://github.com/koreader/koreader-base/pull/900
* simplify framebuffer dpi handling https://github.com/koreader/koreader-base/pull/843
2019-04-22 17:51:11 +02:00
Frans de Jonge
5c95597f0a
README: remove Ubuntu Touch and add screenshot (#4959)
The Ubuntu Touch build has been broken for three years and since I have no way to test I can't fix it.

References #4904.
2019-04-22 15:58:07 +02:00
Frans de Jonge
f38918a6f2
[Ubuntu Touch] Strip OTA update code (#4962)
It distracts the developers. ;-)
2019-04-22 15:48:40 +02:00
Frans de Jonge
7d742e156a
[Android] Bump luajit-launcher to fix build (#4957)
* [fix] Add LuaJIT patch to sync with koreader-base https://github.com/koreader/android-luajit-launcher/pull/141

A bit of an emergency fix to just get it working ASAP. A patch was added to base LuaJIT in https://github.com/koreader/koreader-base/pull/892, which caused a mismatch and build failures over here. Unfortunately that was hidden by some excessive Android verbosity inadvertently introduced in https://github.com/koreader/koreader-base/pull/888, and on my local instance where I did a sanity check LuaJIT was already compiled…
2019-04-22 10:16:59 +02:00
Frans de Jonge
c9d0fc36cb
bump base for Clang fix (#4955)
https://github.com/koreader/koreader-base/pull/897
2019-04-21 23:02:01 +02:00
NiLuJe
d9ab5d2f43 Make sure the AutoWarmth feature will never try to turn the light back (#4953)
on if it's off.
Because, on the KA1, since wetting the warmth *has* to set the
brightness, it could ;).

Patch only actually needed on Kobo, as all Cervantes devices with warmth
support have a mixer, which mean they *can* set the warmth without
affecting the brightness ;).
2019-04-21 20:46:29 +02:00
Frans de Jonge
8f0a3dda7a
bump base for silent iconv & gettext build (#4954)
Otherwise Travis CI and GitLab CI have log length issues on Android.

https://github.com/koreader/koreader-base/pull/898
2019-04-21 20:45:31 +02:00
Frans de Jonge
ff843e0eb7 [i18n] Change user-facing floating punctuation text to hanging punctuation
See https://www.mobileread.com/forums/showthread.php?t=316787
2019-04-20 19:47:31 -07:00
Frans de Jonge
4782f5ffc1
[UX] Keyboard popup: add = (#4950)
As suggested by @Biep in https://github.com/koreader/koreader/pull/4889#issuecomment-485158316
2019-04-20 23:36:52 +02:00
Frans de Jonge
c092979848
bump base to bump some dependencies (#4948)
https://github.com/koreader/koreader-base/pull/896
* Bump HarfBuzz to 2.4.0
* Bump K2pdfopt to pickup the CJK thingy
* Bump libpng to 1.6.37
* Bump FBInk to 1.15.0

[fix, build] Don't fail quietly on patching failure https://github.com/koreader/koreader-base/pull/895
2019-04-20 15:21:34 +02:00
Frans de Jonge
5d3c45a96b
[Ubuntu Touch] Minor updates (#4947)
Cf. https://github.com/koreader/koreader/issues/4361#issuecomment-484959506 and https://github.com/koreader/koreader/pull/4946
2019-04-20 14:28:34 +02:00
Frans de Jonge
4371422898
[fix, Ubuntu Touch] Actually bundle libSDL2.so! (#4946)
Accidentally broken in https://github.com/koreader/koreader/pull/2132.
2019-04-19 22:14:59 +02:00
Frans de Jonge
837e9d85cb
[fix] plugins/send2ebook: crash on setting download dir (#4944)
Also fix weird indentation.

Reported on the forum: https://www.mobileread.com/forums/showthread.php?p=3833021#post3833021
2019-04-19 20:51:41 +02:00
Frans de Jonge
ab4d7ee4e1
bump base for Android OpenSSL fix & pixel density (#4943)
* scale density independent pixel by 160 instead of 167 https://github.com/koreader/koreader-base/pull/885
* [fix, Android] Versioned OpenSSL libs https://github.com/koreader/koreader-base/pull/894
2019-04-19 18:35:53 +02:00
Frans de Jonge
b5b4b0dcfd
Bump base for correctly MuPDF library linking (#4941)
https://github.com/koreader/koreader-base/pull/892
2019-04-19 14:28:27 +02:00