Commit Graph

739 Commits (53f083f51669f2768995fb532a5224f0bf01a525)

Author SHA1 Message Date
Frans de Jonge 1c25d0fd1b Language: improve confirmboxes
Generic "OK" buttons should be avoided. Thanks to @lightonflux for pointing this out https://github.com/koreader/koreader/issues/2555#issuecomment-291039945
7 years ago
Frans de Jonge b076ca1c29 ReaderFooter: fix quick browsing by tapping footer in flipping mode
Fixes #2649.
7 years ago
Robert 3f0ce5de34 Remove invalid UTF8 chars from FTP (cloud storage) and sort order of requires (#2711) 7 years ago
Frans de Jonge e5a3ecd3e5 CreDocument: disable fancy formatting by default
It does significantly more harm than good. It can be reenabled with a `txt_preformatted` setting if desired. Fixes #1607.
7 years ago
Hzj_jie ea2de9638b LuaSettings:wrap() / LuaSettings:child() function to create an LuaSettings to represent a sub table of an existing one (#2685) 7 years ago
Frans de Jonge bdbda9b405 ReaderMenu: fix MenuSorter-related typo (#2689)
Fixes #2688
7 years ago
Frans de Jonge 791d540a5a FileSearcher: filter .sdr directories
Fixes #2665
7 years ago
Frans de Jonge 8b7e18a7d7 MenuSorter: resolve review comments
* simplify user config loop
* simplify unit test for Travis memory use
* remove unused util variable
7 years ago
Frans de Jonge ddf590eb6d MenuSorter: split out menu order configuration 7 years ago
Frans de Jonge a970a1f034 MenuSorter: fix outside testability (for potential unit tests) 7 years ago
Frans de Jonge 8f31a81601 MenuSorter: some documentation
MenuSorter: forgot to add plugin style change

MenuSorter: worked out the final quirks

* Menu always compressed into tables without missing indexes for ipairs compatibility
* Orphans attached
* Separators no longer count as items
7 years ago
Frans de Jonge b7b5950e98 MenuSorter: review comments and various bug fixes
* fixed wrongful retention of submenus variable and added return to MenuSorter:findById
* fixed readerfooter_spec.lua error
* fixed review comments
7 years ago
Frans de Jonge aa0bf60ccb MenuSorter: pass config prefix for proper user override 7 years ago
Frans de Jonge 5b20106db7 MenuSorter: initial implementation
* Menus are now sanely configurable
* Custom separator placement for clearer menus
7 years ago
robert00s f2f0c376fa Minor Reader Fronlight modyfication 7 years ago
Qingping Hou 00cf81febc readercopt(fix): set view mode after reader is ready
Otherwise, self.xpointer might still be nil in
ReaderRolling:onChangeViewMode
7 years ago
robert00s a2bfc3858d changes after comments 7 years ago
robert00s 4479d686a0 Refresh status bar after resume 7 years ago
Qingping Hou a943b73303 fix: adjust pan rate for eink and non-eink screens 7 years ago
Qingping Hou fc12ee6537 decouple reader footer from dictquicklookup widget & translation fix (#2664)
* chore: fix strings for translations

* dictionary(chore): decouple reader footer from dictquicklookup widget
7 years ago
poire-z 39d1afe37d Update footer when refreshing screen with diagonal swipe
And added diagonal swipe support to readerrolling.
7 years ago
Robert 4f40250b88 Prompt users to turn on Wifi in Cloud Storage and OPDS Browser (#2650)
* prompt users to turn on Wifi in Cloud Storage and OPDS Browser
7 years ago
poire-z 4316284260 Footer: added "memory usage" item
Helps following KOReader memory usage (and memory leaks).
7 years ago
robert00s e07db0e7a0 Grayed out Open last document 7 years ago
Frans de Jonge d1785e1863 Reorganize menus
* Replace "home" (exit) menu with hamburger
* Discard pokeball and put items in hamburger
* Introduce search menu in reader

Cf. #2562
7 years ago
Frans de Jonge 0566df5f28 FileSearcher: also show directory results
Fixes #2177
7 years ago
Frans de Jonge da3ff5e336 History: add 'autoremove_deleted_items_from_history' setting 7 years ago
Frans de Jonge 2c80ff7d7b FileManagerHistory: remove harmful deletion code and turn it into a feature
Fixes the problem introduced in 51327911f2 and turns it into a feature that should fix #2477
7 years ago
Frans de Jonge 6458c8e9eb File Manager: rename to "KOReader File Browser" and add up arrow to ".."
This should make it clearer to new users what's going on. Fixes #2529.
7 years ago
Frans de Jonge fed22b509d FileManager: rename hasSidecarDir to hasSidecarFile
Fixes #2550

Cf. b502047635
7 years ago
Zijie He 4f1cabcdbc Improve several outputs 7 years ago
Hzj_jie 726b15ad01 More sorting orders in file manager (#2535) 7 years ago
Zijie He faaca028e7 Remove empty sidecar folder 7 years ago
Zijie He b502047635 Removing metadata file instead of purging .sdr folder 7 years ago
Frans de Jonge 3ea18208d7 Removed deprecated Confirmbox option cancel_on_tap_outside = true 7 years ago
Frans de Jonge 67a6eb271d Language: Would you like to read this Wikipedia %1 article?
Discussion on https://www.transifex.com/houqp/koreader/translate/#nb_NO/koreader/106518021

@Frenzie Second option is I came to too. Very consistent and nice.
by kingu, 6 minutes ago

Let's see, I'm not entirely happy with the phrase. Here are a couple of brainstorms.

Would you like to read the full version of this Wikipedia EN article?

Would you like to read this Wikipedia EN article?
by Frenzie, an hour ago

@kingu It's the language code, such as EN, FR, etc.

http://imgur.com/u1q6tT4l.png
by Frenzie, an hour ago

ISSUE
What is %1 here?
by kingu, 3 days ago
7 years ago
Hzj_jie f91ad679d9 swithItemTable -> switchItemTable 7 years ago
Qingping Hou 9b7aba3fba fix: override readerhighlight hold in readerfooter
Also fix touch zone dependency graph generation code.

ReaderHighlight has now been migrated to use touch zone

Inputcontainer's touch event handling logic changed to only stop
propagation when handler returns `true`. Previously, it stops
propagation when a handler is found. This is needed to support
both readerhighlight_tap and tap_forward touch zones.
8 years ago
Frans de Jonge 399190c520 Merge pull request #2508 from NickSavage/master
OPDS: Fixed Wifi prompt and enabled removing default catalogs.
8 years ago
poire-z 2ded2bce5e Wikipedia: save full page as epub (html, with optional images)
Also for the current text-only wikipedia full page: replace
the ==s in section titles with some unicode symbols for a better
visual feeling of hierarchy. These same symbols are also used
in the .epub.
Both can be disabled by adding ["wikipedia_prettify"] = false
to settings.reader.lua

readerhighlight: close ButtonTable (like other buttons do) when looking
up wikipedia, otherwise if we save as epub, and swtich to new document,
this ButtonTable will never be closed and stays in UI.
8 years ago
Nick Savage ebb290f0ba OPDSCatalog: Normalize default and user-added catalogs
This patch makes the OPDS Browser treat the default catalogs (Project Gutenberg, Feedbooks, etc.) the same as a user-added catalog. This makes them removable and editable if the user so chooses.
8 years ago
poire-z 97d34c5bb0 Better handling of tap on invalid/external links
Tap on external urls or invalid links would jump to
document's 1st page. We check first the validity of the
link, and deal with wikipedia links or just show the external
url.
ConfirmBox: allow dismissing/cancelling by taping outside,
to keep UX consistent.
8 years ago
poire-z ee06171c83 New ImageViewer widget + hold on image show it fullscreen
Simple image viewer with Best Fit/Original size and Rotate
(for landscape images) buttons.
readerhighlight: check if hold is on an image to show it
fullscrren
8 years ago
robert00s fe5379814d Ask for connection when clicking on Wikipedia 8 years ago
poire-z 130f7b0773 wikipedia: fix languages rotation and query
Fix innacurate language query and rotation when back from nested lookups.
More informative lookup message (langage used, search or full page)
Allow for screen refresh with diagonal swipe (like in readerpaging).
8 years ago
poire-z 5012fb79d3 Set hyphenation dict fallback with Hold
For documents without language defined in metadata (.txt, .html),
crengine would fallback to hardcoded English_US_hyphen_(Alan).pdb.
This allows for setting a different one.
8 years ago
Qingping Hou f95ad00b9e feat: add logger module & rewrite kobo suspend script in lua 8 years ago
Hzj_jie 5bda44473d Add dictionary to filemanager 8 years ago
Qingping Hou d16688c43c feat: show full menu on menu key for touch devices 8 years ago
Robert 31218fa79e Skim to widget (New Go to page/location widget ) (#2460) 8 years ago
Qingping Hou ead5dfd9b4 readerview(feat): add registerViewModule method 8 years ago
Qingping Hou dc2746f1d7 chore: various minor cleanups 8 years ago
Robert 957e8ce768 Add open last book menu item in file manager (#2450) 8 years ago
Frans de Jonge 4f64ac4b69 Minor language fixes
Unsubscribe from was suggested by Allan Nordhøy (kingu) on Transifex.
8 years ago
robert00s ae9261b685 Fix #2440 8 years ago
Robert 187598deb2 Cloud storage - dropbox and ftp integration (#2424) 8 years ago
Hzj_jie c662ca4cc8 Load plugins also in FileManager (#2426)
added is_doc_only plugin attribute
8 years ago
Qingping Hou d2743b6f15 fix: migrate readermenu to use touch zone 8 years ago
Qingping Hou 070be5bfb1 fix: migrate readerrolling to touch zones 8 years ago
poire-z fe56ecd301 Clear readers' cache: invalidate in-memory references
This avoids crash on exit after clearing caches.
8 years ago
retrue eae730d140 Some uppercase fixes (#2421) 8 years ago
poire-z 1708fd5e1c Dictionary and wikipedia enhancements (#2393)
Stardict:
- remove duplicate results
- better cleaning of selection
- append results from a 2nd query of a 2nd set of dictionaries
  in data/dict_ext/

Wikipedia:
- use the search API for better results
- allow viewing the full page content of a result in a bigger window
- allow queries for multiple languages
- available languages can be set in settings.reader.lua :
    ["wikipedia_languages"] = {"en", "fr", "it"}
- "Wikipedia lookup" added to Tools menu

For both:
- allow selection of multiple words for a new lookup (so one can
  actually browse wikipedia)
- allow continuous reading with Tap
- display "current result / total number of results"

Details in #2393
8 years ago
Qingping Hou a6c506dc10 kobolight(refactor): move into plugin & only enable for kobo 8 years ago
Qingping Hou 0c49b915de refactor: add touch zone subsystem to inputcontainer
Touch zone decouples screen size from gesture event registration.

The win here is each individual widget does not need to update
gesture range on screen rotate/resize anymore.

Another advantage is we now have a centralized ordered array to handle
all registered touch event listeners, makes it much easier to resolve
gesture range conflicts between multiple widgets.

This patch also includes the following changes:

* migrate readerpaging to use readerui's touch zone
* migrate readerfooter to use readerui's touch zone
* move inverse read direction setting to touch menu's setting tab
* moved kobolight widget from readerview into readerui
* various dead code cleanups and comments
8 years ago
Qingping Hou 8799b4b6b1 doc: geometry module 8 years ago
Robert 93e075feb6 Adding the buttondialogtitle widget and show long filename in filemanager (#2414) 8 years ago
Robert 7e1c0c15c6 Refresh filemanager after exit from OPDS browser (#2405) 8 years ago
poire-z ca59efc5b6 FileManager Menu: added "Developer options" (#2391)
and "Clear readers' caches" subitem.
8 years ago
poire-z 949e5ba54d FileManager: added button to purge sidecar directory (#2391)
Also move its sidecar directory when moving a file.
8 years ago
poire-z efd6c7f556 Added "Swipe to follow first link" option (#2392)
Allow swipe west to jump to current page's first link (easier than clicking on small links)
Also fixed existing function names to comply with style guide.
8 years ago
poire-z 2c01f3add9 Fix: dog ears disappearance when switching fonts (#2394)
or switching orientation, or some other page layout setting.
Reverted commit a049edd, which should be done better (see #2395).
8 years ago
poire-z bbba2799a5 Fix: unexpendable TOC in some cases (#2394)
When on a page in a 2nd level section, after switching orientation,
TOC was stuck with the section we're in unexpandable.
8 years ago
Robert 64a79f6892 Frontlight progress bar (#2385) 8 years ago
Sergey Organov 3800a3077a DictQuickLookup:update(): strip all leading empty lines/spaces
This gets rid of sometimes huge spacing between a word and its
description taken from dictionary, and thus need for scrolling just to
read fisrs few lines of description.
8 years ago
Robert 171d40d287 feat: Would you like to read the downloaded book for OPDS (#2370) 8 years ago
Huang Xin b16a33a232 Merge pull request #2375 from koreader/houqp-master
readerpaging(fix): handle edge cases where paging pan will crash the reader
8 years ago
Dimitrios Semitsoglou-Tsiapos b87ce7fe12 footer: update when toggling markers 8 years ago
Qingping Hou 8e76ed4f0b fix: flush reader setting on change from filemanagermenu 8 years ago
Qingping Hou cd24eb82d7 readerpaging(fix): handle edge cases where paging pan will crash the reader 8 years ago
Bastien Dejean cffb21f7be Add new setting: auto_book_status
Fixes #2363.
8 years ago
Qingping Hou 88ab21c62c minor: change setting names for home_dir_name 8 years ago
Bastien Dejean b3d58fba00 Don't try to set the value of fm_screen_mode
I'm not sure what the original intention was, but in practice, the user
experience regarding the way this setting is saved is horrible: it seems
to change randomly and once the orientation is changed from portrait to
landscape, the only way to fix it is to edit `settings.reader.lua`.
8 years ago
Bastien Dejean 58b6c94a8d Generalize and consolidate tildify
- Don't do any substitution unless `home_dir_name` exists.

- Don't rely on `gsub` because it might interpret some characters in
  `home_dir` as magical (and might also replace a match not starting at
  the beginning of `path`).
8 years ago
Bastien Dejean 283a113aaa Handle corner case in tildify 8 years ago
Bastien Dejean 2f5935411a Replace the home dir by ~ in the FM's current path
This mirrors the well known shell convention and release the user from
a needlessly verbose description of the current path.
8 years ago
Bastien Dejean 83f18d6d77 Properly spell the title of the file manager
Us humans can handle spaces in titles.
8 years ago
robert00s 09f2db3729 Fix long filename text in history textbox (#2322)
Fix long filename text in history textbox
8 years ago
Bastien Dejean 41764e23e8 Make page gap configurable 8 years ago
Qingping Hou 558754e9b5 footer(refactor): various bug fixes and optimizations 8 years ago
robert00s 886e2d6cb1 display document metadata (#2307)
display document metadata in file manager and history menu
8 years ago
robert00s 683b0381bf Patch for wikipedia language (#2304)
* smarter language detection for wikipedia

new order:
* check language for document
* check global language setting
* check language for lookup phrase

Fix: https://github.com/koreader/koreader/issues/1844
8 years ago
ycrichard c3aa5fa0d9 allow disable highlight by default
minor code change

typo
8 years ago
ycrichard f3149b0b2c add frontlight information in the footer including context menu 8 years ago
Qingping Hou 31d22dfc17 fix(kobofrontligh): initialize dimen with nil value 8 years ago
Qingping Hou 67ae10742a defaults: try parse int from user input 8 years ago
ycrichard 17e9a8e45b add kobo frontlight gesture (#2284)
* add kobo frontlight gesture
8 years ago
Qingping Hou abbb72b6d3 readerrolling(fix): do not emit PageUpdate event until document is ready 8 years ago
Qingping Hou 404702914e minor: adjust wording for fallback font setting based on Frenzie's suggestion 8 years ago
Qingping Hou d6c48b06f9 chore: fix all luacheck issues 8 years ago
Qingping Hou 252100891f fix(defaults): override defaults with persistent defaults for advanced setting menu 8 years ago
Qingping Hou ca21ab4be5 fix(defaults): type casting for user input 8 years ago
Qingping Hou c619de324e chore: more luacheck fixes 8 years ago
chrox 166aa52a24 move painting and drawing debug log to verbose 8 years ago
chrox 9ab005a1d3 fix unit test of readerlink and readerpaging
and have more confidence with the unit testing framework.

Now `make testfront` won't retry on failure and testing files are
ordered in each run so that it's possible to reproduce testing failure.

And this patch also fix flush settings not working before suspend issue:
at some point the `FlushSettings` event is sent to `UIManager` instead
of `ReaderUI`, but `UIManager` only delegated events to active widgets
and `ReaderUI` is actually not an active widgets thus will miss the event.

This patch also add a verbose debug mode with "-v" as a switch to turn
on this mode. With verbose mode on, event handling will be logged.
8 years ago
chrox 2fa8ebb7c4 don't consume swipe gesture event in readerlink
if location stack is empty
8 years ago
Qingping Hou ec6da5318c screensaver(fix): add back menu toggle to support screensaver folder 8 years ago
Hzj_jie 3df363165a Fix crash in readertoc.lua
This issue has been mentioned in https://github.com/koreader/koreader/issues/2186.
8 years ago
Qingping Hou 1c5543358c readerfooter(fix): avoid setting mini footer to invisible when full progress bar is on
Our previous assumption is user will only choose between full or min
bar. The does not hold anymore as many more info has been added to the
mini bar and sometimes user might want to have both of them on. This
patch makes the reader behavior consistent when both bars are set to be
on for a document.
8 years ago
Hzj_jie 7493fc89f6 Add removed item name in "Remove this item from history" and fix wrong items deleted issue. (#2164)
* Add removed item name in "Remove this item from history".

* Fix #2162, wrong history items deleted.
8 years ago
Qingping Hou f30e487959 readerpaging(fix): set the corrent page number on GoBackLink event 8 years ago
Qingping Hou 0d9fc17d7c chore: rename SetDefaults:SaveSettings 8 years ago
chrox 1d887f4fe1 book reading statistics for djvu documents 8 years ago
Hzj_jie d4c31d683f Add a setting to disable save document (#2138)
* Add a setting to disable save document
* Add UI elements to control save-document settings
8 years ago
Huang Xin 014abf21bc Merge pull request #2153 from houqp/houqp-master
reader(fix): fix crash when DAUTO_SAVE_PAGING_COUNT is set to 0
8 years ago
Qingping Hou 4cdafedcc8 Merge pull request #2147 from koreader/houqp-master
move setDirty call from TextWidget:setText to FileManager
8 years ago
Qingping Hou 726259f5a1 reader(fix): fix crash when DAUTO_SAVE_PAGING_COUNT is set to 0
* setup autoSaveSettings callback on ReaderReady event
* delay calling autoSaveSettings with UIManager:nextTick
8 years ago
Huang Xin b8f23d162d filemanager(fix): refresh banner in filemanager insteand of TextWidget 8 years ago
Qingping Hou 304b0f218e chore: fix some of the luacheck errors 8 years ago
Qingping Hou a10a4f65a5 minor: use predefined color instead of gray method 8 years ago
NiLuJe 207af74527 Support the White Kindle PW3 & the Kindle Oasis.
Also attempts to support the new Kindle Basic, pending confirmation.
8 years ago
Hzj_jie 400e63a463 Resolve review comments 8 years ago
Hzj_jie 493ff00609 Add path in file manager 8 years ago
chrox 1c5c7d3a7c fix #1682 by closing all dict windows when holding close icon 8 years ago
chrox 551857ce6e fix some luacheck warnings 8 years ago
chrox 03fda94562 fix #2110 by adding disable double tap option in screen options 8 years ago
Qingping Hou fadad90447 uimanager(fix): handle stack change in close 8 years ago
Frans de Jonge 97925df40a Merge pull request #2086 from chrox/fix_2084
fix #2084 introduced by copy and paste in #2079
8 years ago
chrox ad88192d85 fix #2054 by removing ticks max limitation 8 years ago
chrox 0ca82fb072 fix #2084 introduced by copy and paste in #2079 8 years ago
Qingping Hou cf3c91d92e Merge pull request #2079 from Hzj-jie/master
ReaderZooming should remove the size of page footer when calculating zoom value
8 years ago
Qingping Hou fe6aaca47d Merge pull request #2083 from chrox/fix_2060
fix #2060 by handling blank search pattern
8 years ago
chrox 5bbcae954e fix #2060 by handling blank search pattern 8 years ago
chrox 5983050d79 PDF free zoom mode revisit
this should implement feature request of zoom mode for multi-columns
page in #501
This PR depends on koreader/koreader-base#435

How to use?
1. Tap the top left corner of a PDF/Djvu page to get into the flipping
mode
2. Double-tap on text block will zoom in to that column
3. Double-tap on any area will zoom out to an overview of the page
4. repeat step 2 to focus to another page block

How does it work?
1. We first find the mask of text blocks in the page. (Pic 1)
2. Then we intersect page boxes with user tap to form a page block. (Pic 2)
3. Finally we zoom the page to the page block and center current view to
that block. (Pic 3)
8 years ago
Zijie He ac6ccc0038 ReaderZooming should remove the size of page footer when calculating zoom value. 8 years ago
chihyang a948ecb19a Add 'read from right to left' in readerrolling
- Fix problems in readerpaging.lua;
- Add the same feature in readerrolling.lua.
8 years ago
chihyang c161bc2f79 Add a new feature 'read from right to left'
A new feature 'read from right to left' is added, which is more fit for
Traditional Chinese and Japanese books. Once the feature is enabled:
1. The gesture region of TapForward and area will be flipped
horizonally;
2. The action for swiping to west and to east will be exchanged.
8 years ago
Frans de Jonge eb28513403 Fix 'screen server' typo (should be screensaver) 8 years ago
Qingping Hou 2e417cfbd8 filemanager(refactor): use purge method from docsettings 8 years ago
Qingping Hou f71534e399 readerfooter(fix): only populate footer info after document is loaded 8 years ago
Huang Xin f718b0669f Merge pull request #2045 from koreader/defaults
defaults(refactor): remove global hack in filemanagersetdefaults
8 years ago
Qingping Hou ac03cd241f fm(fix): close filemanager before showReader
This removes filemanager from UI widget stack so it does not listen
to events sent to the reader. Before this patch, screenshot event will
be sent to filemanager.
8 years ago
Qingping Hou 9586b36eb6 defaults(fix): purge entry from persistent file 8 years ago
Qingping Hou 476e35708d inputdialog(feat): add is_enter_default attribute to buttons 8 years ago
Qingping Hou 60587e08c6 defaults(refactor): remove global hack in filemanagersetdefaults
also added screensaver folder setting dialog for kobo
8 years ago
Zijie He 882a815f6c Use default font if settings.reader.lua does not provide one. Provide a Toggle button if readerfooter gesture actions are disabled. 8 years ago
chrox 4c491b5ee2 rename 'Highlight' to 'Highlight options' in menu
This should fix #2023.
8 years ago
Zijie He 1aa0c4192a Multi-line toggle switch & add instruction to resolve sdcv build error. 8 years ago
Qingping Hou 2cf4e77ae5 readerui(chore): rename _running_instance 8 years ago
Qingping Hou 0f3eeb24c9 progressbar(fix): persist progressbar visibility 8 years ago
Qingping Hou 0166ff8add reader(fix): force draw info message before loading document
Since the doShowReader will run in nextTick, it will get picked up by
checkTask, which is in the beginning of next UI loop and blocks
UIManager from redrawing the screen for the info popup.
8 years ago