19 Commits (master)

Author	SHA1	Message	Date
Benoit Pierre	fdd645af73	tests: minor cleanup	10 months ago
nairyo	983e083a0b	Center pdf manual zoom mode (#10246) ... Center PDF content when its width is smaller than the screen fix #9967	1 year ago
NiLuJe	fadee1f5dc	Clarify our OOP semantics across the codebase (#9586) ... Basically: * Use `extend` for class definitions * Use `new` for object instantiations That includes some minor code cleanups along the way: * Updated `Widget`'s docs to make the semantics clearer. * Removed `should_restrict_JIT` (it's been dead code since https://github.com/koreader/android-luajit-launcher/pull/283) * Minor refactoring of LuaSettings/LuaData/LuaDefaults/DocSettings to behave (mostly, they are instantiated via `open` instead of `new`) like everything else and handle inheritance properly (i.e., DocSettings is now a proper LuaSettings subclass). * Default to `WidgetContainer` instead of `InputContainer` for stuff that doesn't actually setup key/gesture events. * Ditto for explicit `*Listener` only classes, make sure they're based on `EventListener` instead of something uselessly fancier. * Unless absolutely necessary, do not store references in class objects, ever; only values. Instead, always store references in instances, to avoid both sneaky inheritance issues, and sneaky GC pinning of stale references. * ReaderUI: Fix one such issue with its `active_widgets` array, with critical implications, as it essentially pinned *all* of ReaderUI's modules, including their reference to the `Document` instance (i.e., that was a big-ass leak). * Terminal: Make sure the shell is killed on plugin teardown. * InputText: Fix Home/End/Del physical keys to behave sensibly. * InputContainer/WidgetContainer: If necessary, compute self.dimen at paintTo time (previously, only InputContainers did, which might have had something to do with random widgets unconcerned about input using it as a baseclass instead of WidgetContainer...). * OverlapGroup: Compute self.dimen at *init* time, because for some reason it needs to do that, but do it directly in OverlapGroup instead of going through a weird WidgetContainer method that it was the sole user of. * ReaderCropping: Under no circumstances should a Document instance member (here, self.bbox) risk being `nil`ed! * Kobo: Minor code cleanups.	2 years ago
NiLuJe	acbf4b7a8c	Document: Round dimensions properly in getPageDimensions (#8170) ... * Geom:transformByScale: * Apply the right scaling factor to the y axis * Round in a more sensible fashion (àla fz_round_rect, since we pretty much exclusively use it in a similar fashion). * Bump base (https://github.com/koreader/koreader-base/pull/1407)	3 years ago
NiLuJe	9cda84ef2f	Prevent Busted from blowing up on cdata finalizers by properly closing ... opened documents...	3 years ago
yparitcher	f7d538b108	Landscape FM / Refactor rotation (#6309) ... * landscape FM / Refactor rotation refactor and simplify the orientation handling code. the user generally cares about the rotation (what direction the device is facing) and not about if koreader is displaying in portrait or landscape mode * bump base update luasocket, libjpeg-turbo, curl add logging to evernote-sdk-lua update framebuffer for proper rotation	4 years ago
yparitcher	7b1ae4e486	continuous: do not limit visible area to page area (#5885) ... in scroll_mode allow visible area to be larger than one page allows proper scrolling om tall aspect ratios. Fixes #5876	4 years ago
Frans de Jonge	ec6e34cb1e	Change default zoom mode & add warning message for fit page + scroll (#5170) ... * [UX] Change default zoom mode to page width Fixes #5166. * Warning popup for weird scroll mode combinations	5 years ago
Frans de Jonge	4dc116ed6a	[fix, spec] re-enable ReaderView tests (#4970) ... It's not clear to me where the value is set as expected when running all tests linearly because it doesn't seem to be ReaderFooter.	5 years ago
Qingping Hou	1605409c60	rename runtimectl to document/canvascontext	5 years ago
Qingping Hou	4d8da96177	fix test	5 years ago
Frode Austvik	f12f317e9d	[spec] Replace custom assert[Not]AlmostEquals with assert.is[_not].near (#3885) ... Also, change "make static-check" to also check the tests.	6 years ago
Frans de Jonge	5bd288e378	[fix] #nocov on broken scroll mode tests	7 years ago
Hzj_jie	7d2ed4c3d0	Move kobo auto-suspension logic out of UIManager (#2933)	7 years ago
chrox	9ab005a1d3	fix unit test of readerlink and readerpaging ... and have more confidence with the unit testing framework. Now `make testfront` won't retry on failure and testing files are ordered in each run so that it's possible to reproduce testing failure. And this patch also fix flush settings not working before suspend issue: at some point the `FlushSettings` event is sent to `UIManager` instead of `ReaderUI`, but `UIManager` only delegated events to active widgets and `ReaderUI` is actually not an active widgets thus will miss the event. This patch also add a verbose debug mode with "-v" as a switch to turn on this mode. With verbose mode on, event handling will be logged.	8 years ago
Qingping Hou	3339ed4e5f	test(fix): update tests for default scroll mode	8 years ago
Qingping Hou	11d5b5c0a1	fix(readerlink): restore reader view context on go back	8 years ago
Qingping Hou	2d5222ef33	readerview: add get/set methods for view context	8 years ago
Qingping Hou	417bb5fb14	test: kill in fly hinting event	8 years ago