Archives/koreader
2
0
Fork 0
mirror of https://github.com/koreader/koreader synced 2024-11-10 01:10:34 +00:00
Code Issues Projects Releases Wiki Activity

Disable the legacy ReaderRotation module (#12309)

Browse Source 
AFAICT, this has never worked since the KPV -> KOReader refactor, as it relies on a weird little DrawContext "feature", while the actually in-use rotation framework is handled via BlitBuffer.

That kludge pollutes *a lot* of both the backend and frontend code, so I plan to annihilate that in a followup PR.

See #12303 for more context
This commit is contained in:
NiLuJe 2024-08-08 04:53:04 +02:00 committed by GitHub
parent 46a5d20513
commit cafa9c8251
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
frontend/apps/reader/readerui.lua
View File

@ -44,7 +44,7 @@ local ReaderLink = require("apps/reader/modules/readerlink")
local ReaderMenu = require("apps/reader/modules/readermenu") local ReaderMenu = require("apps/reader/modules/readermenu")
local ReaderPageMap = require("apps/reader/modules/readerpagemap") local ReaderPageMap = require("apps/reader/modules/readerpagemap")
local ReaderPanning = require("apps/reader/modules/readerpanning") local ReaderPanning = require("apps/reader/modules/readerpanning")
local ReaderRotation = require("apps/reader/modules/readerrotation") --local ReaderRotation = require("apps/reader/modules/readerrotation")
local ReaderPaging = require("apps/reader/modules/readerpaging") local ReaderPaging = require("apps/reader/modules/readerpaging")
local ReaderRolling = require("apps/reader/modules/readerrolling") local ReaderRolling = require("apps/reader/modules/readerrolling")
local ReaderSearch = require("apps/reader/modules/readersearch") local ReaderSearch = require("apps/reader/modules/readersearch")
@ -160,12 +160,15 @@ function ReaderUI:init()
view = self.view, view = self.view,
ui = self ui = self
}) })
-- rotation controller -- (legacy, and defunct) rotation controller
--- @fixme: Tripping this would break rendering, c.f., `Document:renderPage`
--[[
self:registerModule("rotation", ReaderRotation:new{ self:registerModule("rotation", ReaderRotation:new{
dialog = self.dialog, dialog = self.dialog,
view = self.view, view = self.view,
ui = self ui = self
}) })
--]]
-- Handmade/custom ToC and hidden flows -- Handmade/custom ToC and hidden flows
self:registerModule("handmade", ReaderHandMade:new{ self:registerModule("handmade", ReaderHandMade:new{
dialog = self.dialog, dialog = self.dialog,