From c190668d6fe8b04d3773bcf6c7183f3a475ae196 Mon Sep 17 00:00:00 2001 From: hasezoey Date: Sun, 18 Feb 2024 13:19:07 +0100 Subject: [PATCH] FileChooser: "percent - unopened - finished last" move value assignment after early-return re code review --- frontend/ui/widget/filechooser.lua | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/frontend/ui/widget/filechooser.lua b/frontend/ui/widget/filechooser.lua index 659f46241..d5851a7a1 100644 --- a/frontend/ui/widget/filechooser.lua +++ b/frontend/ui/widget/filechooser.lua @@ -233,7 +233,6 @@ local FileChooser = Menu:extend{ item.opened = DocSettings:hasSidecarFile(item.path) if item.opened then local doc_settings = DocSettings:open(item.path) - percent_finished = doc_settings:readSetting("percent_finished") local summary = doc_settings:readSetting("summary") -- books marked as "finished" should be considered the same as 100% @@ -241,6 +240,8 @@ local FileChooser = Menu:extend{ item.percent_finished = 1.0 return end + + percent_finished = doc_settings:readSetting("percent_finished") end -- smooth 2 decimal points (0.00) instead of 16 decimal numbers item.percent_finished = math.floor((percent_finished or -1) * 100) / 100