[fix] Crash on highlight in some situations (#3306)

7 years ago · b7785753c6
parent b483c54be8
commit b7785753c6
1 changed files with 4 additions and 2 deletions
--- a/frontend/apps/reader/modules/readerhighlight.lua
+++ b/frontend/apps/reader/modules/readerhighlight.lua
@ -402,7 +402,9 @@ function ReaderHighlight:onHoldRelease()
                        callback = function()
                            UIManager:scheduleIn(0.1, function()
                                self:lookupWikipedia()
-                                self:onClose()
+                                -- We don't call self:onClose(), we need the highlight
+                                -- to still be there, as we may Highlight it from the
+                                -- dict lookup widget
                            end)
                        end,
                    },
@ -410,7 +412,7 @@ function ReaderHighlight:onHoldRelease()
                        text = _("Dictionary"),
                        callback = function()
                            self:onHighlightDictLookup()
-                            self:onClose()
+                            -- We don't call self:onClose(), same reason as above
                        end,
                    },
                },