From ab4e27908b292ab7172f06bb2b1e203558780d96 Mon Sep 17 00:00:00 2001 From: hius07 <62179190+hius07@users.noreply.github.com> Date: Mon, 6 Sep 2021 18:08:48 +0300 Subject: [PATCH] Standardize: long-press/hold to long-press (#8185) * Gestures: standardize hold to long-press * Common settings menu: standardize hold to long-press * Readerstyletweak: standardize hold to long-press * Readersearch: standardize hold to long-press --- frontend/apps/reader/modules/readersearch.lua | 4 +++- frontend/apps/reader/modules/readerstyletweak.lua | 4 ++-- frontend/ui/elements/common_settings_menu_table.lua | 2 +- plugins/gestures.koplugin/main.lua | 8 ++++---- 4 files changed, 10 insertions(+), 8 deletions(-) diff --git a/frontend/apps/reader/modules/readersearch.lua b/frontend/apps/reader/modules/readersearch.lua index 07769450c..33061ee61 100644 --- a/frontend/apps/reader/modules/readersearch.lua +++ b/frontend/apps/reader/modules/readersearch.lua @@ -9,6 +9,7 @@ local Notification = require("ui/widget/notification") local UIManager = require("ui/uimanager") local logger = require("logger") local _ = require("gettext") +local Screen = Device.screen local T = require("ffi/util").template local ReaderSearch = InputContainer:new{ @@ -106,6 +107,7 @@ function ReaderSearch:onShowFulltextSearchInput() end self.input_dialog = InputDialog:new{ title = _("Enter text to search for"), + width = math.floor(Screen:getWidth() * 0.9), input = self.last_search_text, buttons = { { @@ -143,7 +145,7 @@ function ReaderSearch:onShowFulltextSearchInput() } self.input_dialog:addWidget(self.check_button_case) self.check_button_regex = CheckButton:new{ - text = _("Regular expression (hold for help)"), + text = _("Regular expression (long-press for help)"), checked = self.use_regex, parent = self.input_dialog, max_width = self.input_dialog._input_widget.width, diff --git a/frontend/apps/reader/modules/readerstyletweak.lua b/frontend/apps/reader/modules/readerstyletweak.lua index bb9df5e15..8053e19f2 100644 --- a/frontend/apps/reader/modules/readerstyletweak.lua +++ b/frontend/apps/reader/modules/readerstyletweak.lua @@ -359,7 +359,7 @@ function ReaderStyleTweak:init() -- enabled tweaks / none (without the need to disable each of -- them) table.insert(self.tweaks_table, { - text = _("Enable style tweaks (hold for info)"), + text = _("Enable style tweaks (long-press for help)"), checked_func = function() return self.enabled end, callback = function() self.enabled = not self.enabled @@ -547,7 +547,7 @@ You can enable individual tweaks on this book with a tap, or view more details a local book_tweak_item = { text_func = function() if self.book_style_tweak then - return _("Book-specific tweak (hold to edit)") + return _("Book-specific tweak (long-press to edit)") else return _("Book-specific tweak") end diff --git a/frontend/ui/elements/common_settings_menu_table.lua b/frontend/ui/elements/common_settings_menu_table.lua index d30fd7db0..9ecc8e9ab 100644 --- a/frontend/ui/elements/common_settings_menu_table.lua +++ b/frontend/ui/elements/common_settings_menu_table.lua @@ -238,7 +238,7 @@ common_settings.screen_notification = require("ui/elements/screen_notification_m common_settings.menu_activate = require("ui/elements/menu_activate") common_settings.screen_disable_double_tab = require("ui/elements/screen_disable_double_tap_table") common_settings.ignore_hold_corners = { - text = _("Ignore hold on corners"), + text = _("Ignore long-press on corners"), checked_func = function() return G_reader_settings:isTrue("ignore_hold_corners") end, diff --git a/plugins/gestures.koplugin/main.lua b/plugins/gestures.koplugin/main.lua index 29c0b7581..153e047ad 100644 --- a/plugins/gestures.koplugin/main.lua +++ b/plugins/gestures.koplugin/main.lua @@ -584,15 +584,15 @@ Default value: %1]]), GestureDetector.TWO_FINGER_TAP_DURATION/1000), end, }, { - text = _("Hold interval"), + text = _("Long-press interval"), keep_menu_open = true, callback = function() local SpinWidget = require("ui/widget/spinwidget") local GestureDetector = require("device/gesturedetector") local items = SpinWidget:new{ - title_text = _("Hold interval"), + title_text = _("Long-press interval"), info_text = T(_([[ -If a touch is not released in this interval, it is considered a hold (or long-press). On document's text, single word selection is then triggered. +If a touch is not released in this interval, it is considered a long-press. On document text, single word selection will then be triggered. The interval value is in milliseconds and can range from 100 (0.1 seconds) to 2000 (2 seconds). Default value: %1]]), GestureDetector.HOLD_INTERVAL/1000), @@ -674,7 +674,7 @@ function Gestures:addToMainMenu(menu_items) sub_item_table = self:genSubItemTable({"tap_top_left_corner", "tap_top_right_corner", "tap_left_bottom_corner", "tap_right_bottom_corner"}), }, { - text = _("Hold corner"), + text = _("Long-press on corner"), sub_item_table = self:genSubItemTable({"hold_top_left_corner", "hold_top_right_corner", "hold_bottom_left_corner", "hold_bottom_right_corner"}), }, {