Archives/koreader
2
0
Fork 0
mirror of https://github.com/koreader/koreader synced 2024-10-31 21:20:20 +00:00
Code Issues Projects Releases Wiki Activity

fix faked Tap event causes koreader crash

Browse Source 
Since there is a new clear method to clear highlight selection
the faked event is not needed when closing highlight

This should fix #847.
This commit is contained in:
chrox 2014-08-26 20:29:53 +08:00
parent 451092905e
commit 26e8dc7065
1 changed files with 11 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
frontend/apps/reader/modules/readerhighlight.lua
View File

@ -108,7 +108,7 @@ function ReaderHighlight:onSetDimensions(dimen)
end
end
function ReaderHighlight:onTap(arg, ges)
function ReaderHighlight:clear()
if self.hold_pos then
if self.ui.document.info.has_pages then
self.view.highlight.temp[self.hold_pos.page] = nil
@ -120,10 +120,15 @@ function ReaderHighlight:onTap(arg, ges)
UIManager:setDirty(self.dialog, "partial")
return true
end
if self.ui.document.info.has_pages then
return self:onTapPageSavedHighlight(ges)
else
return self:onTapXPointerSavedHighlight(ges)
end
function ReaderHighlight:onTap(arg, ges)
if not self:clear() then
if self.ui.document.info.has_pages then
return self:onTapPageSavedHighlight(ges)
else
return self:onTapXPointerSavedHighlight(ges)
end
end
end
@ -448,7 +453,7 @@ end
function ReaderHighlight:onClose()
UIManager:close(self.highlight_dialog)
-- clear highlighted text
self:handleEvent(Event:new("Tap"))
self:clear()
end
return ReaderHighlight